My fork - ownership of blocks, clans, teleports

For people working on the C++ code.
User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

Im arch Thanks
I love mods :D

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

There should be a /clan-home (set/restore) Or smth like that jachoo new todo list :D
I love mods :D

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

Alright... Let me summarize...

FEATURE REQUESTS:

1. Command /die [DONE]
2. Clans - admin / moderators / members [DONE]
3. Pairing teleports, two-way teleports [DONE]
4. Hidden teleport's destination position [priority:MEDIUM] [in progress]
5. Clan's spawn point [DONE]
6. Better graphics of teleport and borderstone [priority:LOW]
7. Client-side teleporting (faster, but will be problematic if server-side flying protection will be implemented) [DONE]
8. When player points to borderstone (s)he should see coordinates that it protects (some players find it confusing that it protects 16x16x16 grid and not blocks in radius around). [priority:MEDIUM]

BUGS REPORTED:

1. Borderstone should not have no owner [priority:HIGH] [in progress]
2. Better checking of teleport coords + teleport to 0,0,0 [DONE]
3. Prohibit mobs destroy clan's terrain. [DONE]
4. Teleports sometimes don't work [DONE] (see: request 7)
5. option: building/placing objects is not allowed outside of owned land if player points on border of owned land. [DONE]
6. Player has to jump if teleport is placed at eye level[DONE] (take note that this means player can be affected by 2 teleports at once - lower teleport will work)

OTHER:

1. Merge with celeron55 newest repository version [DONE]

-----------------

I'll try to publish a new version on the nearest weekend. Anyone wants to help?
Last edited by jachoo on Sun Oct 30, 2011 10:39, edited 1 time in total.

User avatar
placki
Member
Posts: 19
Joined: Sun Oct 23, 2011 23:21

by placki » Post

i can do 1,3,4 + bug1+bug2 if you haven't done that yet.

REQUESTS:
4. [DONE]
8. [DONE]

BUGS:
1. [DONE] (also fixed removing borderstone from inventory but not placing it on map if block already has owner)

btw: my git repository is here:
https://github.com/placki/minetest-jachoo
Last edited by placki on Wed Nov 02, 2011 16:52, edited 1 time in total.

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

OK. I'll try to do the rest, if I find some time this week...

Today I plan to merge with celeron's latest source.

//edit:

New version on github. Merged latest celeron's sources and some minor changes. I like bigger teleports ;)
Last edited by jachoo on Wed Oct 26, 2011 21:22, edited 1 time in total.

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

Oh there is another weird thing If i put a teleport on a wall 2 block high i cant teleport i have to jump so my legs are at 2 block high maybe thats supposed to be, but it should'nt be
I love mods :D

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

I need propositions for naming convention of clan members ;)

Temporally it is: admin-moderator-member

For "moderator" I propose "guard".

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

placki wrote:i can do 1,3,4 + bug1+bug2 if you haven't done that yet.
5. building/placing objects is not allowed outside of owned land if player points on border of owned land. [DONE]
NOOO!!! I did it intentionally!

Imagine that: you have built 16x1600x16 tower (aligned to map grid) and own it. Now, you don't want anyone to "stick" anything to walls or roof!

In my version if anybody want to "stick" blocks to such tower, he must firstly build his own tower next to yours :)

User avatar
placki
Member
Posts: 19
Joined: Sun Oct 23, 2011 23:21

by placki » Post

If player does not want anybody else to build too close, then (s)he should put more borderstones and do not build on edge...
But preferences can differ... so how about turning this into server option, so server owner can disable/enable building on border?
I guess same thing should be done for teleports: option 1: teleport anywhere, option 2: only when loop exists.

also about proposition 7 (client side teleport):
Server side teleports often do not work, because player position is updated periodically and if player moves too fast server is not notified of player being in teleport position. So maybe add to client sending forced/extra position update to server if entering into teleport range? This would still be bit laggy but would not require client knowing teleport destination and would remove "fast walking past" teleport bug.
Last edited by placki on Fri Oct 28, 2011 14:09, edited 1 time in total.

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

I've almost finished my part ;)

2. Clans - admin / moderators / members - 3 new commands
- /clan-promote <clan> <player> - adds <player> to <clan> and make him its moderator (clan owner command)
- /clan-degrade <clan> <player> - degrades <player> in <clan> from moderator to plain member (clan owner command)
- /clan-info - prints all player's clan membership and priviledges

Also, I added better error info in all clan-related commands.

5. Clan's spawn point - new command: /clan-spawn <clan> - makes your current player positions clan's spawn point (moderator command). If clan member will die, he will respawn at his nearest clan's spawnpoint

bugs:

3. Prohibit mobs destroy clan's terrain [done]
4. Teleports sometimes don't work - client-side teleporting repairs it

---------------

I have objections to bug 6. Maybe better way would be make teleport 2 block high? Making lower teleport more important than higher is not intuitive...

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

Maybe the 2 block high one should really BE 2 block high or if not maybe they should just be deleted and use only ground ones !!
I love mods :D

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

That would need introducing new block interface (multiple blocks as one object). IMO too complex to do it in this fork, such things should be precisely designed in main Minetest branch.

Alternatively, I propose as a workaround just draw teleports on walls half block higher and make them 2x higher.

----

What do you think about naming of clan members: Chief (clan creator/owner) - Guardian (clan moderator) - Member ?
Last edited by jachoo on Sun Oct 30, 2011 16:28, edited 1 time in total.

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

Chief sound like something with kitchen but yeah that might be nice & original
I love mods :D

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

I modified teleports. They emit light and are always 100% visible.

Image
Image

------

Code uploaded onto github. I wait for placki's work.
Last edited by jachoo on Sun Oct 30, 2011 22:43, edited 1 time in total.

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

EXCELLENT
I love mods :D

User avatar
WST
New member
Posts: 8
Joined: Tue Nov 01, 2011 01:09

by WST » Post

Can i help please?

User avatar
Menche
Member
Posts: 1001
Joined: Sat Jul 02, 2011 00:43
IRC: Menchers
In-game: Menche
Location: An island in a lava lake.

by Menche » Post

I think your latest windows build is too old to connect to the server. Could you make another?
An innocent kitten dies every time you top-post.

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

I'm planning to publish new windows binaries together with next minetest-jachoo version - after merging with placki's work

User avatar
WST
New member
Posts: 8
Joined: Tue Nov 01, 2011 01:09

by WST » Post

Hopefully i will be able to use it, cool

User avatar
placki
Member
Posts: 19
Joined: Sun Oct 23, 2011 23:21

by placki » Post

ok, my changes are done.
my git repository is here:
https://github.com/placki/minetest-jachoo

Possible bug:
When clan is removed what happen to its borderstones?
They should all be removed or changed to rock or steelblock.
Huge "foreach block" would be very slow.
But how about adding check to "block load from disk" and "block send to player"? That way removing/changing borderstones of deleted clan would be staggered.

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

Well, IMO it's not a big problem because deleting of clan should not be frequent.

For now, it's done this way:
1. Deleted clan is added to 'clans-deleted' list.
2. When any user action is performed on a MapBlock, its clan info is always checked of being on that list.
3. If it is - ownership info is cleared, but borderstones are left.

We can do additional checking of deleted clan on loading MapBlock on server (as you suggest). Then we could remove borderstones from it. I'll think about it.

User avatar
WST
New member
Posts: 8
Joined: Tue Nov 01, 2011 01:09

by WST » Post

does that mean i can use it?

User avatar
jachoo
Member
Posts: 45
Joined: Mon Sep 12, 2011 08:29

by jachoo » Post

Not yet...

User avatar
placki
Member
Posts: 19
Joined: Sun Oct 23, 2011 23:21

by placki » Post

The simplest solution would be checking for old borderstones from deleted clan before adding new BS. Preventing deploying second BS and displaying error message would be enough and is simple to code. Player has choice then: either find and destroy old BS and build own or find and rename old BS.

@WST: my git has only some patches over jachoo work, new version will be ready only after jachoo merges these changes and adds more fixes.

User avatar
Staffs
Member
Posts: 329
Joined: Thu Aug 04, 2011 13:16

by Staffs » Post

How does clan spawnpoint work ?? It says its done ...
I love mods :D

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 1 guest