[Mod] weather_pack 0.3

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

[Mod] weather_pack 0.3

by xeranas » Sun May 01, 2016 18:48

This weather mod tries to be simple (no water fluds, no growing snow). However it does basic indoor check, raining has sound.

Download and details on: https://github.com/xeranas/weather_pack
Licensing:
- Code: MIT
Mod dependencies: lightning
Tested on: Minetest 0.4.15

Image
Last edited by xeranas on Wed Jun 21, 2017 05:07, edited 12 times in total.
 

sofar
Developer
 
Posts: 1584
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] weather-pack

by sofar » Sun May 01, 2016 20:08

Is there a reason to make it a modpack? 99% of people will want all the components, not just one or two...
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Mon May 02, 2016 04:00

sofar wrote:Is there a reason to make it a modpack? 99% of people will want all the components, not just one or two...

I'm that 1% which will not use all weathers at least until 3685 will be implemented.
 

sofar
Developer
 
Posts: 1584
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] weather-pack

by sofar » Mon May 02, 2016 06:25

xeranas wrote:
sofar wrote:Is there a reason to make it a modpack? 99% of people will want all the components, not just one or two...

I'm that 1% which will not use all weathers at least until 3685 will be implemented.


that doesn't explain why it's a modpack.
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Mon May 02, 2016 15:05

To make weathers pluggable. While there no proper lua api for biomes check it makes sense to leave only weather which suits for your subgame. Deleting specific weather folder is most straightforward configuration to disable unwanted weather.

Second to that this mod is heavily modified fork (you can track history through github forks). It was already modpack originally and I decided leaved that way. I guess original authors dislike mods naming convention rules and I cannot blame them for that.
 

User avatar
D00Med
Member
 
Posts: 892
Joined: Sat Feb 07, 2015 22:49
Location: Australia...somewhere
GitHub: D00Med

Re: [Mod] weather-pack

by D00Med » Mon May 09, 2016 06:46

Can't you just make a config setting for weather, so that each type of weather can be enabled or disable with false/true? I did something similar in my subgame, but I don't know if it would work for a mod in any subgame.
Look! I have a signature :]
My subgame: https://forum.minetest.net/viewtopic.php?f=15&t=14051#p207242
dmobs2 is coming...
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Mon May 09, 2016 16:01

I'm glad that so far ppl sees only mod file structure issue. :)
 

Martin_Devil
Member
 
Posts: 190
Joined: Sat Apr 06, 2013 11:58
GitHub: MoNTE48
In-game: MoNTE48

Re: [Mod] weather-pack

by Martin_Devil » Mon May 09, 2016 23:56

Hi. Which version of the LGPL? LGPL 2.1, 2.1+ or 3.0?
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Tue May 10, 2016 04:25

Martin_Devil wrote:Hi. Which version of the LGPL? LGPL 2.1, 2.1+ or 3.0?

LGPL 2.1+
 

User avatar
ExeterDad
Member
 
Posts: 1616
Joined: Sun Jun 01, 2014 20:00
Location: New Hampshire U.S.A
In-game: ExeterDad

Re: [Mod] weather-pack

by ExeterDad » Tue May 10, 2016 10:27

I took this mod for a test drive last night and have to say I really like it a lot! No issues for me at all. I was most thrilled that the rain/snow didn't come into any of the structures that we had. All the weather was very immersive. And the sound clips were of great quality. I also noticed that I really couldn't see a drop in my fps when switching weather on and off. That's really great news for this eight year old laptop!
I hope you continue fine tuning this modpack as it's definitely a keeper.
 

User avatar
burli
Member
 
Posts: 1605
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] weather-pack

by burli » Tue May 10, 2016 16:40

Looks great. And I have a suggestion. Enable fog (if not enabled) and reduce the viewing range (if possible form a mod)
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Wed May 11, 2016 06:01

ExeterDad, thanks!

burli wrote:I have a suggestion. Enable fog (if not enabled) and reduce the viewing range (if possible form a mod)

Unfortunately, I did not find such functions on lua api. Maybe in future MT versions this would be possible (or somebody correct me if I missed).
 

User avatar
burli
Member
 
Posts: 1605
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] weather-pack

by burli » Wed May 11, 2016 06:20

To bad.

But what I want to know: why does weather mods use "sunlight_propagates"? Wouldn't it be better to use "walkable"?
 

User avatar
ErrorNull
Member
 
Posts: 199
Joined: Thu Mar 03, 2016 00:43

Re: [Mod] weather-pack

by ErrorNull » Wed May 11, 2016 17:45

yes, we are in need of lightweight weather mod. I'll try this tonight. please keep this going!
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Wed May 11, 2016 18:22

burli wrote:But what I want to know: why does weather mods use "sunlight_propagates"? Wouldn't it be better to use "walkable"?

Mod indoor check depends on get_node_light method. I would like to use more releable check but unfortunately I did not found replacement. Reason why it's not releable is that nodes with 'sunlight_propagates=true' (like glass) propagates 100% sunlight and there no way to differentiate whetever above (or far above) specific position is glass or air block.

As a workaround I introduce option to to override nodes like 'default:glass' sunlight_propagates value. This is more like expermental and disabled by default. Such glass would be useless for warm house like structures.
Code: Select all
if minetest.setting_getbool("weather_allow_override_nodes") then
  if minetest.registered_nodes["default:glass"] then
    minetest.override_item("default:glass", {sunlight_propagates = false})
  end


Propper way would be update engine that only air could propagates sun 100%. But seeing how many pending tickets already in queue I do not expect such change anytime soon.

Weather particles already uses 'collisiondetection = true' so checking for walkable would not give any positive effect. Unless I misunderstand your concept.
 

User avatar
Don
Member
 
Posts: 1642
Joined: Sat May 17, 2014 18:40
GitHub: DonBatman
IRC: Batman
In-game: Batman

Re: [Mod] weather-pack

by Don » Thu May 12, 2016 22:00

I believe someone was talking about making particles collide with solid objects. If they do then weather particles would stop even if it is glass. I am hoping for this cause of mymonths. It has weather in it. If the do add it I will try to remember to let you know.
Many of my mods are now a part of Minetest-mods. A place where you know they are maintained!

A list of my mods can be found here
 

sofar
Developer
 
Posts: 1584
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] weather-pack

by sofar » Thu May 12, 2016 22:15

Don wrote:I believe someone was talking about making particles collide with solid objects. If they do then weather particles would stop even if it is glass. I am hoping for this cause of mymonths. It has weather in it. If the do add it I will try to remember to let you know.


Patch pending, will likely be in 0.4.15 and dev builds soon!
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Fri May 13, 2016 04:51

Don wrote:I believe someone was talking about making particles collide with solid objects. If they do then weather particles would stop even if it is glass. I am hoping for this cause of mymonths. It has weather in it.

Seems mymonths uses vanilla weather mod. I guess reason why this mod was not used 'collisiondetection = true' for particles (aside performance) is because particles is quite big and on collision big particle would stay for a while (until expiration) on ground.

sofar wrote:Patch pending, will likely be in 0.4.15 and dev builds soon!

What patch is about? Particle collide already works for glass blocks.
 

User avatar
burli
Member
 
Posts: 1605
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] weather-pack

by burli » Fri May 13, 2016 07:46

xeranas wrote:
Don wrote:on collision big particle would stay for a while (until expiration) on ground.


I saw this with this weather-pack mod. If rain particles hits the ground they stay there for a short moment
 

sofar
Developer
 
Posts: 1584
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] weather-pack

by sofar » Fri May 13, 2016 14:15

xeranas wrote:
sofar wrote:Patch pending, will likely be in 0.4.15 and dev builds soon!

What patch is about? Particle collide already works for glass blocks.


this patch adds an option to the particle called "collision_remove". If you set it to "true", then the particle will be removed immediately if it collides with something. It obviously requires the "collisiondetection" option to be set to "true" as well.
 

User avatar
azekill_DIABLO
Member
 
Posts: 7207
Joined: Wed Oct 29, 2014 20:05
Location: Under my desk (but I can't see my monitor now X'[ )
GitHub: azekillDIABLO
In-game: azekill_DIABLO

Re: [Mod] weather-pack

by azekill_DIABLO » Sat May 14, 2016 14:20

this is the best weather mod i've ever seen ;) great job man!



*
【Voxellar 2.0】 ; 【MILA】 ; 【Rec_a_MT】 ; 【BB,HD】 ; 【▶ Youtube】 "Pizza is many people's lifeblood. The sauce is like nectar, dough is like ambrosia." -Chem871
 

User avatar
xeranas
Member
 
Posts: 151
Joined: Fri Feb 05, 2016 11:06
GitHub: xeranas

Re: [Mod] weather-pack

by xeranas » Sat May 14, 2016 20:51

Rainy weather now extinguish fire (if fire directly under sky). For this purpose ABM was used. Should not effect performance much as fire nodes normally aren't in big numbers. However I leaved option to disable ABM registration:
Code: Select all
weather_allow_abm=false
 

User avatar
Dopium
Member
 
Posts: 233
Joined: Sat Jun 09, 2012 15:43
Location: Australia

Re: [Mod] weather-pack

by Dopium » Fri May 20, 2016 09:03

Really like this mod as its very light weight but well done delivering all the atmosphere needed to make it feel as though its raining ect. Will be following this thread and excited to see further development on this mod. Personally i think all the elements are there, just needs some tweaking and bug fixes. I did get a small error although i think thunder may conflict with a 3d torches mod im using (not sure yet)
Code: Select all
ERROR[Main]: mod "thunder" has unsatisfied dependencies:  "lightning"
 

Martin_Devil
Member
 
Posts: 190
Joined: Sat Apr 06, 2013 11:58
GitHub: MoNTE48
In-game: MoNTE48

Re: [Mod] weather-pack

by Martin_Devil » Fri May 20, 2016 09:43

Dopium wrote:Really like this mod as its very light weight but well done delivering all the atmosphere needed to make it feel as though its raining ect. Will be following this thread and excited to see further development on this mod. Personally i think all the elements are there, just needs some tweaking and bug fixes. I did get a small error although i think thunder may conflict with a 3d torches mod im using (not sure yet)
Code: Select all
ERROR[Main]: mod "thunder" has unsatisfied dependencies:  "lightning"

Mod dependencies: lightning (by sofar)
 

User avatar
Dopium
Member
 
Posts: 233
Joined: Sat Jun 09, 2012 15:43
Location: Australia

Re: [Mod] weather-pack

by Dopium » Fri May 20, 2016 10:18

Thanks for the quick response, all is good now.
 

Next

Return to WIP Mods



Who is online

Users browsing this forum: No registered users and 6 guests