[Mod] Thirsty [thirsty] (WIP)

User avatar
Ben
Member
Posts: 160
Joined: Tue Mar 31, 2015 20:09

Re: [Mod] Thirsty [thirsty] (WIP)

by Ben » Post

Hello everyone, really sorry I haven't been active lately – I had some other issues besides Minetest, and then I got more into the C++ side of things, so any mod work ground to a halt…

Thirsty is one of my oldest mods, and my most complex by far. Too complex, actually. It will take me a while to get back into things, and to start working on it again. Long range plans are splitting it into two or more mods (base thirst and all the "tier" stuff) and using the in-engine player attributes. Short term: bug fixes, it seems ;-)

@Chibi ghost: check some of my posts on page 2 of this thread. The larger fountains need to be built somewhere and work when you are near them. The "amulet" thingies work by staying in your inventory, but you need a canteen or similar in there too for them to work. Unless of course they're bugged by now, in which case sorry :-(

@Lord_Vlad: the idea was that without damage turned on, these mods are pointless, I think, so that case is not deemed very important? I'd have to check, but I think that the effects are always considered (i.e. the attributes go up or down), but no damage is taken in any case. If it is, that's definitely a bug.

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Thirsty [thirsty] (WIP)

by Chibi ghost » Post

thank you

User avatar
Lord_Vlad
Member
Posts: 112
Joined: Thu Jul 20, 2017 07:58

Re: [Mod] Thirsty [thirsty] (WIP)

by Lord_Vlad » Post

Ben wrote:@Lord_Vlad: the idea was that without damage turned on, these mods are pointless, I think, so that case is not deemed very important? I'd have to check, but I think that the effects are always considered (i.e. the attributes go up or down), but no damage is taken in any case. If it is, that's definitely a bug.
Ideed no damage are taken, it just looks messy to still have them there when they aren't useful. I'm a bit of a maniac I guess, sorry.

User avatar
ManElevation
Member
Posts: 896
Joined: Tue Aug 02, 2016 22:04
GitHub: ManElevation
IRC: ManElevation
In-game: ManElevation
Location: Madrid,Spain

Re: [Mod] Thirsty [thirsty] (WIP)

by ManElevation » Post

I NEED WATER!
My Public Mods! Discord: Rottweiler Games#3368

User avatar
azekill_DIABLO
Member
Posts: 7497
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by azekill_DIABLO » Post

i just got a water bottle (flip)

Chem871
Member
Posts: 961
Joined: Sat Aug 19, 2017 21:49
GitHub: Chemguy99
In-game: Chem Nyx
Location: My Basement's Attic

Re: [Mod] Thirsty [thirsty] (WIP)

by Chem871 » Post

Would you make better canteens that last longer?
What is SCP-055?

User avatar
Hamlet
Member
Posts: 765
Joined: Sat Jul 29, 2017 21:09
IRC: H4mlet
In-game: Hamlet
Location: Lombardy, Italy

Re: [Mod] Thirsty [thirsty] (WIP)

by Hamlet » Post

I'm using your mod in my game and I like it very much, however I just realized that has a flaw that can be exploited to cheat:

water fountains can be carried around like canteens, but they are an infinite water source
thus, instead of using canteens a cheater could simply craft a water fountain/wash basin and carry it around

Would it be possible to make them work like canteens?
Example: a wash basin could hold three times the water being hold by a canteen, when it's exhausted you have to replenish it by hitting it with a water bucket (which would be turned into an empty bucket).

What do you think?
My repositories: Codeberg.org | My ContentDB's page | I'm on PureOS with XFCE

minerdudetest
Member
Posts: 38
Joined: Mon Jul 02, 2018 17:16

Re: [Mod] Thirsty [thirsty] (WIP)

by minerdudetest » Post

@Ben Hello! I have enhanced your mod with compatibility to Mineclone2 game by adding flexible detection-based recipes. Link to thread with my changes. Best!

Edit: pull request withdrawn due to errata
Last edited by minerdudetest on Mon Oct 15, 2018 08:23, edited 1 time in total.

minerdudetest
Member
Posts: 38
Joined: Mon Jul 02, 2018 17:16

Re: [Mod] Thirsty [thirsty] (WIP)

by minerdudetest » Post

Hamlet wrote: What do you think?
I think "cheating" is in the head, but your direction may be worthy fixing.

I mean:
1. craft bucket
2. take water
3. fill it in any block and stand there until refreshed
4. pick up the water...

minerdudetest
Member
Posts: 38
Joined: Mon Jul 02, 2018 17:16

Re: [Mod] Thirsty [thirsty] (WIP)

by minerdudetest » Post

@All, massive changes to "Thristy" just pushed. I have made a pull request. See.
Edit: pull request withdrawn due to errata, third time.

User avatar
Lord_Vlad
Member
Posts: 112
Joined: Thu Jul 20, 2017 07:58

Re: [Mod] Thirsty [thirsty] (WIP)

by Lord_Vlad » Post

Even bigger Mithril canteen would be enjoyed.

Also, compatibility with more food-related mods. Tons of fruits juice don't replenish thirst (though I may succeed in doing this myself in which case I'll provide the bits of code to change in an edit.)

MHL
Member
Posts: 405
Joined: Mon Aug 20, 2018 00:44
GitHub: NOT APPLICABLE
IRC: MCL
In-game: singleplayer
Location: Somewhere in SSWZ
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by MHL » Post

I get this error

Code: Select all

2019-02-19 22:35:07: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'main' in callback node_on_punch(): ...1/bin/../games/zombietest/mods/thirsty/functions.lua:260: attempt to call method 'get_player_name' (a nil value)
2019-02-19 22:35:07: ERROR[Main]: stack traceback:
2019-02-19 22:35:07: ERROR[Main]: 	...1/bin/../games/zombietest/mods/thirsty/functions.lua:260: in function 'drink_handler'
2019-02-19 22:35:07: ERROR[Main]: 	...1/bin/../games/zombietest/mods/thirsty/functions.lua:325: in function <...1/bin/../games/zombietest/mods/thirsty/functions.lua:319>
COME SEE MY MINETEST MAP!!! FRANCAIS TRADDUCCIONS COMING SOON! ČESKY PŘEKLAD JIŽ NEDLOUHO!!!

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by FreeGamers » Post

This mod works great for its purpose. I like it for the survival game. I'd recommend the "drinks" mod to be used with this as well.

This mod generates a lot of server log messages in Minetest v5.0.1 such as:

2019-06-29 08:30:08: WARNING[Server]: WARNING: minetest.setting_* functions are deprecated. Use methods on the minetest.settings object. (at ...are/games/minetest/mods/lib_player/thirsty/functions.lua:220)

Besides that I have not ran into any issues at all with this mod over month or two I've been using it. My only criticisms are that I don't quite understand how the water fountain and blocks for it work, Also, I think the textures for the canteens are a bit low-res. If I find better ones I'll share them here.
FreeGamers.org has moved to MeseCraft.net | FreeGamers on this forum is now MeseCraft

User avatar
Nathan.S
Member
Posts: 1052
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by Nathan.S » Post

I just made a pull request to update the code for Minetest 5.0 and up. This will remove the deprecated function messages, and adds a mod.conf so the folder doesn't need to be renamed. Now to wait for the pull request to be merged. :)
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by FreeGamers » Post

Thank god! You should see my server log!

To follow up on my other comments, I ended up disabling all of the other items apart from the canteen. For a survival server the water fountain was too OP. It could be quickly mined, picked up, and placed whenever a drink was needed.

So I decided to extend the canteen functionality to include tiered canteens that hold more water. Wood, Steel, Mithril, etc.

Redid the textures because the original canteens looks a bit ugly.

I've also added some sound effects to the canteen usage: sound on fill and a sound on drink. Its pretty good. I noticed some oddities like it still plays the sound effect even if the canteen is empty, but otherwise its been very nice so far. Since it was such a big aspect of the player, I thought it could use some polish.
FreeGamers.org has moved to MeseCraft.net | FreeGamers on this forum is now MeseCraft

User avatar
Nathan.S
Member
Posts: 1052
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by Nathan.S » Post

You could probably check out the diff on the pull request and very easily copy the changes over. I think I only modified four or five lines of code.
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by FreeGamers » Post

That was pretty simple! Thanks.
FreeGamers.org has moved to MeseCraft.net | FreeGamers on this forum is now MeseCraft

Merak
Member
Posts: 106
Joined: Sat Nov 05, 2016 20:34

Re: [Mod] Thirsty [thirsty] (WIP)

by Merak » Post

Can the user configure the speed at which the player becomes thirsty? I did not see it in the conf.

User avatar
Nathan.S
Member
Posts: 1052
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Thirsty [thirsty] (WIP)

by Nathan.S » Post

Check out the thirsty.default.conf file. It contains instructions on how to change the speed players get thirsty at.
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

timsoft
Member
Posts: 56
Joined: Sat Jun 04, 2016 20:38

Re: [Mod] Thirsty [thirsty] (WIP)

by timsoft » Post

is there a way to add thirst quenching for drinks from farming redo, such as milk, coffee, mint tea using Thirsty?

Post Reply

Who is online

Users browsing this forum: davidthecreator and 3 guests