[mod] Torch Sounds [wip]

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

[mod] Torch Sounds [wip]

by burli » Sun May 08, 2016 12:18

This mod adds new sounds to torches.
if placing/removing a torch a "swush" sound is played.

Continuos sound is removed because of some engine issues

Github: https://github.com/MarkuBu/torch_sounds

For Minetest Version: 0.4.14 (uses LBM)
Depends: default
Optional: torches
Version: 0.0.1
License: DWYWPL


Feel free to try and report bugs

View Video for demo

https://youtu.be/2OkIe0j3ZzA
Last edited by burli on Mon Mar 13, 2017 12:01, edited 7 times in total.
 

User avatar
TumeniNodes
Member
 
Posts: 2643
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: [mod] Torch Sounds [wip]

by TumeniNodes » Sun May 08, 2016 13:40

A nice mod that adds some ambience, thanks. These are the sort of subtle features which continue to make Minetest better all the time :)
I couldn't fix your brakes, so I made your horn louder.
 

User avatar
azekill_DIABLO
Member
 
Posts: 7472
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sun May 08, 2016 18:02

azekill_DIABLO wrote:i love the header of your game, who did it?? XD

Don't know. It was just there ;-)

TumeniNodes wrote:These are the sort of subtle features which continue to make Minetest better all the time :)


I have some more ideas like this.
 

sofar
Developer
 
Posts: 2001
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [mod] Torch Sounds [wip]

by sofar » Sun May 08, 2016 19:18

what is the license of this "mod"?

Edit: same for the audio files, I can't find any license info.?
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sun May 08, 2016 19:24

sofar wrote:what is the license of this "mod"?


Will be DWYWPL or something similar. Will add more informations soon
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Mon May 09, 2016 08:44

Add some more informations and reduced the length of the burning sound to 20 seconds. Attached the new file to the first post
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sat May 14, 2016 15:39

I tried my mod with the Karsthafen map. There are lots of default torches. There is a bug if the 3d torches mod has to convert the torches first. And if there are many torches I get an out of memory warning.

I also add a random delay in the lbm becaus it sounds strange if many torches are "ignited" at nearly the same time
Last edited by burli on Sat May 14, 2016 16:12, edited 1 time in total.
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sat May 14, 2016 15:51

Is there a limit of playable sounds in mintest?
 

User avatar
azekill_DIABLO
Member
 
Posts: 7472
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO

Re: [mod] Torch Sounds [wip]

by azekill_DIABLO » Sat May 14, 2016 17:03

yes.

exemple: in old MT version (4.6 i think) i started a fire in a forest (IMMA PIXEL ARSONIST!!) and, after a while i got some error about sounds, huge and strange noises and then silence....

add a range for listening sounds (15 nodes is perfect) and you will not have problems ;)
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sat May 14, 2016 17:27

azekill_DIABLO wrote:add a range for listening sounds (15 nodes is perfect) and you will not have problems ;)

Well, that does not work with my solution. If I set eg max_hear_distance=5, then only torches near to the player will play a sound. The other torches remain silent.

I guess I have to find another solution. Maybe I try "find_nodes_in_area" to turn the sound on and the node timer to turn the sound off. As long as the node is near the player the timer will reset every few seconds
 

User avatar
azekill_DIABLO
Member
 
Posts: 7472
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO

Re: [mod] Torch Sounds [wip]

by azekill_DIABLO » Sun May 15, 2016 10:23

burli wrote:Well, that does not work with my solution. If I set eg max_hear_distance=5, then only torches near to the player will play a sound. The other torches remain silent.


what's the problem? only players can hear sounds, so it's useful to play them when torches are near you, no?
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Sun May 15, 2016 11:57

azekill_DIABLO wrote:what's the problem? only players can hear sounds, so it's useful to play them when torches are near you, no?

You make the same mistake as I did. max_hear_distance is the distance between sound and player, where you can hear the sound when you execute sound_play. So if the player is within the radius, when sound_play is executed, he can hear the sound, otherwise not.

Try yourself. Set all max_hear_distance to 2. Then place a torch inside the radius. You can hear the sound, even if you walk away. Then place a torch outside the radius. You don't hear a sound, even if you get closer to the torch

max_hear_distance is not the distance you can hear a sound or not. It is the distance where sounds are added to the node or not.

Hope you understand what I mean. My english is not so good
 

User avatar
azekill_DIABLO
Member
 
Posts: 7472
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 

Kevin Tee
Member
 
Posts: 64
Joined: Wed Jul 22, 2015 04:00
Location: Thailand

Re: [mod] Torch Sounds [wip]

by Kevin Tee » Mon May 16, 2016 15:54

This mod conflicted with the torches (3d torches) mod.

2016-05-16 22:52:53: WARNING[Main]: NodeDefManager: Ignoring CONTENT_IGNORE redefinition
2016-05-16 22:52:53: WARNING[Main]: Field "tile_images": Deprecated; new name is "tiles".
2016-05-16 22:52:53: WARNING[Main]: Field "light_propagates": Deprecated; determined from paramtype
2016-05-16 22:52:53: ERROR[Main]: ModError: Failed to load and run script from /home/user/.minetest/mods/torches_sounds/init.lua:
2016-05-16 22:52:53: ERROR[Main]: /home/user/.minetest/mods/torches_sounds/init.lua:33: Attempt to override non-existent item default:torch_wall
2016-05-16 22:52:53: ERROR[Main]: stack traceback:
2016-05-16 22:52:53: ERROR[Main]: [C]: in function 'error'
2016-05-16 22:52:53: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:338: in function 'override_item'
2016-05-16 22:52:53: ERROR[Main]: /home/user/minetest/mods/torches_sounds/init.lua:33: in main chunk
2016-05-16 22:52:53: ERROR[Main]: Check debug.txt for details.
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Mon May 16, 2016 16:19

I only tested it with the latest version of sofars mod (see first post). There is a known issue if the torches mod has to convert default torches to 3d torches.

Because of other issues I will rewrite the code.
 

User avatar
burli
Member
 
Posts: 1619
Joined: Fri Apr 10, 2015 13:18

Re: [mod] Torch Sounds [wip]

by burli » Mon Mar 13, 2017 12:03

My torch sound mod is back, but a little bit simpler for now. I removed the continuous sound because of some engine issues.

I just replace the dig and replace sound for now
 

User avatar
azekill_DIABLO
Member
 
Posts: 7472
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 


Return to WIP Mods



Who is online

Users browsing this forum: No registered users and 1 guest