[Mod] bank_sell_protector -- Sell your protectors

User avatar
gpcf
Member
 
Posts: 274
Joined: Fri May 27, 2016 10:48
In-game: gabriel

[Mod] bank_sell_protector -- Sell your protectors

by gpcf » Tue Jun 28, 2016 13:15

This mod allows you to sell protectors. It is a fork of TenPlus1's Protector Redo with the ability to sell the protectors. It requires the atm mod and the currency mod. You pay directly from your bank account. As the protector redo mod, it is licensed under WTFPL. This mod replaces the protector_redo mod and is not compatible with it.

Get it from https://git.gpcf.eu/protector.git

NOTE: This mod is unmaintained, since linuxworks server switched over to areas.
Last edited by gpcf on Sun Sep 09, 2018 18:00, edited 2 times in total.
 

User avatar
rubenwardy
Moderator
 
Posts: 5545
Joined: Tue Jun 12, 2012 18:11
Location: United Kingdom
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] protector -- Sell your protectors

by rubenwardy » Tue Jun 28, 2016 13:52

Please rename this mod to something like bank_sell_protectors and put it in the title like so:

[Mod] Sell Protectors [bank_sell_protectors]
 

User avatar
casp3r
Member
 
Posts: 21
Joined: Sat Nov 11, 2017 10:38

Re: [Mod] bank_sell_protector -- Sell your protectors

by casp3r » Sat Sep 08, 2018 23:36

good, but it was better if we can enter the price with the keyboard :)

5000 Mg price with "+1 - 10Mg note" click,click,click 500 times up to break your finger ;p

and "for sale" texture not terrible i think just protect block texture with a money sign look better (or mg note) but it's just details i would do it myself

it's seems to work but i still have not fully tested it on everything i imagine that it works as the original for the rest

otherwise i love the concept to sell buildings
 

Byakuren
Member
 
Posts: 816
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [Mod] bank_sell_protector -- Sell your protectors

by Byakuren » Sun Sep 09, 2018 01:55

Why does this need to be a fork as opposed to a separate mod that lets you sell protectors?
Every time a mod API is left undocumented, a koala dies.
 

User avatar
TenPlus1
Member
 
Posts: 2422
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

Re: [Mod] bank_sell_protector -- Sell your protectors

by TenPlus1 » Sun Sep 09, 2018 07:05

gpcf: you cannot fork someone else's mod and change the license, I would however recommend you making a separate named mod that sells the protectors only by overriding certain functions of the original mod.
 

User avatar
Hume2
Member
 
Posts: 167
Joined: Tue Jun 19, 2018 08:24
Location: Czech Republic
GitHub: Hume2
In-game: Hume2

Re: [Mod] bank_sell_protector -- Sell your protectors

by Hume2 » Sun Sep 09, 2018 10:59

TenPlus1 wrote:gpcf: you cannot fork someone else's mod and change the license...

Who said that? It depends on the license whether it can or can't be changed to something else. According to this, MIT license doesn't require the people to use the same license for derivatives. Correct me if I'm not right.

Also good mod, gpcf!
If you lack the reality, go on a trip or find a job.
 

Byakuren
Member
 
Posts: 816
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [Mod] bank_sell_protector -- Sell your protectors

by Byakuren » Sun Sep 09, 2018 17:19

Hume2 wrote:
TenPlus1 wrote:gpcf: you cannot fork someone else's mod and change the license...

Who said that? It depends on the license whether it can or can't be changed to something else. According to this, MIT license doesn't require the people to use the same license for derivatives. Correct me if I'm not right.

Also good mod, gpcf!

You can license the derivative under something else but the MIT license requires that you include it too.
Every time a mod API is left undocumented, a koala dies.
 

User avatar
gpcf
Member
 
Posts: 274
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] bank_sell_protector -- Sell your protectors

by gpcf » Sun Sep 09, 2018 17:59

@TenPlus1: This is an old mod, I forked before you changed the license. I will no longer maintain this mod, since we have since moved over to the areas mod for protection.
 

User avatar
TenPlus1
Member
 
Posts: 2422
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1
 

User avatar
sorcerykid
Member
 
Posts: 861
Joined: Fri Aug 26, 2016 15:36
Location: Illinois, USA
GitHub: sorcerykid
In-game: Nemo

Re: [Mod] bank_sell_protector -- Sell your protectors

by sorcerykid » Sun Sep 09, 2018 23:11

TenPlus1 wrote:gpcf: you cannot fork someone else's mod and change the license, I would however recommend you making a separate named mod that sells the protectors only by overriding certain functions of the original mod.


Technically, that depends on the license. For example, LGPL works can be relicensed as GPL. And in theory WTFPL works can be relicensed as anything,. (Disclaimer: I'm not a lawyer, and this is not legal advice :)
 

Byakuren
Member
 
Posts: 816
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [Mod] bank_sell_protector -- Sell your protectors

by Byakuren » Wed Sep 12, 2018 17:29

IMO the mod should just have a different name with different nodes. It's not really the same thing as protector. (Assuming the thing that changed is you can right click on a protector to buy its space, it's not clear from the OP)
Every time a mod API is left undocumented, a koala dies.
 


Return to WIP Mods



Who is online

Users browsing this forum: No registered users and 3 guests