[mod] Vehicles [vehicles]

[krokoschlange]

Nice mod but:
Bad bug:

Code: Select all

2017-06-03 16:37:37: ACTION[Server]: krokoschlange right-clicks object 2978: LuaEntitySAO at (534,26.5,506)
2017-06-03 16:37:37: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'vehicles' in callback luaentity_Step(): /home/fabian/.minetest/mods/vehicles/api.lua:190: attempt to perform arithmetic on global 'timer' (a userdata value)
2017-06-03 16:37:37: ERROR[Main]: stack traceback:
2017-06-03 16:37:37: ERROR[Main]: 	/home/fabian/.minetest/mods/vehicles/api.lua:190: in function 'object_drive'
2017-06-03 16:37:37: ERROR[Main]: 	/home/fabian/.minetest/mods/vehicles/api.lua:803: in function </home/fabian/.minetest/mods/vehicles/api.lua:801>
2017-06-03 16:37:37: ERROR[Main]: 	(tail call): ?

This happens randomly (for me it was after a few hours of playing in a world), but when it happens it happens to all cars in the world. Only way to fix is disable the mod, remove all objects and enable again.(didn't work very well, after a few new cars placed, it crashed again with the same error)
You are able to enter and leave the car, steer and even drive backwards but when you press [W] it crashes
EDIT: only happens in a certain region of the map
EDIT: seems it only happens when you are near to these blinking lights from streets 2.0.1:

EDIT: thats why (I think): the blinking light also uses a global variable called timer

Code: Select all

-- Blinking Light

minetest.register_node("streets:roadwork_blinking_light_off", {
	description = "Blinking Light",
	paramtype = "light",
	paramtype2 = "facedir",
	drawtype = "nodebox",
	tiles = { "streets_roadwork_blinking_light_top.png", "streets_roadwork_blinking_light_top.png", "streets_roadwork_blinking_light_off.png" },
	sunlight_propagates = true,
	groups = { cracky = 1 },
	node_box = {
		type = "fixed",
		fixed = {
			{ -0.1875, -0.5, -0.125, 0.1875, -0.3125, 0.125 }, -- Base
			{ -0.1875, -0.3125, 0, 0.1875, 0.0625, 0 }, -- Light
		}
	},
	on_timer = function(pos, elapsed)
		minetest.set_node(pos, { name = "streets:roadwork_blinking_light_on", param2 = minetest.get_node(pos).param2 })
	end,
	on_construct = function(pos)
LOOK HERE >>> timer = minetest.get_node_timer(pos)
LOOK HERE >>> timer:start(1)
	end,
})

minetest.register_node("streets:roadwork_blinking_light_on", {
	description = "Blinking Light",
	paramtype = "light",
	paramtype2 = "facedir",
	drawtype = "nodebox",
	tiles = { "streets_roadwork_blinking_light_top.png", "streets_roadwork_blinking_light_top.png", "streets_roadwork_blinking_light_on.png" },
	sunlight_propagates = true,
	groups = { cracky = 1, not_in_creative_inventory = 1 },
	node_box = {
		type = "fixed",
		fixed = {
			{ -0.1875, -0.5, -0.125, 0.1875, -0.3125, 0.125 }, -- Base
			{ -0.1875, -0.3125, 0, 0.1875, 0.0625, 0 }, -- Light
		}
	},
	light_source = 12,
	on_timer = function(pos, elapsed)
		minetest.set_node(pos, { name = "streets:roadwork_blinking_light_off", param2 = minetest.get_node(pos).param2 })
	end,
	on_construct = function(pos)
LOOK HERE >>> timer = minetest.get_node_timer(pos)
LOOK HERE >>> timer:start(1)
	end,
	drop = "streets:roadwork_blinking_light_off",
})

EDIT: seems to be fixed when you rename the timer variable :)

[Desour]

seems to be fixed when you rename the timer variable :)

Eh, just make the variable local. :P

[azekill_DIABLO]

+1

[krokoschlange]

seems to be fixed when you rename the timer variable :)

Eh, just make the variable local. :P

I know, it's better :)

[D00Med]

Glad it's sorted :) I will rename the timer in my mod to something less obvious, just in case there are other mods which could cause the same problem.

[Desour]

Glad it's sorted :) I will rename the timer in my mod to something less obvious, just in case there are other mods which could cause the same problem.

If the timer really has to be global, have you thought of making a global vehicles table variable and save the timer in it?

[D00Med]

I don't think it has to be global.

[Robsoie]

Try it now, I think I've fixed it.

Just tested newest version now with recently released 0.4.16 and it does not crash anymore when punching a car to restore it into inventory, good job !
Though not sure if it's intended, but now you need to punch it a lot of time before the vehicle disappear.

And when it disappear, it does not leave the "vehicle block" anymore to be picked, it's like it's now completely destroyed.

[krokoschlange]

Glad it's sorted :) I will rename the timer in my mod to something less obvious, just in case there are other mods which could cause the same problem.

If the timer really has to be global, have you thought of making a global vehicles table variable and save the timer in it?

I don't think it has to be global.

a local variable does the job. tested it.

[Andrey01]

Is work going still for new update?

[D00Med]

Ok, thanks for testing guys.
Yep I'm still working on an update, I'm halfway through making a truck

[v-rob]

Mod seems to crash every time I press E after getting to full speed. No other mods enabled, minetest version 4.16. Only happens when you reach a high speed.

[D00Med]

Should be fixed now, I forgot to switch over the timer name for boosts.
By the way, that's a nice signature you have there xD

[v-rob]

It works now! Thanks.

By the way, that's a nice signature you have there xD

Thanks for that, too. I like it myself, and it's very true :)

[mahmutelmas06]

Could u make all cars be able to take passengers ?

[D00Med]

I could, but it would take away the novelty of using a ute.

[krokoschlange]

Another really bad bug: When I get into ute as passenger it just closes the server. No debug.

[D00Med]

wow ok, thanks for pointing that out, I haven't had an opportunity to test that for a while

[krokoschlange]

just open two windows host a server in one window and in the other one connect to ip 127.0.0.1

[Andrey01]

Ok, thanks for testing guys.
Yep I'm still working on an update, I'm halfway through making a truck

What about bus? I need much it! For example, they will be colorful and will have different sizes.

[D00Med]

@krokoschlange oh yeah I forgot about that, thanks.
@Andrey01 I'll work on that next then.

[moi]

Hello, I have a problem with this mod. it does not work.

2017-06-13 20:49:32: ERROR[Main]: ModError: Failed to load and run script from /home/moi/.minetest/mods/vehicles/init.lua:
2017-06-13 20:49:32: ERROR[Main]: /home/moi/.minetest/mods/vehicles/init.lua:7: attempt to concatenate a nil value
2017-06-13 20:49:32: ERROR[Main]: stack traceback:
2017-06-13 20:49:32: ERROR[Main]: /home/moi/.minetest/mods/vehicles/init.lua:7: in main chunk

What should I do ?
Help me please.

[D00Med]

I'm not sure why that's happening. Were you using any other mods that could have caused a problem?

[Picocoder]

Amazing Mod!!

Although, there are a few changes that could be cool.

- Maybe a "hover" mode for the helicopters and airplanes?
- Maybe a submarine that allows for breathing underwater?
- Maybe an amphibious vehicle or two?

These are just some changes that I think would be fun, the mod is great without them.

[D00Med]

Those are good suggestions, thanks! :)