Page 1 of 1

[mod] Ore cutting mod [orecutting]

PostPosted: Tue Aug 15, 2017 14:37
by bell07
If you like my woodcutting mod you need to try the new orecutting mod. Start digging process on ores and and stone between ores using the sneak key. More details later...

License: LGPL-3
Dependencies: None
Code/Download: https://github.com/bell07/minetest-orecutting
Recipes: none

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Tue Aug 15, 2017 16:06
by azekill_DIABLO
i feel some chain reactions coming.

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Thu Aug 17, 2017 20:43
by Lord_Vlad
Code: Select all
2017-08-17 22:26:49: ACTION[Main]: World at [/home/user/.minetest/worlds/efe]
2017-08-17 22:26:49: ACTION[Main]: Server for gameid="minetest" listening on 0.0.0.0:64419.
2017-08-17 22:26:49: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'orecutting' in callback environment_Step(): /home/user/.minetest/mods/orecutting/init.lua:338: bad argument #1 to 'get_content_id' (string expected, got table)
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:49: ERROR[Main]:    [C]: in function 'get_content_id'
2017-08-17 22:26:49: ERROR[Main]:    /home/user/.minetest/mods/orecutting/init.lua:338: in function 'func'
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/common/after.lua:18: in function </usr/share/minetest/builtin/common/after.lua:4>
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/game/register.lua:412: in function </usr/share/minetest/builtin/game/register.lua:392>
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:50: ACTION[Main]: [mana] Server shuts down. Rescuing data into mana.mt
2017-08-17 22:26:50: ACTION[Main]: [mana] Wrote mana data into /home/user/.minetest/worlds/efe/mana.mt.
2017-08-17 22:26:50: ACTION[Main]: [morecommands] Wrote whitelist data into /home/user/.minetest/worlds/efe/whitelist.mt.
2017-08-17 22:26:50: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2017-08-17 22:26:50: ACTION[Main]: [doc] Wrote player data into /home/user/.minetest/worlds/efe/doc.mt.


Geominer and this mod do this... I don't know which one should get fixed so I give the error in both topics.

Edit : Also, is it only me, or is your falling stone indestructible after falling ? even in creative, I can't break any.

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Thu Aug 17, 2017 22:09
by Devy
Lord_Vlad wrote:
Code: Select all
2017-08-17 22:26:49: ACTION[Main]: World at [/home/user/.minetest/worlds/efe]
2017-08-17 22:26:49: ACTION[Main]: Server for gameid="minetest" listening on 0.0.0.0:64419.
2017-08-17 22:26:49: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'orecutting' in callback environment_Step(): /home/user/.minetest/mods/orecutting/init.lua:338: bad argument #1 to 'get_content_id' (string expected, got table)
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:49: ERROR[Main]:    [C]: in function 'get_content_id'
2017-08-17 22:26:49: ERROR[Main]:    /home/user/.minetest/mods/orecutting/init.lua:338: in function 'func'
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/common/after.lua:18: in function </usr/share/minetest/builtin/common/after.lua:4>
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/game/register.lua:412: in function </usr/share/minetest/builtin/game/register.lua:392>
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:50: ACTION[Main]: [mana] Server shuts down. Rescuing data into mana.mt
2017-08-17 22:26:50: ACTION[Main]: [mana] Wrote mana data into /home/user/.minetest/worlds/efe/mana.mt.
2017-08-17 22:26:50: ACTION[Main]: [morecommands] Wrote whitelist data into /home/user/.minetest/worlds/efe/whitelist.mt.
2017-08-17 22:26:50: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2017-08-17 22:26:50: ACTION[Main]: [doc] Wrote player data into /home/user/.minetest/worlds/efe/doc.mt.


Geominer and this mod do this... I don't know which one should get fixed so I give the error in both topics.

Edit : Also, is it only me, or is your falling stone indestructible after falling ? even in creative, I can't break any.


I ausume the edit was aimed at me. I just looked at the falling stone, and yes it is indestructible. I'll fix it when I get home.

Edit: should be fixed now.

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Fri Aug 18, 2017 05:05
by bell07
I see the ore.wherein can be "-- ^ a list of nodenames is supported too" in mintest-lua-API. So I fixed it in orecutting, the issue should not be happen anymore.
Asume the geominer registers some new ores that is cuttable by orecutting now.

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Fri Aug 18, 2017 06:08
by Devy
bell07 wrote:I see the ore.wherein can be "-- ^ a list of nodenames is supported too" in mintest-lua-API. So I fixed it in orecutting, the issue should not be happen anymore.
Asume the geominer registers some new ores that is cuttable by orecutting now.


I'm the author of Geominer. Thanks you for adding the ores my mod adds! I haven't looked at the way you are handling ores in your mod, but there might be a way to add all ores that any mod adds. Have a look here: https://github.com/minetest/minetest/blob/55ab4264dc3f42a4588de0cf52e8f0f88e4fd90e/doc/lua_api.txt#L3105-L3106. Just a thought! Thank you.

Edit: forget what I said. I just looked at your code and you already know about this table.

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Fri Aug 18, 2017 10:10
by ManElevation
Sounds good

Re: [mod] Ore cutting mod [orecutting]

PostPosted: Fri Aug 18, 2017 20:00
by Lord_Vlad
Devy wrote:
Lord_Vlad wrote:
Code: Select all
2017-08-17 22:26:49: ACTION[Main]: World at [/home/user/.minetest/worlds/efe]
2017-08-17 22:26:49: ACTION[Main]: Server for gameid="minetest" listening on 0.0.0.0:64419.
2017-08-17 22:26:49: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'orecutting' in callback environment_Step(): /home/user/.minetest/mods/orecutting/init.lua:338: bad argument #1 to 'get_content_id' (string expected, got table)
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:49: ERROR[Main]:    [C]: in function 'get_content_id'
2017-08-17 22:26:49: ERROR[Main]:    /home/user/.minetest/mods/orecutting/init.lua:338: in function 'func'
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/common/after.lua:18: in function </usr/share/minetest/builtin/common/after.lua:4>
2017-08-17 22:26:49: ERROR[Main]:    /usr/share/minetest/builtin/game/register.lua:412: in function </usr/share/minetest/builtin/game/register.lua:392>
2017-08-17 22:26:49: ERROR[Main]: stack traceback:
2017-08-17 22:26:50: ACTION[Main]: [mana] Server shuts down. Rescuing data into mana.mt
2017-08-17 22:26:50: ACTION[Main]: [mana] Wrote mana data into /home/user/.minetest/worlds/efe/mana.mt.
2017-08-17 22:26:50: ACTION[Main]: [morecommands] Wrote whitelist data into /home/user/.minetest/worlds/efe/whitelist.mt.
2017-08-17 22:26:50: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2017-08-17 22:26:50: ACTION[Main]: [doc] Wrote player data into /home/user/.minetest/worlds/efe/doc.mt.


Geominer and this mod do this... I don't know which one should get fixed so I give the error in both topics.

Edit : Also, is it only me, or is your falling stone indestructible after falling ? even in creative, I can't break any.


I ausume the edit was aimed at me. I just looked at the falling stone, and yes it is indestructible. I'll fix it when I get home.

Edit: should be fixed now.


Great that both are fixed. Thanks to both of you :) yeah, I messed up in my edit XD