Armor Addon (WIP)

Chem871
Member
Posts: 999
Joined: Sat Aug 19, 2017 21:49
GitHub: Chemguy99
In-game: Chem Nyx
Location: My Basement's Attic

Re: Armor Addon (WIP)

by Chem871 » Post

They would have to just erase the craft in crafts.lua. If you can't craft it, you can't have it.
What is SCP-055?

Duvalon
Member
Posts: 43
Joined: Thu Jun 18, 2020 00:32
Location: Canada

Re: Armor Addon (WIP)

by Duvalon » Post

Hi @Chem871

Just wondering if you are still interested in maintaining this mod? I have a few modifications I'd like to make and I'd like to know if I should submit a pull request or fork it.

Thanks!

Chem871
Member
Posts: 999
Joined: Sat Aug 19, 2017 21:49
GitHub: Chemguy99
In-game: Chem Nyx
Location: My Basement's Attic

Re: Armor Addon (WIP)

by Chem871 » Post

I'm finished with this mod, if you'd like to fork it, go for it. Just check the license.
What is SCP-055?

User avatar
TenPlus2
Member
Posts: 22
Joined: Sun May 09, 2021 20:54

Re: Armor Addon (WIP)

by TenPlus2 » Post

I know that mentioning this typo four years later is a bit of a bummer but, you have a typo which makes ruby armor non-craftable. This bug was discovered by user Festus1965.

https://github.com/Chemguy99/armor_addo ... ts.lua#L21

ruby = "gems:ruby:gem", should be ruby = "gems:ruby_gem",

Otherwise cool mod, I like it. I like the speed bonuses and things like that. It's good.
Last edited by TenPlus2 on Mon May 24, 2021 09:10, edited 1 time in total.

User avatar
TenPlus2
Member
Posts: 22
Joined: Sun May 09, 2021 20:54

Re: Armor Addon (WIP)

by TenPlus2 » Post

Duvalon wrote:
Tue Sep 01, 2020 02:45
Hi @Chem871

Just wondering if you are still interested in maintaining this mod? I have a few modifications I'd like to make and I'd like to know if I should submit a pull request or fork it.

Thanks!
What modifications are you suggesting, did you make any progress with these?

Duvalon
Member
Posts: 43
Joined: Thu Jun 18, 2020 00:32
Location: Canada

Re: Armor Addon (WIP)

by Duvalon » Post

TenPlus2 wrote:
Mon May 24, 2021 09:09
What modifications are you suggesting, did you make any progress with these?
Sorry for the late reply. I've been away from minetest for a while.

I ended up forking the project and creating MOAR! ARMOURS! The most obvious change is with regards to translation. Otherwise, not much has changed. It's available to download on ContentDB.

If you have ideas or corrections please submit as new issues or pull requests.

Duvalon
Member
Posts: 43
Joined: Thu Jun 18, 2020 00:32
Location: Canada

Re: Armor Addon (WIP)

by Duvalon » Post

Chem871 wrote:
Wed Sep 02, 2020 15:34
I'm finished with this mod, if you'd like to fork it, go for it. Just check the license.
The Why Not? game maintainers are going over licenses of its included mods and moarmour (fork of armor addon) is problematic because it is licensed GPLv2-only. (https://github.com/minetest-whynot/whyn ... issues/134)

Would you agree to using GPLv2-or-later instead? That way it would allow us to use GPLv3.

Chem871
Member
Posts: 999
Joined: Sat Aug 19, 2017 21:49
GitHub: Chemguy99
In-game: Chem Nyx
Location: My Basement's Attic

Re: Armor Addon (WIP)

by Chem871 » Post

Duvalon wrote:
Sun Oct 16, 2022 03:22
Chem871 wrote:
Wed Sep 02, 2020 15:34
I'm finished with this mod, if you'd like to fork it, go for it. Just check the license.
The Why Not? game maintainers are going over licenses of its included mods and moarmour (fork of armor addon) is problematic because it is licensed GPLv2-only. (https://github.com/minetest-whynot/whyn ... issues/134)

Would you agree to using GPLv2-or-later instead? That way it would allow us to use GPLv3.
I'm okay with doing this, but I'll need to dig up my Github account user/password to apply the change. Haven't used it in quite some time.
What is SCP-055?

Chem871
Member
Posts: 999
Joined: Sat Aug 19, 2017 21:49
GitHub: Chemguy99
In-game: Chem Nyx
Location: My Basement's Attic

Re: Armor Addon (WIP)

by Chem871 » Post

BOOM, license updated.
What is SCP-055?

Duvalon
Member
Posts: 43
Joined: Thu Jun 18, 2020 00:32
Location: Canada

Re: Armor Addon (WIP)

by Duvalon » Post

Wow! Thanks for the quick reply.

Post Reply

Who is online

Users browsing this forum: Google [Bot] and 22 guests