[Mod] Trainblocks [0.4] [trainblocks]

Post Reply
User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

[Mod] Trainblocks [0.4] [trainblocks]

by maxx » Post

This mod adds simple signs for the advanced trains mod by orwell. In general it is like the subwayblocks mod by gpcf but there are some new signs.

Image

Download as .zip:
Download

Browse the Code:
Code

History:
2018-03-04 version 0.1 release
2018-03-05 version 0.2 better node registrations and craft receipes | changed textures
2018-03-06 version 0.21 alias added
2018-03-07 version 0.3 alias removed in trainblocks and added new signs. => trainblocks_bc for backwards compatibility
2018-09-24 version 0.4 code cleaned up; added new signs/blocks; textures uptdated; crafting recipes deleted
Last edited by maxx on Wed Dec 12, 2018 17:37, edited 36 times in total.
Stay safe! | Don't forget the planet

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

Please write down all your wishes here so I maybe can include them into the mod.
Ihr könnt natürlich eure Wünsche auch in deutscher Sprache äußern.
Stay safe! | Don't forget the planet

gpcf
Member
Posts: 382
Joined: Fri May 27, 2016 10:48
GitHub: gpcf
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Post

Hi max!

I see you like my advtrains_subwayblocks mod so much that you've decided to improve it. However, your mod is a clear violation of my copyrights since you copied the pictures without crediting me. Also, your licensing under LGPL is also a violation, since my mod didn't have any license before (that means, it was proprietary, because I was too lazy to add a license) and it is now under AGPL.

I would like you to properly credit me and to change the license to something compatible with AGPL.

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

Thanks for your answer. The mod isn’t ready yet as you can see. Of course I will change the license file and add some copyright information.
But it is my first mod which I added to the forum so I am not perfect now.

Today I have found a bug in the code because of the signs and there will be many more signs like train sings in general.


And the mod is only inspired by your mod which is on the Linuxworks server (I haven’t seen your mod anywhere else) so I created the graphics and most of the code myself with the subway as the model.
Last edited by maxx on Wed Mar 07, 2018 06:25, edited 1 time in total.
Stay safe! | Don't forget the planet

gpcf
Member
Posts: 382
Joined: Fri May 27, 2016 10:48
GitHub: gpcf
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Post

"License for Textures, Models and Sounds
---------------------------------------

CC-BY-SA 3.0 UNPORTED. Created by maxx"

You were very clearly trying to pass them off as your own.

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

At first I didn’t understand the License but I will change it the next days. Also I have removed the link as you can see
Stay safe! | Don't forget the planet

gpcf
Member
Posts: 382
Joined: Fri May 27, 2016 10:48
GitHub: gpcf
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Post

The textures of the line numbers, except for line 2, are absolutely identical, btw.

Upper row: yours,
Lower row: mine.

Image
Attachments
screenshot_20180304_230610.png
screenshot_20180304_230610.png (168.49 KiB) Viewed 1922 times

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

That’s because I tried to make it like the signs on the subways by orwell but YES I will add you to the license
Stay safe! | Don't forget the planet

gpcf
Member
Posts: 382
Joined: Fri May 27, 2016 10:48
GitHub: gpcf
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Post

I'd hardly call a pixel-by-pixel copy "inspired". Please make it clear that this is a modified version of my mod, and I'll gladly use this mod on Linuxworks server, since it adds a couple of nice new blocks!

Btw, my textures are under AGPL v3.

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

Yes I’ll do so.
Thanks for your help and support!!!
Stay safe! | Don't forget the planet

gpcf
Member
Posts: 382
Joined: Fri May 27, 2016 10:48
GitHub: gpcf
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Post

May I ask you for another favor?
Can you please change the node names so they directly supersede the ones of subwayblocks, so this mod is backwards-compatible with subwayblocks, as a drop-in replacement?

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Post

Yes I will do so (but not today because it is too late now). And I have some other ideas as well which will be included the next days or weeks.
One other question: Which other mods did you use, when you tried out my mod?
Stay safe! | Don't forget the planet

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.2] [trainblocks]

by maxx » Post

I have downloaded your subways mod but your license file is wrong because you forgot to write in your name

Code: Select all

<one line to give the program's name and a brief idea of what it does.>
    Copyright (C) <year>  <name of author>
like you can see here.
I have added you to my license file.

And can I please have LGPL as License?
Stay safe! | Don't forget the planet

LuLa
New member
Posts: 8
Joined: Thu Nov 17, 2016 19:54
GitHub: Tresonic
In-game: Tresonic[LuLa]
Location: Germany

Re: [Mod] Trainblocks [0.2] [trainblocks]

by LuLa » Post

Hey,
I think the compatibility could also be maintained with minetest.register_alias like this:

Code: Select all

for count = 1, 10, 1 do 
	minetest.register_alias("advtrains_subwayblocks:" .. count, "trainblocks:line" .. count)
end

minetest.register_alias("advtrains_subwayblocks:germany", "trainblocks:subwayblock")
Please correct me if I'm wrong!
Very nice mod btw.
Lu
Wieso einfach, wenn's auch kompliziert geht?

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.2] [trainblocks]

by maxx » Post

Trainblocks is now fully backwards-compatible to advtrains_subwayblocks!


old:
screenshot_20180308_160621.png
screenshot_20180308_160621.png (419.98 KiB) Viewed 1922 times
new:
screenshot_20180308_160940.png
screenshot_20180308_160940.png (552.89 KiB) Viewed 1922 times
Download trainblocks_bc for backwards-compatibility to advtrains_subwayblocks!
Stay safe! | Don't forget the planet

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.3] [trainblocks]

by maxx » Post

In a few days there will still be one version online (_bc as "normal" version). So please download trainblocks_bc up from now!

AND: new signs are waiting for you
e.g. emergency exit signs, new sbahn signs and traditional stuff
Stay safe! | Don't forget the planet

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.4] [trainblocks]

by maxx » Post

New version available!
(Better late than never ;-))

screenshot.png
screenshot.png (350.6 KiB) Viewed 1922 times
Stay safe! | Don't forget the planet

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.4] [trainblocks]

by maxx » Post

Currently I am working on these tiles just like those in the subwaystation "Marienplatz" in Munich:

Image
Attachments
screenshot_20181213_212753.png
screenshot_20181213_212753.png (77.25 KiB) Viewed 1922 times
Stay safe! | Don't forget the planet

User avatar
Phoenixflo44
Member
Posts: 639
Joined: Fri Jul 28, 2017 15:01
In-game: EvilPhoenix
Location: Behind my PC, in Germany

Re: [Mod] Trainblocks [0.4] [trainblocks]

by Phoenixflo44 » Post

ich hätte einen wunsch: Das du vielleicht noch ein paar schilder erstellst auf die man z. B. eine haltestation schreiben kann.
Spoiler
I hate my life

User avatar
maxx
Member
Posts: 44
Joined: Thu Feb 15, 2018 15:24
GitHub: maxhipp
In-game: maxx or max
Location: Germany | Bavaria

Re: [Mod] Trainblocks [0.4] [trainblocks]

by maxx » Post

Phoenixflo44 wrote:ich hätte einen wunsch: Das du vielleicht noch ein paar schilder erstellst auf die man z. B. eine haltestation schreiben kann.
Das hatte ich auch überlegt. Aktuell verwende ich den Display Modpack von Pyrollo.
Außerdem hab ich aktuell sonst auch noch sehr viel zu tun, aber ich werde mich bald mal damit beschäftigen...
Stay safe! | Don't forget the planet

Emojiminetest
Member
Posts: 38
Joined: Sat Jun 06, 2020 00:21
GitHub: Emojigit

Re: [Mod] Trainblocks [0.4] [trainblocks]

by Emojiminetest » Post

The original mod is dead. Here is an alternative, forked from LinuxForks mod collection: https://github.com/C-C-Minetest-Server/trainblocks

User avatar
Blockhead
Member
Posts: 1622
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
IRC: Blockhead256
In-game: Blockhead Blockhead256
Location: Land Down Under
Contact:

Re: [Mod] Trainblocks [0.4] [trainblocks]

by Blockhead » Post

Emojiminetest wrote:
Fri Jan 05, 2024 12:52
The original mod is dead. Here is an alternative, forked from LinuxForks mod collection: https://github.com/C-C-Minetest-Server/trainblocks
And here is my own fork. I asked gpcf to consider it on LinuxForks, but he was too busy and/or worried about regressions, including nostalgia for the missing texture on the Sbahnblock. Perhaps we should look at merging improvements from both some time?
/˳˳_˳˳]_[˳˳_˳˳]_[˳˳_˳˳\ Advtrains enthusiast | My map: Noah's Railyard | My Content on ContentDB ✝️♂

Emojiminetest
Member
Posts: 38
Joined: Sat Jun 06, 2020 00:21
GitHub: Emojigit

Re: [Mod] Trainblocks [0.4] [trainblocks]

by Emojiminetest » Post

Blockhead wrote:
Fri Jan 05, 2024 14:11
And here is my own fork. I asked gpcf to consider it on LinuxForks, but he was too busy and/or worried about regressions, including nostalgia for the missing texture on the Sbahnblock. Perhaps we should look at merging improvements from both some time?
Sure, let me see what changes have been made by you.

Emojiminetest
Member
Posts: 38
Joined: Sat Jun 06, 2020 00:21
GitHub: Emojigit

Re: [Mod] Trainblocks [0.4] [trainblocks]

by Emojiminetest » Post

I have added your changes.

Post Reply

Who is online

Users browsing this forum: No registered users and 16 guests