Page 1 of 2

[mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Thu Feb 14, 2019 10:58
by Hume2
Wooden Bucket
Hello everyone!
Image

This mod is simple. It adds a bucket made of wood. Wooden bucket can hold only water or river water, not lava. This bucket is good so you can go farming before you obtain some iron.

If you use mods ethereal or farming, the bowl recipe is changed so it won't collide.
Image

License:
code: LGPL v. 2.1
textures: CC-BY-SA 3.0

Dependencies:
default
ethereal?
farming?

Download:

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 12:25
by Sokomine
Nice! I was looking for a wooden bucket. However..it does seem to be a copy of the bucket code from MTG, with a few changes done? I'm not very satisifed with cut&paste code. Those things tend to develop apart over time and are difficult to maintain. It would be much better if the bucket code from MTG could be changed so that it allows for diffrent types of buckets. Admittedly, there're not that many buckets you might want to have, so there was probably not enough need before. But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible. Perhaps opening an issue on Github and/or offering a PR might be a good solution if you have the time to do it.

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 13:29
by Linuxdirk
Sokomine wrote:But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible.
Yes, a bucket API would be pretty awesome. Something like

Code: Select all

bucket.register('modname:bucketname', {
    material = 'modname:itemname',
    textures = { 'modname_bucketname_empty.png', 'modname_bucketname_full.png' },
    holds = { 'liquid:one', 'liquid:two', 'liquid:etc' }
})
So modders can register buckets of material that hold all of holds liquids with textures being the bucket design.

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 14:49
by wziard
the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 20:11
by Lone_Wolf
wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?
No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 22:15
by Stix
Lone_Wolf wrote:
wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?
No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots
All of you have it wrong, the recipe for a boat is as follows:

XXX
WXW
WWW

where X = nothing and W = group:wood.

If you weren't sure a quick glance at the mods init.lua file would have told you that...

Re: Wooden Bucket [wooden_bucket]

Posted: Thu Feb 14, 2019 22:37
by Lone_Wolf
Stix wrote:
Lone_Wolf wrote:
wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?
No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots
All of you have it wrong, the recipe for a boat is as follows:

XXX y slot 1
WXW y slot 2
WWW y slot 3

where X = nothing and W = group:wood.

If you weren't sure a quick glance at the mods init.lua file would have told you that...
I said they were different?

Nice mod btw Hume2. Any change you could get it on the ContentDB? https://content.minetest.net/

Re: Wooden Bucket [wooden_bucket]

Posted: Fri Feb 15, 2019 09:12
by wziard
Stix wrote: XXX
WXW
WWW

If you weren't sure a quick glance at the mods init.lua file would have told you that...
You are right of course. I was in the train on my phone :-)

But as there is no conflict with the boat after all I don't understand why Hume2 didn't just copy the recipe for a steel bucket with wood. It's confusing that it's different. Imho the recipe should be:

WXW
XWX

for a wooden bucket. Just like the steel one.

Re: Wooden Bucket [wooden_bucket]

Posted: Fri Feb 15, 2019 12:06
by Hume2
Sokomine wrote:Nice! I was looking for a wooden bucket. However..it does seem to be a copy of the bucket code from MTG, with a few changes done? I'm not very satisifed with cut&paste code. Those things tend to develop apart over time and are difficult to maintain. It would be much better if the bucket code from MTG could be changed so that it allows for diffrent types of buckets. Admittedly, there're not that many buckets you might want to have, so there was probably not enough need before. But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible. Perhaps opening an issue on Github and/or offering a PR might be a good solution if you have the time to do it.
That's a good idea. I'll look what I can do later. Until it's done, this mod can be used.
wziard wrote: But as there is no conflict with the boat after all I don't understand why Hume2 didn't just copy the recipe for a steel bucket with wood. It's confusing that it's different. Imho the recipe should be:

WXW
XWX

for a wooden bucket. Just like the steel one.
Yes, but this one collides with ethereal:bowl. Maybe ethereal:bowl could be crafted from a wooden bucket.

Re: Wooden Bucket [wooden_bucket]

Posted: Fri Feb 15, 2019 22:16
by wziard
Ah shucks. It's been ages since I used Ethereal, so I forgot.
ethereal:bowl from a bucket (and back) seems like a good idea.

Re: Wooden Bucket [wooden_bucket]

Posted: Tue Feb 19, 2019 22:16
by ThatGhzGamer
cool mod going to download :)
(I suck at mining iron in the beginning lol)

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Wed Feb 20, 2019 17:04
by Hume2
Update:
I changed the recipe and farming:bowl and ethereal:bowl are now crafted from wooden buckets.
Wooden bucket of water is no longer in the group:water_bucket to prevent obtaining iron buckets by using a wooden bucket of water in recipes.
It's now the 1.0 release.
A proper bucket API will come later (if I have time).

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Mon Feb 25, 2019 22:08
by ThorfinnS
How about using a slab for the bottom of the bucket? They are way underused anyway.

Incidentally, the buckets stack, but my stack of 6 filled buckets became 1 empty bucket when I dumped one of them.

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Tue Feb 26, 2019 08:58
by Linuxdirk
ThorfinnS wrote:Incidentally, the buckets stack, but my stack of 6 filled buckets became 1 empty bucket when I dumped one of them.
Empty buckets should stack just fine but full buckets shouldn't.

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Tue Feb 26, 2019 17:33
by ThorfinnS
Must be using an old version. I'll update and see.

[EDIT]
Nope. Just tried it and they stack just fine. In fact, they autostacked. I do have a lot of other mods installed. I'll try a new game with just buckets, but it may take a bit.
[/EDIT]

[EDIT2]
That was it. Some other mod was allowing them to stack. I'll have to try to figure out which.
[/EDIT2]

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Fri Mar 01, 2019 01:39
by ThorfinnS
As I mentioned in another thread, I'm building a server for special needs kids. Turns out slab was too much for them when I added moretrees, yet they love the new trees. Plus the clementines, lemons, etc.

So I modified the recipe in my local server to:

Code: Select all

W-W
W-W
-W-
If you would rather I deleted it from my server, please let me know.

Thanks

--Steph

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Fri Mar 01, 2019 01:58
by ThorfinnS
That was fast. Got a comment back from one of the special needs kids that there wasn't a handle.

Anyone have a problem with:
W=wood
S=Stick

Code: Select all

WSW
W W
 W
I'd be OK with:

Code: Select all

 S 
W W
 W
if that's already taken.

Thanks

--Steph

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Fri Mar 01, 2019 02:31
by ThorfinnS
My friend commented back that maybe the appropriate recipe is:

Code: Select all

SSS
W W
 W
I don't have any idea if this interferes with anything.

Thanks

--Steph

[EDIT]
FWIW, I'm going to do it anyway. It's worth it to have one of the players see his contributions become "canon".

It's just a matter of whether other want the same.
[/EDIT]

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Fri Mar 01, 2019 06:19
by Hume2
I'm glad that you test it on a server. The license allows you to do so anyway :)

This mod usually used the first recipe you wrote here but I was convinced to change it. The mod is now designed so it changes the recipe of wooden bowl so you might want to remove this behaviour as well. The other recipes you mentioned aren't occupied AFAIK.

Re: [mod] Wooden Bucket [1.0] [wooden_bucket]

Posted: Fri Mar 01, 2019 22:57
by ThorfinnS
Hume2 wrote:The mod is now designed so it changes the recipe of wooden bowl...
I saw something about it, but didn't bother to investigate. I thought the bowl was a small V out of planks. That's why I did a capital V for a bucket -- it should be bigger than a bowl. I now see you did the same thing differently -- bowls have just gone through an intermediate bucket state.

Re: [mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Wed Mar 06, 2019 15:22
by Hume2
I renamed the mod because the name "wooden_bucket" is already taken by viewtopic.php?t=16472. It's the only change in the 1.0.1 release.

Re: [mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Sun Mar 15, 2020 02:53
by minerman
Hello hume2,
xdecor's wooden bowl recipe conflicted with this mod. I ended up going nuclear option by deleting the xdecor's bowl recipe. Is there another workaround? thanks!

Re: [mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Sun Mar 15, 2020 07:09
by pampogokiraly
minerman wrote:Hello hume2,
xdecor's wooden bowl recipe conflicted with this mod. I ended up going nuclear option by deleting the xdecor's bowl recipe. Is there another workaround? thanks!
In my mod i actualy changed the wooden bucket recipe to this:

Code: Select all

plank, nothing, plank
plank, nothing, plank
nothing, plank, nothing
This will never going to conflict with any bowl mod

Re: [mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Sun Mar 15, 2020 14:36
by minerman
pampogokiraly wrote:
minerman wrote:Hello hume2,
xdecor's wooden bowl recipe conflicted with this mod. I ended up going nuclear option by deleting the xdecor's bowl recipe. Is there another workaround? thanks!
In my mod i actualy changed the wooden bucket recipe to this:

Code: Select all

plank, nothing, plank
plank, nothing, plank
nothing, plank, nothing
This will never going to conflict with any bowl mod
Which mod, this mod or xdecor one?

Re: [mod] Wooden Bucket [1.0.1] [bucket_wooden]

Posted: Sun Mar 15, 2020 15:40
by pampogokiraly
Every mod that have some bowl have the same recipe:

Code: Select all

plank, nothing, plank
nothing, plank, nothing
so you better change the BUCKET to this:

Code: Select all

plank, nothing, plank
plank, nothing, plank
nothing, plank, nothing