Beautiful music. This deserves an applause!
However,
Can you add custom songs to it? Like can we add .ogg files and have it play custom songs along with the music it already has? If not, there's an idea. May I suggest a disc for the regular music (already implemented) and a different colored disc (could be blue) for the custom songs? Also you could have a custom songs folder like so:
mods/jukebox/sounds/default/jukebox_song.1.ogg
then
mods/jukebox/sounds/custom/customsong01.ogg
OR if that doesnt work:
mods/jukebox/sounds/jukebox_song.1.ogg
mods/jukebox/sounds/customsong01.ogg
mods/jukebox/sounds/customsong02.ogg
mods/jukebox/sounds/customsong03.ogg
and so on...
Im not entirely good at writing lua, but I can read it. After looking at the init.lua file, I'm guessing
Code: Select all
minetest.sound_play("jukebox_song",
this is where it plays the song file. So maybe you could probably make it IF there is any custom songs in a custom song folder, THEN it can play those on a seperate disc, ELSE it gives a message saying the disc is empty or blank. Of course it will need the custom disc to play custom music.
If we already can put music into it, then you could also give a quick tutorial, like a 3-4 step tutorial (if we need to set it up manually).
If not, and you decide to implement this into it, then we still might possibly need a quick tutorial.
Just a simple example,
1. Create a custom folder inside sounds folder
2. Put the .ogg files into the custom folder
3. Rename the file to Custom##.ogg starting with 01
But of course you will have to make it play in order and not random.
Finally my last idea for this idea is that you could have a simple gui (which might be laggy from what my research tells me) or a keybinding (1,2,3,4....) that only comes into play when you right click with jukebox. Of course there are pros and cons with both:
GUI: More than 10 songs, but laggy
Keybinding: less laggy, but only a max of 10 songs
I repeat, its merely an idea and its still your choice. If you do like my idea, I'm glad that I could be of some help.
Other than that, really love your mod.