Fix lag when lavacooling sets lots of nodes
- Hybrid Dog
- Member
- Posts: 2834
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Fix lag when lavacooling sets lots of nodes
I edited the lavacooling function that it uses vmanip if many nodes become cooled:
https://github.com/HybridDog/minetest_g ... s.lua#L146
This greatly decreases server lag when e.g. someone makes a lavacooling mountain.
Sometimes I can see such a mountain created with lavacooling on a server, often it's made by me but not every time.
I have much more pictures, tell me if you want to see them, some of the mountains are much bigger.
https://github.com/HybridDog/lavacoolin ... 9b5ee1fe9e
I changed the code of my lavacooling mod that creating such a mountain with a lava and water bucket (or something else with lava and water) doesn't cause a server lag that it needs to become shut down because it's fairly impossible to continue playing there without disabling lavacooling (except on fast computers).
After that l changed the lavacooling of default in my version of minetest_game. Calinou's carbone game uses the code.
https://github.com/HybridDog/minetest_g ... s.lua#L146
This greatly decreases server lag when e.g. someone makes a lavacooling mountain.
Sometimes I can see such a mountain created with lavacooling on a server, often it's made by me but not every time.
I have much more pictures, tell me if you want to see them, some of the mountains are much bigger.
https://github.com/HybridDog/lavacoolin ... 9b5ee1fe9e
I changed the code of my lavacooling mod that creating such a mountain with a lava and water bucket (or something else with lava and water) doesn't cause a server lag that it needs to become shut down because it's fairly impossible to continue playing there without disabling lavacooling (except on fast computers).
After that l changed the lavacooling of default in my version of minetest_game. Calinou's carbone game uses the code.
- Attachments
-
- somewhere1.png (236.04 KiB) Viewed 692 times
-
- jeijamap_1.png (152.24 KiB) Viewed 693 times
Last edited by Hybrid Dog on Sat Sep 10, 2016 12:13, edited 4 times in total.
- Krock
- Developer
- Posts: 4650
- Joined: Thu Oct 03, 2013 07:48
- GitHub: SmallJoker
- Location: Switzerland
- Contact:
Re: reduce the lag of creating lavacooling mountains
Lava-water-stone mountains on no-rule-servers: HAHA! trololo system ressources :PP !!111!11!!1!1
Lava-water-stone mountains on serious servers: No- please not.
A speedup can be produced with faster water flowing and maybe using voxelmanip for it.
Lava-water-stone mountains on serious servers: No- please not.
A speedup can be produced with faster water flowing and maybe using voxelmanip for it.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>
- HeroOfTheWinds
- Member
- Posts: 470
- Joined: Wed Apr 23, 2014 23:16
- GitHub: HeroOfTheWinds
- IRC: WindHero
- Location: Hawaii
Re: reduce the lag of creating lavacooling mountains
I'm not sure if it's just my terrible internet, but it always seems to me that lava creates tremendous lag whenever I'm near it. Anything to lessen this is appreciated.
Nam ex spatio, omnes res venire possunt.
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
- Hybrid Dog
- Member
- Posts: 2834
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: reduce the lag of creating lavacooling mountains
I thought the vote was made for this... maybe I understood something wrongKrock wrote:...and maybe using voxelmanip for it.
Does the server use special mods?HeroOfTheWinds wrote:I'm not sure if it's just my terrible internet, but it always seems to me that lava creates tremendous lag whenever I'm near it. Anything to lessen this is appreciated.
- paramat
- Developer
- Posts: 3700
- Joined: Sun Oct 28, 2012 00:05
- GitHub: paramat
- IRC: paramat
- Location: UK
Re: reduce the lag of creating lavacooling mountains
When i added lavacooling to watershed, i noticed that default mod lavacooling has an interval of 1 and a chance of 1. So every second, every lava node has all it's neighbours checked for water nodes, this results in instant and fast lavacooling, but also large processing spikes, the interval and chance should be changed to avoid this, for slower and more gradual cooling.
- HeroOfTheWinds
- Member
- Posts: 470
- Joined: Wed Apr 23, 2014 23:16
- GitHub: HeroOfTheWinds
- IRC: WindHero
- Location: Hawaii
Re: reduce the lag of creating lavacooling mountains
The only one that I can think of that would affect that is the mod (can't remember the name) that causes particles to fly up from the lava, as well as add a flowing water sound when water is near.Hybrid Dog wrote:Does the server use special mods?HeroOfTheWinds wrote:I'm not sure if it's just my terrible internet, but it always seems to me that lava creates tremendous lag whenever I'm near it. Anything to lessen this is appreciated.
Nam ex spatio, omnes res venire possunt.
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
-
- Member
- Posts: 4534
- Joined: Mon Oct 03, 2011 17:58
- GitHub: Jordach
- IRC: Jordach
- In-game: Jordach
- Location: Blender Scene
Re: reduce the lag of creating lavacooling mountains
Will take a look into it via BFD, have a feeling it's the internet side and not server: in BFD I have seen any lag with lavacooling, due to being 64bit. And playing locally.
- Hybrid Dog
- Member
- Posts: 2834
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: reduce the lag of creating lavacooling mountains
maybe it's the old particles modHeroOfTheWinds wrote:The only one that I can think of that would affect that is the mod (can't remember the name) that causes particles to fly up from the lava, as well as add a flowing water sound when water is near.Hybrid Dog wrote:Does the server use special mods?HeroOfTheWinds wrote:I'm not sure if it's just my terrible internet, but it always seems to me that lava creates tremendous lag whenever I'm near it. Anything to lessen this is appreciated.
- HeroOfTheWinds
- Member
- Posts: 470
- Joined: Wed Apr 23, 2014 23:16
- GitHub: HeroOfTheWinds
- IRC: WindHero
- Location: Hawaii
Re: reduce the lag of creating lavacooling mountains
I looked up the mods on the server. The mod in question is [dplus].Hybrid Dog wrote: maybe it's the old particles mod
Nam ex spatio, omnes res venire possunt.
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
Why let the ground limit you when you can reach for the sky?
Back to college now, yay for sophomore year schedules. :P
- Hybrid Dog
- Member
- Posts: 2834
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: reduce the lag of creating lavacooling mountains
https://github.com/HybridDog/minetest_g ... d43fbed3e3
I need to change the "[lavacooling]" message and use minetest.log.
I need to change the "[lavacooling]" message and use minetest.log.
- Calinou
- Moderator
- Posts: 3169
- Joined: Mon Aug 01, 2011 14:26
- GitHub: Calinou
- IRC: Calinou
- In-game: Calinou
- Location: Troyes, France
- Contact:
Re: reduce the lag of creating lavacooling mountains
Carbone implemented the lava cooling changes (which also seems to prevent sound spam), thank you. It also logs it.
- Hybrid Dog
- Member
- Posts: 2834
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: reduce the lag of creating lavacooling mountains
I don't know if you changed it at carbone yet, I fixed the liquid flow update:Calinou wrote:Carbone implemented the lava cooling changes (which also seems to prevent sound spam), thank you. It also logs it.
https://github.com/HybridDog/minetest_g ... 408e43R232
- Krock
- Developer
- Posts: 4650
- Joined: Thu Oct 03, 2013 07:48
- GitHub: SmallJoker
- Location: Switzerland
- Contact:
Re: reduce the lag of creating lavacooling mountains
Thanks.Hybrid Dog wrote:I don't know if you changed it at carbone yet, I fixed the liquid flow update:
https://github.com/HybridDog/minetest_g ... 408e43R232
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>
-
- Member
- Posts: 1233
- Joined: Tue Oct 23, 2012 12:59
- GitHub: Dragonop
- IRC: Dragonop
- In-game: Dragonop
- Location: Argentina
Re: reduce the lag of creating lavacooling mountains
Why the colors in the pictures look so bright?
- Krock
- Developer
- Posts: 4650
- Joined: Thu Oct 03, 2013 07:48
- GitHub: SmallJoker
- Location: Switzerland
- Contact:
Re: reduce the lag of creating lavacooling mountains
You can take screenshots at night and make them brighter. It's not fully dark at night, that's why it's possible.Dragonop wrote:Why the colors in the pictures look so bright?
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>
Who is online
Users browsing this forum: No registered users and 6 guests