[This forum] Bug in forum theme

Post Reply
User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

[This forum] Bug in forum theme

by Linuxdirk » Post

Hey there.

There is a bug in the forums theme. When displaying a thread the div with the ID “wrap” gets cut off by a </div> from somewhere causing all further posts on this page of the thread not being aligned properly because not being in the “wrap” div anymore.

Since there are too many errors when using the W3C validator check with Firefox Inspector (Right click, Q). All posts up to the post from the ignored member are within the “wrap” div. All posts after this post aren’t.

See screenshots (zoomed out for showing the highlighted parts properly).

Image Image

Kind regards,
Dirk

User avatar
Krock
Developer
Posts: 4649
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [This forum] Bug in forum theme

by Krock » Post

Also my mod indexer finds about 20 syntax/code errors.
Luckily, I do not have any problems with the correct display on Chromium.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
addi
Member
Posts: 666
Joined: Thu Sep 20, 2012 03:16
GitHub: adrido
Location: Black-Forest, Germany

Re: [This forum] Bug in forum theme

by addi » Post

I also have no problems with firefox. but im using the phpbb default design instead of that minetest design.

User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [This forum] Bug in forum theme

by Linuxdirk » Post

Krock wrote:I do not have any problems with the correct display on Chromium.
With Minetest theme and ignored users? When using the default theme it’s all fine. Same with not ignored users, but after the first post of a ignored user the rest of the thread display is broken.

User avatar
rubenwardy
Moderator
Posts: 6972
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: Bristol, United Kingdom
Contact:

Re: [This forum] Bug in forum theme

by rubenwardy » Post

I'd prefer a dark minetest theme, with the original stone texture as a background (not white washed), but nobody answered my question: https://github.com/minetest/forum.minet ... 1/issues/2
Renewed Tab (my browser add-on) | Donate | Mods | Minetest Modding Book

Hello profile reader

User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [This forum] Bug in forum theme

by Linuxdirk » Post

rubenwardy wrote:I'd prefer a dark minetest theme, […]
I prefer an actually working theme :D

The default theme is weird. It’s like made for RTL languages and not LTR :)

User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [This forum] Bug in forum theme

by Linuxdirk » Post

Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?

sfan5
Moderator
Posts: 4094
Joined: Wed Aug 24, 2011 09:44
GitHub: sfan5
IRC: sfan5
Location: Germany

Re: [This forum] Bug in forum theme

by sfan5 » Post

Linuxdirk wrote:Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?
IIRC, BlockMen is responsible for the forum theme.
Mods: Mesecons | WorldEdit | Nuke & Minetest builds for Windows (32-bit & 64-bit)

User avatar
celeron55
Administrator
Posts: 532
Joined: Tue Apr 19, 2011 10:10
GitHub: celeron55
IRC: celeron55

Re: [This forum] Bug in forum theme

by celeron55 » Post

The theme is here: https://github.com/minetest/forum.minet ... _template1

Post your fixes as pull requests.

User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [This forum] Bug in forum theme

by Linuxdirk » Post

celeron55 wrote:Post your fixes as pull requests.
Since I don’t know how to create phpBB themes I don’t know which files to fix, sorry.

User avatar
rubenwardy
Moderator
Posts: 6972
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: Bristol, United Kingdom
Contact:

Re: [This forum] Bug in forum theme

by rubenwardy » Post

I'll fix it, or try to, as soon as I work out how to install the theme.
Renewed Tab (my browser add-on) | Donate | Mods | Minetest Modding Book

Hello profile reader

4aiman
Member
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

Re: [This forum] Bug in forum theme

by 4aiman » Post

It's marvelous and spectacular how ppl tend to ignore complaints made by some members and respond with eagerness to the similar ones made by other members.

This "theme" issue was reported by me long ago (somewhat around the 15th of October, 2014).
No one seemed to had encountered that one at the time.
But it was confirmed by other ppl in early December, 2014 and subsequently it was revealed that only FF+MT-theme users were affected so far.

I find that amusing, really.

Sokomine
Member
Posts: 4276
Joined: Sun Sep 09, 2012 17:31
GitHub: Sokomine
IRC: Sokomine
In-game: Sokomine

Re: [This forum] Bug in forum theme

by Sokomine » Post

4aiman wrote: I find that amusing, really.
Might be more like a case of "Damn. Another user reported that bug again. We'll eventually have to fix it, or else they'll keep reporting" :-)
A list of my mods can be found here.

4aiman
Member
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

Re: [This forum] Bug in forum theme

by 4aiman » Post

Well, can't say that it'd be a bad case. IF the bug were fixed by now ;)

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests