[Mod] Inventory++ [github] [inventory_plus]
Re: [Mod] Inventory++ [github] [inventory_plus]
I get the same bug too, if you have more than two buttons, they start overlapping the crafting grid.
Re: [Mod] Inventory++ [github] [inventory_plus]
How come there's another file inside the first file?
What should I rename it to?
What should I rename it to?
Rainbows Rainbows! Rainbows!! Rainbows!!! Rainbows!!!! Rainbows!!!!! Rainbows!!!!!!
- Napiophelios
- Member
- Posts: 1035
- Joined: Mon Jul 07, 2014 01:14
- GitHub: Napiophelios
- IRC: Nappi
- In-game: Nappi
Re: [Mod] Inventory++ [github] [inventory_plus]
You dont really have to rename anything with this one,
just place the unzipped archive into your mod folder.
cornernote distributes his mods as modpacks,
the actual mod is the folder inside thats just named "inventory_plus".
I think mods are supposed to load better /faster when packed into modpack folders,
even if its a single mod inside.
So long as the "mod.txt" file is present,
the folder containing the "inventory_plus" folder
can be named anything.
I would place all mods that depend on inventory plus inside this folder too.
just place the unzipped archive into your mod folder.
cornernote distributes his mods as modpacks,
the actual mod is the folder inside thats just named "inventory_plus".
I think mods are supposed to load better /faster when packed into modpack folders,
even if its a single mod inside.
So long as the "mod.txt" file is present,
the folder containing the "inventory_plus" folder
can be named anything.
I would place all mods that depend on inventory plus inside this folder too.
- Wuzzy
- Member
- Posts: 4804
- Joined: Mon Sep 24, 2012 15:01
- GitHub: Wuzzy2
- IRC: Wuzzy
- In-game: Wuzzy
- Contact:
Re: [Mod] Inventory++ [github] [inventory_plus]
I have spotted a pretty serious bug in this mod. If a player joins the server, then very quickly leaves the server (faster than 1 second after joining), this will cause the server crashing. The best way to test this is locally. Important: You have to try this with a bogus (=new) username.
My analysis:
The bug is caused because in the on_joinplayer event, a minetest.after is called (1 second) and called inventory_plus.get_formspec and inventory_plus.set_formspec. If the player leaves quicker than 1 second, then inventory_plus.get_formspec will try to call a method of player, who is not on the server anymore, thus causing the crash.
My question is: Why have you put minetest.after in this function in the first place? Is there some rationale behind that?
My analysis:
The bug is caused because in the on_joinplayer event, a minetest.after is called (1 second) and called inventory_plus.get_formspec and inventory_plus.set_formspec. If the player leaves quicker than 1 second, then inventory_plus.get_formspec will try to call a method of player, who is not on the server anymore, thus causing the crash.
My question is: Why have you put minetest.after in this function in the first place? Is there some rationale behind that?
-
- Member
- Posts: 647
- Joined: Thu Feb 21, 2013 23:54
Re: [Mod] Inventory++ [github] [inventory_plus]
There are some things that don't work during an on_joinplayer callback. Using minetest.after() is the usual workaround.
- addi
- Member
- Posts: 666
- Joined: Thu Sep 20, 2012 03:16
- GitHub: adrido
- Location: Black-Forest, Germany
Re: [Mod] Inventory++ [github] [inventory_plus]
is it still required? I thought that was fixed someday?prestidigitator wrote:There are some things that don't work during an on_joinplayer callback. Using minetest.after() is the usual workaround.
Edit: yes, its not fixed.
Re: [Mod] Inventory++ [github] [inventory_plus]
Does can i change colors?
Last edited by amadin on Sat Aug 01, 2015 15:10, edited 1 time in total.
- Casimir
- Member
- Posts: 1207
- Joined: Fri Aug 03, 2012 16:59
- GitHub: CasimirKaPazi
Re: [Mod] Inventory++ [github] [inventory_plus]
I made a temporary fix for that (until it is probably done in the engine): https://github.com/Zeg9/minetest-inventory_plus/pull/4
Re: [Mod] Inventory++ [github] [inventory_plus]
The game closes out when I switch skins due to the error
. . . init.lua:158: attempt to call field 'explode_textlist_event'(a nil value). I looked on the dev wiki, and that is not even a real function, as I cannot find anything. You will have to use a different function. Maybe 'explode_table_event'?
. . . init.lua:158: attempt to call field 'explode_textlist_event'(a nil value). I looked on the dev wiki, and that is not even a real function, as I cannot find anything. You will have to use a different function. Maybe 'explode_table_event'?
hi.
- Casimir
- Member
- Posts: 1207
- Joined: Fri Aug 03, 2012 16:59
- GitHub: CasimirKaPazi
Re: [Mod] Inventory++ [github] [inventory_plus]
Must be another mod. This one only has 136 lines. Normally the error also says the mod name.
-
- New member
- Posts: 4
- Joined: Thu Nov 27, 2014 08:29
- GitHub: kino2007
- IRC: kino
- In-game: imsure1200q imsure kino2007
Re: [Mod] Inventory++ [github] [inventory_plus]
Hey, Zeg. I was thinking if you would put a "search" button so it will be easier to get stuff.
So, it's a good idea huh, isn't it?
So, it's a good idea huh, isn't it?
- Neuromancer
- Member
- Posts: 964
- Joined: Tue Jun 12, 2012 22:28
- GitHub: Neuromancer56
Re: [Mod] Inventory++ [github] [inventory_plus]
This works great now with the new "creative" inventory mod that has search. If you update your minetest game with it you should be good to go.
https://github.com/minetest/minetest_game/pull/736
https://github.com/minetest/minetest_game/pull/736
-
- Member
- Posts: 98
- Joined: Sat Nov 14, 2015 09:26
Re: [Mod] Inventory++ [github] [inventory_plus]
I renamed the folder to inventory_plus but still the debug.text shows unresolved mod name "inventory_plus"
-
- New member
- Posts: 3
- Joined: Sat Jan 23, 2016 12:16
Re: [Mod] Inventory++ [github] [inventory_plus]
Hey, Minetest's telling me that there's an error with this mod. I think is because of the name of the archive. How should call it?
P.D.: I've unpackaged the .zip archive, if anyone was going to ask
P.D.: I've unpackaged the .zip archive, if anyone was going to ask
- benrob0329
- Member
- Posts: 1341
- Joined: Thu Aug 06, 2015 22:39
- GitHub: Benrob0329
- IRC: benrob0329
- In-game: benrob03
- Location: Michigan
- Contact:
Re: [Mod] Inventory++ [github] [inventory_plus]
Rename the folder to "inventory_plus"
- mahmutelmas06
- Member
- Posts: 367
- Joined: Mon Mar 02, 2015 13:10
- GitHub: mahmutelmas06
- IRC: mahmutelmas06
- In-game: masum
Re: [Mod] Inventory++ [github] [inventory_plus]
Will be an update to work with latest version of manetest ?
Because buttons messed up in creative mode right now
Because buttons messed up in creative mode right now
- Napiophelios
- Member
- Posts: 1035
- Joined: Mon Jul 07, 2014 01:14
- GitHub: Napiophelios
- IRC: Nappi
- In-game: Nappi
Re: [Mod] Inventory++ [github] [inventory_plus]
....
Last edited by Napiophelios on Fri Sep 08, 2017 00:54, edited 2 times in total.
- mahmutelmas06
- Member
- Posts: 367
- Joined: Mon Mar 02, 2015 13:10
- GitHub: mahmutelmas06
- IRC: mahmutelmas06
- In-game: masum
Re: [Mod] Inventory++ [github] [inventory_plus]
Your file is completly what i wanted.
Thank you for sharing
Thank you for sharing
- benrob0329
- Member
- Posts: 1341
- Joined: Thu Aug 06, 2015 22:39
- GitHub: Benrob0329
- IRC: benrob0329
- In-game: benrob03
- Location: Michigan
- Contact:
Re: [Mod] Inventory++ [github] [inventory_plus]
The buttons dissapear after you swich tabs.
Otherwise It works fine, I just hope that Rubenwardy's tab API gets pushed to core.
Otherwise It works fine, I just hope that Rubenwardy's tab API gets pushed to core.
- Napiophelios
- Member
- Posts: 1035
- Joined: Mon Jul 07, 2014 01:14
- GitHub: Napiophelios
- IRC: Nappi
- In-game: Nappi
Re: [Mod] Inventory++ [github] [inventory_plus]
benrob0329 wrote:The buttons dissapear after you swich tabs.
Otherwise It works fine, I just hope that Rubenwardy's tab API gets pushed to core.
Cornernote intentionally put a delay in for showing the buttons to avoid problems.
I have tried to edit it out but it causes problems when you do.
I generally just hit the page arrow button to get them to reappear.
You will also note they dont appear on the crafting tab either.
EDIT:
I was wrong benrob0329, its not cornernote's creative mode delay making the buttons disappear
the formspec has to be set on each tab when you switch to it.
I think I can figure it out.....just not tonight :)
- BrunoMine
- Member
- Posts: 1082
- Joined: Thu Apr 25, 2013 17:29
- GitHub: BrunoMine
- Location: SP-Brasil
- Contact:
Re: [Mod] Inventory++ [github] [inventory_plus]
Apparently this project was stopped. This is bad.
Re: [Mod] Inventory++ [github] [inventory_plus]
The text only version of inventory_plus is still being worked on with newer 0.4.14 features added: https://github.com/tenplus1/inventory_plus
- Wuzzy
- Member
- Posts: 4804
- Joined: Mon Sep 24, 2012 15:01
- GitHub: Wuzzy2
- IRC: Wuzzy
- In-game: Wuzzy
- Contact:
Re: [Mod] Inventory++ [github] [inventory_plus]
--deleted--
(this post was posted in error)
(this post was posted in error)
-
- New member
- Posts: 1
- Joined: Sat Nov 21, 2020 08:37
- GitHub: smallwitch66
Re: [Mod] Inventory++ [github] [inventory_plus]
Perdón, no se si esto lo puedo preguntar aqui.
Tengo estos botones juntos
¿que puedo hacer? no puedo avanzar en el inventario
Tengo estos botones juntos
¿que puedo hacer? no puedo avanzar en el inventario
-
- Member
- Posts: 78
- Joined: Fri Sep 04, 2020 21:23
- GitHub: ignaramico
Re: [Mod] Inventory++ [github] [inventory_plus]
For starters, i believe thats sfinv not inventory++, second i believe the problem is with the version of the mod/game, one of the errors that shows in the images ("invalid list ring element") showed to me once too, but then i downloaded an earlier version of sfinv and it stopped showingsmallwitch66 wrote: ↑Sun Dec 20, 2020 11:03Perdón, no se si esto lo puedo preguntar aqui.
Tengo estos botones juntos
¿que puedo hacer? no puedo avanzar en el inventario
plus error.png
en español/spanish:
Spoiler
segun yo, ese inventario es del sfinv, no del inventory++, como quiera, ya intentaste borrar el mod y volverlo a instalar? o instalar una version anterior?, o mejor intenta usar otro mod para el inventario
Who is online
Users browsing this forum: No registered users and 36 guests