[Mod] Inventory++ [github] [inventory_plus]

User avatar
LazerRay
Member
Posts: 147
Joined: Sun Jul 27, 2014 01:32
GitHub: LazerRay

Re: [Mod] Inventory++ [github] [inventory_plus]

by LazerRay » Post

I get the same bug too, if you have more than two buttons, they start overlapping the crafting grid.

Image

RoseLite
Member
Posts: 10
Joined: Sun Nov 30, 2014 03:44
Location: Behind the Mirror

Re: [Mod] Inventory++ [github] [inventory_plus]

by RoseLite » Post

How come there's another file inside the first file?
What should I rename it to?
Rainbows Rainbows! Rainbows!! Rainbows!!! Rainbows!!!! Rainbows!!!!! Rainbows!!!!!!

User avatar
Napiophelios
Member
Posts: 1018
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Mod] Inventory++ [github] [inventory_plus]

by Napiophelios » Post

You dont really have to rename anything with this one,
just place the unzipped archive into your mod folder.

cornernote distributes his mods as modpacks,
the actual mod is the folder inside thats just named "inventory_plus".

I think mods are supposed to load better /faster when packed into modpack folders,
even if its a single mod inside.

So long as the "mod.txt" file is present,
the folder containing the "inventory_plus" folder
can be named anything.

I would place all mods that depend on inventory plus inside this folder too.

User avatar
Wuzzy
Member
Posts: 4064
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Inventory++ [github] [inventory_plus]

by Wuzzy » Post

I have spotted a pretty serious bug in this mod. If a player joins the server, then very quickly leaves the server (faster than 1 second after joining), this will cause the server crashing. The best way to test this is locally. Important: You have to try this with a bogus (=new) username.

My analysis:
The bug is caused because in the on_joinplayer event, a minetest.after is called (1 second) and called inventory_plus.get_formspec and inventory_plus.set_formspec. If the player leaves quicker than 1 second, then inventory_plus.get_formspec will try to call a method of player, who is not on the server anymore, thus causing the crash.

My question is: Why have you put minetest.after in this function in the first place? Is there some rationale behind that?

User avatar
prestidigitator
Member
Posts: 640
Joined: Thu Feb 21, 2013 23:54

Re: [Mod] Inventory++ [github] [inventory_plus]

by prestidigitator » Post

There are some things that don't work during an on_joinplayer callback. Using minetest.after() is the usual workaround.

User avatar
addi
Member
Posts: 664
Joined: Thu Sep 20, 2012 03:16
GitHub: adrido
Location: Black-Forest, Germany

Re: [Mod] Inventory++ [github] [inventory_plus]

by addi » Post

prestidigitator wrote:There are some things that don't work during an on_joinplayer callback. Using minetest.after() is the usual workaround.
is it still required? I thought that was fixed someday?
Edit: yes, its not fixed.

amadin
Member
Posts: 548
Joined: Tue Jun 16, 2015 16:23

Re: [Mod] Inventory++ [github] [inventory_plus]

by amadin » Post

Does can i change colors?
Last edited by amadin on Sat Aug 01, 2015 15:10, edited 1 time in total.

User avatar
Casimir
Member
Posts: 1173
Joined: Fri Aug 03, 2012 16:59
GitHub: CasimirKaPazi

Re: [Mod] Inventory++ [github] [inventory_plus]

by Casimir » Post

I made a temporary fix for that (until it is probably done in the engine): https://github.com/Zeg9/minetest-inventory_plus/pull/4

Blehmeh98
Member
Posts: 14
Joined: Thu Sep 17, 2015 00:17
GitHub: blehmeh98
In-game: rantor77

Re: [Mod] Inventory++ [github] [inventory_plus]

by Blehmeh98 » Post

The game closes out when I switch skins due to the error
. . . init.lua:158: attempt to call field 'explode_textlist_event'(a nil value). I looked on the dev wiki, and that is not even a real function, as I cannot find anything. You will have to use a different function. Maybe 'explode_table_event'?
hi.

User avatar
Casimir
Member
Posts: 1173
Joined: Fri Aug 03, 2012 16:59
GitHub: CasimirKaPazi

Re: [Mod] Inventory++ [github] [inventory_plus]

by Casimir » Post

Must be another mod. This one only has 136 lines. Normally the error also says the mod name.

kino2007
New member
Posts: 3
Joined: Thu Nov 27, 2014 08:29
GitHub: kino2007
IRC: kino
In-game: kingprofession

Re: [Mod] Inventory++ [github] [inventory_plus]

by kino2007 » Post

Hey, Zeg. I was thinking if you would put a "search" button so it will be easier to get stuff.

So, it's a good idea huh, isn't it?

User avatar
Neuromancer
Member
Posts: 797
Joined: Tue Jun 12, 2012 22:28
GitHub: Neuromancer56

Re: [Mod] Inventory++ [github] [inventory_plus]

by Neuromancer » Post

This works great now with the new "creative" inventory mod that has search. If you update your minetest game with it you should be good to go.
https://github.com/minetest/minetest_game/pull/736

Minetest Sam
Member
Posts: 98
Joined: Sat Nov 14, 2015 09:26

Re: [Mod] Inventory++ [github] [inventory_plus]

by Minetest Sam » Post

I renamed the folder to inventory_plus but still the debug.text shows unresolved mod name "inventory_plus"

LaraWonder
New member
Posts: 3
Joined: Sat Jan 23, 2016 12:16

Re: [Mod] Inventory++ [github] [inventory_plus]

by LaraWonder » Post

Hey, Minetest's telling me that there's an error with this mod. I think is because of the name of the archive. How should call it?
P.D.: I've unpackaged the .zip archive, if anyone was going to ask

User avatar
benrob0329
Member
Posts: 1328
Joined: Thu Aug 06, 2015 22:39
GitHub: Benrob0329
IRC: benrob0329
In-game: benrob03
Location: Michigan
Contact:

Re: [Mod] Inventory++ [github] [inventory_plus]

by benrob0329 » Post

Rename the folder to "inventory_plus"
Social: YouTube Peertube Matrix Room: #minetest:matrix.org | Games: The Infinite IKEA

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Inventory++ [github] [inventory_plus]

by mahmutelmas06 » Post

Will be an update to work with latest version of manetest ?
Because buttons messed up in creative mode right now
My Mods:

Beverage

User avatar
Napiophelios
Member
Posts: 1018
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Mod] Inventory++ [github] [inventory_plus]

by Napiophelios » Post

....
Last edited by Napiophelios on Fri Sep 08, 2017 00:54, edited 2 times in total.

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Inventory++ [github] [inventory_plus]

by mahmutelmas06 » Post

Your file is completly what i wanted.
Thank you for sharing
My Mods:

Beverage

User avatar
benrob0329
Member
Posts: 1328
Joined: Thu Aug 06, 2015 22:39
GitHub: Benrob0329
IRC: benrob0329
In-game: benrob03
Location: Michigan
Contact:

Re: [Mod] Inventory++ [github] [inventory_plus]

by benrob0329 » Post

The buttons dissapear after you swich tabs.

Otherwise It works fine, I just hope that Rubenwardy's tab API gets pushed to core.
Social: YouTube Peertube Matrix Room: #minetest:matrix.org | Games: The Infinite IKEA

User avatar
Napiophelios
Member
Posts: 1018
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Mod] Inventory++ [github] [inventory_plus]

by Napiophelios » Post

benrob0329 wrote:The buttons dissapear after you swich tabs.

Otherwise It works fine, I just hope that Rubenwardy's tab API gets pushed to core.

Cornernote intentionally put a delay in for showing the buttons to avoid problems.
I have tried to edit it out but it causes problems when you do.

I generally just hit the page arrow button to get them to reappear.
You will also note they dont appear on the crafting tab either.

EDIT:
I was wrong benrob0329, its not cornernote's creative mode delay making the buttons disappear
the formspec has to be set on each tab when you switch to it.
I think I can figure it out.....just not tonight :)

User avatar
BrunoMine
Member
Posts: 1073
Joined: Thu Apr 25, 2013 17:29
GitHub: BrunoMine
Location: SP-Brasil
Contact:

Re: [Mod] Inventory++ [github] [inventory_plus]

by BrunoMine » Post

Apparently this project was stopped. This is bad.

User avatar
TenPlus1
Member
Posts: 2866
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

Re: [Mod] Inventory++ [github] [inventory_plus]

by TenPlus1 » Post

The text only version of inventory_plus is still being worked on with newer 0.4.14 features added: https://github.com/tenplus1/inventory_plus

User avatar
Wuzzy
Member
Posts: 4064
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Inventory++ [github] [inventory_plus]

by Wuzzy » Post

--deleted--
(this post was posted in error)
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

Post Reply

Who is online

Users browsing this forum: No registered users and 6 guests