[Mod] Painting [0.8] [painting]

User avatar
Nathan.S
Member
Posts: 1003
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Painting [0.8] [painting]

by Nathan.S » Post

I'll have to make note of that on my site and the video description.
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

User avatar
Inocudom
Member
Posts: 3089
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Painting [0.8] [painting]

by Inocudom » Post

kaeza wrote:I took the liberty to update the links in the first post.

Included only xyz's fork and a fork of xyz's fork (yo dawg!) on my account.

Didn't include HybridDog's fork because I doubt its legality (he relicensed from GPLv2 to WTFPL [essentially public domain]). IANAL, so please correct me if I'm wrong.

Cheers.
Yeah heah heah heah heah, those legalities are not to be taken lightly. In fact, reality itself is run by legalities. I'm not kidding about that.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Nathan.S
Member
Posts: 1003
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Painting [0.8] [painting]

by Nathan.S » Post

Is there any chance the dark green and dark grey brushes could get craft recipes?

Code: Select all

minetest.register_craft({
output = "painting:brush_darkgreen",
recipe = {
{"dye:dark_green"},
{"default:stick"},
{"default:stick"}
}
})

minetest.register_craft({
output = "painting:brush_darkgrey",
recipe = {
{"dye:dark_grey"},
{"default:stick"},
{"default:stick"}
}
})
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

User avatar
TenPlus1
Member
Posts: 2773
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

Re: [Mod] Painting [0.8] [painting]

by TenPlus1 » Post

I've gone through the code and done a tidy while adding error checking in some areas and fixing the craft recipe's for paintbrushes... Also if you dig a painting and there's no room in your inventory it drops as an item... Lastly I've removed 64x64 craft recipe as it lags too much using these and it no longer needs vector_extras dependency as it's all built in... enjoy!
Attachments
painting(tidy).zip
(17.12 KiB) Downloaded 105 times

User avatar
Nathan.S
Member
Posts: 1003
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Painting [0.8] [painting]

by Nathan.S » Post

Nice work Tenplus1 I'll update my website to mention your version.
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

User avatar
jin_xi
Member
Posts: 165
Joined: Mon Jul 02, 2012 18:19

Re: [Mod] Painting [0.8] [painting]

by jin_xi » Post

sup, original author here to clear up some things.
- license: I originally used GPL, which was in effect when xyz made his contribution. He agreed to let me relicense to
WTFPL, so thats what it is. Idk what that means for his forks and forks thereof and I don't care, just do what the fuck you want.

- fixes: It is an old mod, so thank you for keeping it alive TenPlus1. From a quick look into your zip it does seem to me that the fix for the missing recipes is not done in a good way even if it does fix the problem. I would suggest renaming the "darkgreen" and "darkgrey" textures to "dark_green" and "dark_grey" (or gray? whatever mt dyes use) so the loop creating the recipes can work again.

- future: I would prefer if the people at minetest-mods would host the mod on their github. And i still hope that someday mods like this are properly supported by the engine.

User avatar
TenPlus1
Member
Posts: 2773
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

Re: [Mod] Painting [0.8] [painting]

by TenPlus1 » Post

Hi jin_xi, thanks for the heads up, although changing the colour names would mean current paintings wouldn't show properly and textures inside would be missing, so the quick hack it was just for the painbrush crafts :)

User avatar
Inocudom
Member
Posts: 3089
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Painting [0.8] [painting]

by Inocudom » Post

Very good! I like seeing creative mods like this one getting updates so that they can work in the current version of Minetest.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Don
Member
Posts: 1643
Joined: Sat May 17, 2014 18:40
GitHub: DonBatman
IRC: Batman
In-game: Batman

Re: [Mod] Painting [0.8] [painting]

by Don » Post

This mod is now on minetest-mods github now thanks to Tenplus1.

https://github.com/minetest-mods/painting
Many of my mods are now a part of Minetest-mods. A place where you know they are maintained!

A list of my mods can be found here

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

Re: [Mod] Painting [0.8] [painting]

by Hybrid Dog » Post

Don, l recommend you to add the history of the mod, just clone my version, remove everything except .git, put the files of Tenplus1 and commit,
cherry picking the commit instead may also work.

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
Don
Member
Posts: 1643
Joined: Sat May 17, 2014 18:40
GitHub: DonBatman
IRC: Batman
In-game: Batman

Re: [Mod] Painting [0.8] [painting]

by Don » Post

Hybrid Dog wrote:Don, l recommend you to add the history of the mod, just clone my version, remove everything except .git, put the files of Tenplus1 and commit,
cherry picking the commit instead may also work.
Tenplus1 put it on github. I will let him know.
Many of my mods are now a part of Minetest-mods. A place where you know they are maintained!

A list of my mods can be found here

User avatar
sparky
Member
Posts: 140
Joined: Sun Oct 05, 2014 00:54
GitHub: Elkien3
IRC: ircSparky
In-game: sparky
Location: USA
Contact:

Re: [Mod] Painting [0.8] [painting]

by sparky » Post

I don't know if this mod is getting developed further, but hopefully somebody can help.

Recently I copied a world to a different server, and all of the colors of existing paintings were messed up, black turned to pink, white turned to blue, etc.
I'm not sure if the colors it uses now are even the normal colors, its odd.
+ Spoiler

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

by Hybrid Dog » Post

It's fixed in my version, the mod used pairs order, which isn't consistent.
https://github.com/HybridDog/painting
The paintings need to be updated before moving the world that they don't depend on the server pc or whatsoever.

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
sparky
Member
Posts: 140
Joined: Sun Oct 05, 2014 00:54
GitHub: Elkien3
IRC: ircSparky
In-game: sparky
Location: USA
Contact:

Re:

by sparky » Post

Hybrid Dog wrote: The paintings need to be updated before moving the world that they don't depend on the server pc or whatsoever.
What do you mean, exactly? how would I go about this?

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

by Hybrid Dog » Post

https://github.com/HybridDog/painting/b ... t.lua#L498
l added a simple comment, you can get the order from the old server and then use it on the new one.

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
sparky
Member
Posts: 140
Joined: Sun Oct 05, 2014 00:54
GitHub: Elkien3
IRC: ircSparky
In-game: sparky
Location: USA
Contact:

Re: [Mod] Painting [0.8] [painting]

by sparky » Post

Undeclared global variable "vage_revcolours" accessed at [string "print("vage_revcolours = "..dump(vage_revco..."]:1
vage_revcolours = nil

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

by Hybrid Dog » Post

vage_revcolours is defined in L480.
You used my version, don't you?

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
sparky
Member
Posts: 140
Joined: Sun Oct 05, 2014 00:54
GitHub: Elkien3
IRC: ircSparky
In-game: sparky
Location: USA
Contact:

Re: [Mod] Painting [0.8] [painting]

by sparky » Post

pretty sure I used xyz's originally.

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

by Hybrid Dog » Post

xyz's version doesn't have a bugfix

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
Fixer
Member
Posts: 895
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer
Location: Ukraine

Re: [Mod] Painting [0.8] [painting]

by Fixer » Post

Please post the fixes and improvements in this repo: https://github.com/minetest-mods/painting

User avatar
apienk
Member
Posts: 26
Joined: Tue Mar 10, 2015 15:38
GitHub: apienk
In-game: apienk

Re: [Mod] Painting [0.8] [painting]

by apienk » Post

This mod has two bugs:

- red brush paints with empty texture
- easel cannot be removed by digging even when empty

User avatar
Codesound
Member
Posts: 304
Joined: Thu Jun 09, 2016 14:56

Re: [Mod] Painting [0.8] [painting]

by Codesound » Post

Linux Minti 19.02 Cinnamom, Minetest 5.1, Painting .8

Hi,
I'd like to use this mod, but doesn't appear anything in the inventory (unified inventory)....

And:

is there one way to add this painting feature to a block? (with all the "dyes" background color)

thanks

EDIT: maybe there is a similar mod that works?

User avatar
Hybrid Dog
Member
Posts: 2749
Joined: Thu Nov 01, 2012 12:46
GitHub: HybridDog

Re: [Mod] Painting [0.8] [painting]

by Hybrid Dog » Post

Codesound wrote:Linux Minti 19.02 Cinnamom, Minetest 5.1, Painting .8

Hi,
I'd like to use this mod, but doesn't appear anything in the inventory (unified inventory)....

And:

is there one way to add this painting feature to a block? (with all the "dyes" background color)

thanks

EDIT: maybe there is a similar mod that works?
My version could work: https://github.com/HybridDog/painting
I have not used it for a long time, so I do not know if there are bugs.
It depends on that mod: https://github.com/HybridDog/vector_extras.

‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪‮
‮‪

User avatar
Codesound
Member
Posts: 304
Joined: Thu Jun 09, 2016 14:56

Re: [Mod] Painting [0.8] [painting]

by Codesound » Post

Hybrid Dog wrote:
Sun Jan 12, 2020 10:29
Codesound wrote:Linux Minti 19.02 Cinnamom, Minetest 5.1, Painting .8

Hi,
I'd like to use this mod, but doesn't appear anything in the inventory (unified inventory)....

And:

is there one way to add this painting feature to a block? (with all the "dyes" background color)

thanks

EDIT: maybe there is a similar mod that works?
My version could work: https://github.com/HybridDog/painting
I have not used it for a long time, so I do not know if there are bugs.
It depends on that mod: https://github.com/HybridDog/vector_extras.
Thanks and sorry for my looooooong time response! Now I try your fork version..... thanks again!

User avatar
Codesound
Member
Posts: 304
Joined: Thu Jun 09, 2016 14:56

Re: [Mod] Painting [0.8] [painting]

by Codesound » Post

Hi,

I tried your fork Thanks:..... the only problem is that the paints is not centred... see the video for details....

https://streamable.com/7lkqox

Is possible to fix this?

Post Reply

Who is online

Users browsing this forum: Majestic-12 [Bot] and 5 guests