[Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fixes
- afflatus
- Member
- Posts: 362
- Joined: Tue Apr 01, 2014 19:47
- GitHub: 0-afflatus
- IRC: afflatus
- In-game: afflatus
- Location: Avalonia
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
That works :-)
Grailtest is stirring ...
- afflatus
- Member
- Posts: 362
- Joined: Tue Apr 01, 2014 19:47
- GitHub: 0-afflatus
- IRC: afflatus
- In-game: afflatus
- Location: Avalonia
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
This mod doesn't seem to respect shout priv, which means I can't gag verbally abusive players. Has anyone else experienced this?
Grailtest is stirring ...
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.
Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4
Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4
- afflatus
- Member
- Posts: 362
- Joined: Tue Apr 01, 2014 19:47
- GitHub: 0-afflatus
- IRC: afflatus
- In-game: afflatus
- Location: Avalonia
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
It does indeed. Thank you :)rubenwardy wrote:Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.
Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4
Grailtest is stirring ...
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
EDIT: Never mind
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Please add few simple optional antispam filters to public chat (and mail?):
+ block same message spam by player
+ truncate or block very large messages
+ block messages with https:// or ftp:// or www.
+ block same message spam by player
+ truncate or block very large messages
+ block messages with https:// or ftp:// or www.
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
1) Good suggestion, is in my (mental) to do list
2) This is potentially problematic - what if they write a long rant, and have it deleted?
3) This is also problematic - how do you detect web links reliably?
2) This is potentially problematic - what if they write a long rant, and have it deleted?
3) This is also problematic - how do you detect web links reliably?
- mahmutelmas06
- Member
- Posts: 367
- Joined: Mon Mar 02, 2015 13:10
- GitHub: mahmutelmas06
- IRC: mahmutelmas06
- In-game: masum
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Is it possible to see only chat messages left of the bottom instead of top ?
It would be easier to read.
It would be easier to read.
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
>2) This is potentially problematic - what if they write a long rant, and have it deleted?
add sane defaults (amount of symbols before truncation) and make it disabable if you are worrying, I've seen some huge spam messages that cover my entire 1280*1024 screen which slowed down minetest to few fps on descent PC.
>3) This is also problematic - how do you detect web links reliably?
Number 3 is not a big deal, 1) and 2) is a big deal, worst kinds of spam
add sane defaults (amount of symbols before truncation) and make it disabable if you are worrying, I've seen some huge spam messages that cover my entire 1280*1024 screen which slowed down minetest to few fps on descent PC.
>3) This is also problematic - how do you detect web links reliably?
Number 3 is not a big deal, 1) and 2) is a big deal, worst kinds of spam
- fireglow
- Member
- Posts: 93
- Joined: Fri Mar 28, 2014 11:36
- IRC: fireglow
- In-game: fireglow
- Location: Germany
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.
Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a
Other players can see the messages, but not the player with the dev client.
Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a
- ExeterDad
- Member
- Posts: 1717
- Joined: Sun Jun 01, 2014 20:00
- In-game: ExeterDad
- Location: New Hampshire U.S.A
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
I'm seeing this as well. Newer dev clients no longer have chat prediction visible. I thought about overcoming this on mine by sending a copy of sent chat to sender, but then older clients with chat prediction would see double posts.fireglow wrote:Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.
Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a
HOMETOWN -Our little server. Keep the HOMETOWN chatter @ http://hometownserver.com - Our server map: http://media.hometownserver.com
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
- ExeterDad
- Member
- Posts: 1717
- Joined: Sun Jun 01, 2014 20:00
- In-game: ExeterDad
- Location: New Hampshire U.S.A
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Nice! And only two lines added? Is it wrong that I hate how easy you make things look? :Prubenwardy wrote:https://github.com/rubenwardy/chatplus/ ... ed872d2a85
HOMETOWN -Our little server. Keep the HOMETOWN chatter @ http://hometownserver.com - Our server map: http://media.hometownserver.com
- fireglow
- Member
- Posts: 93
- Joined: Fri Mar 28, 2014 11:36
- IRC: fireglow
- In-game: fireglow
- Location: Germany
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Not quite, I'm afraid:
Server: 0.4.15-7b74f04a
Client: 0.4.15-c05dfac
Code: Select all
ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_chat_message(): /srv/minetest/world3/worldmods/chatplus/api.lua:223: attempt to call field 'chat_send_place' (a nil value)
stack traceback:
/srv/minetest/world3/worldmods/chatplus/api.lua:223: in function 'send'
/srv/minetest/world3/worldmods/chatplus/api.lua:232: in function </srv/minetest/world3/worldmods/chatplus/api.lua:231>
...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:412: in function <...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:392>
Client: 0.4.15-c05dfac
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
- fireglow
- Member
- Posts: 93
- Joined: Fri Mar 28, 2014 11:36
- IRC: fireglow
- In-game: fireglow
- Location: Germany
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Perfect, thank you very much!
- fireglow
- Member
- Posts: 93
- Joined: Fri Mar 28, 2014 11:36
- IRC: fireglow
- In-game: fireglow
- Location: Germany
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
Afaik there's no way of detecting whether a client will print the chat message before sending it, so yes: I can only support one or the other :(fireglow wrote:I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix
I will no longer be supporting chatplus. It doesn't do what it does very well, and just causes headaches.
I suggest using these mods instead:
I suggest using these mods instead:
- Ignore list manager - viewtopic.php?t=13993
- Filter or Chat Anticurse
Who is online
Users browsing this forum: No registered users and 6 guests