[modpack] Ambiance Sounds [ambianceplus][wip]
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
Did you see my last post? Andrey01 has the exact same issue and I think this should solve it, but I didn't push it to the repo
- texmex
- Member
- Posts: 1753
- Joined: Mon Jul 11, 2016 21:08
- GitHub: tacotexmex
- In-game: tacotexmex
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
Oh, sorry. I assumed it was another problem that was fixed already. Will try.
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
I never could reproduce this error so I don't know what causes the error or if this fixes the problem and I never get feedback if this patch really fixes the issue.
- christoferlevich
- Member
- Posts: 325
- Joined: Thu Dec 01, 2016 23:44
- GitHub: ChristoferL
- Location: Athol, Massachusetts
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
Street sounds would be awesome too
everything can be a learning experience...
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
I don't want to continue this mod right now because it makes more sense to do this client side. So I'll wait until CSM is more stable. Or maybe someone else will do a CSM ambiance mod
- christoferlevich
- Member
- Posts: 325
- Joined: Thu Dec 01, 2016 23:44
- GitHub: ChristoferL
- Location: Athol, Massachusetts
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
I am not sure what CSM (Client Service Management?) is - but I'll add the street sounds and share them (if I can figure out how (to share them). I really am a work in progress. I am learning a lot by messing with other peoples mods.burli wrote:I don't want to continue this mod right now because it makes more sense to do this client side. So I'll wait until CSM is more stable. Or maybe someone else will do a CSM ambiance mod
everything can be a learning experience...
- Glory!
- Member
- Posts: 92
- Joined: Thu Apr 30, 2015 17:45
- GitHub: Glory7000
- In-game: Glory7000
- Location: Kernel Debugging Land <3
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
CSM: Client Side Mod.
The mod is on the client, not server.
The only real advantage I see for AmbiancePlus as a CSM is that you don't have to download dozens of MB every time you connect to multiplayer; and you won't have to rely on the server itself. (Most servers probably don't use this due to the sheer amount of data.)
The mod is on the client, not server.
The only real advantage I see for AmbiancePlus as a CSM is that you don't have to download dozens of MB every time you connect to multiplayer; and you won't have to rely on the server itself. (Most servers probably don't use this due to the sheer amount of data.)
Behold the Razgriz, its wings of black sheath. :: My skin A competitor that unfortunately needs attention to stay afloat.
- christoferlevich
- Member
- Posts: 325
- Joined: Thu Dec 01, 2016 23:44
- GitHub: ChristoferL
- Location: Athol, Massachusetts
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
I was running it all last week in a local network with 25 pc's without too much trouble, but the environment is ideal, the hardware new, and I am guessing 25 clients isn't that many. With that said, would the client then be able to customize their audio - and that could be a great thing (thinking like - GTA Radios - lol). I guess CSM is better overall!
everything can be a learning experience...
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
I suggest you croaking frogs. Sound of lakes or bays with vegetation.
https://www.youtube.com/watch?v=U4PM77qBT7I
https://www.youtube.com/watch?v=fuKqMW3f0og
https://www.youtube.com/watch?v=QdErTICM0bY
https://www.youtube.com/watch?v=U4PM77qBT7I
https://www.youtube.com/watch?v=fuKqMW3f0og
https://www.youtube.com/watch?v=QdErTICM0bY
Last edited by Sergey on Wed May 24, 2017 10:04, edited 1 time in total.
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
These videos are under "Standard YouTube Licence" which means that without uploader / video owner permission you cannot use them.Sergey wrote:I suggest you singing frogs. Sound of lakes or bays with vegetation.
https://www.youtube.com/watch?v=U4PM77qBT7I
https://www.youtube.com/watch?v=fuKqMW3f0og
https://www.youtube.com/watch?v=QdErTICM0bY
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
1) These videos are examples of what may be done.xeranas wrote:These videos are under "Standard YouTube Licence" which means that without uploader / video owner permission you cannot use them.Sergey wrote:I suggest you singing frogs. Sound of lakes or bays with vegetation.
https://www.youtube.com/watch?v=U4PM77qBT7I
https://www.youtube.com/watch?v=fuKqMW3f0og
https://www.youtube.com/watch?v=QdErTICM0bY
2) Croaking of frogs is copyrighted? WTF! What's wrong with the f*cking world we live in!
- azekill_DIABLO
- Member
- Posts: 7507
- Joined: Wed Oct 29, 2014 20:05
- GitHub: azekillDIABLO
- In-game: azekill_DIABLO
- Location: OMICRON
- Contact:
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
author rights is problematic sometimes. if only we were communist.
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!
DMs are always open if you want to get in touch!
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
The longer I live the more I understand that the best country in the world was Soviet Union.
I can not describe in words how I miss USSR. F*cking bastards who ruined my country.
I can not describe in words how I miss USSR. F*cking bastards who ruined my country.
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
Got it. I just wanted pointed/reminded mod maintainer and other thread readers to be aware of content licenses. I suggest freesound org for tracks searching (most are licensed under creative commons by attribute or non-profit variations).Sergey wrote: 1) These videos are examples of what may be done.
- texmex
- Member
- Posts: 1753
- Joined: Mon Jul 11, 2016 21:08
- GitHub: tacotexmex
- In-game: tacotexmex
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
You can have it in Minetest at least. ¯\_(ツ)_/¯azekill_DIABLO wrote:author rights is problematic sometimes. if only we were communist.
- azekill_DIABLO
- Member
- Posts: 7507
- Joined: Wed Oct 29, 2014 20:05
- GitHub: azekillDIABLO
- In-game: azekill_DIABLO
- Location: OMICRON
- Contact:
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
not bad.
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!
DMs are always open if you want to get in touch!
- BrunoMine
- Member
- Posts: 1082
- Joined: Thu Apr 25, 2013 17:29
- GitHub: BrunoMine
- Location: SP-Brasil
- Contact:
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
Would you like help with development (coding)?
If so, would you rather use GitHub to discuss technical details?
If so, would you rather use GitHub to discuss technical details?
-
- Member
- Posts: 1118
- Joined: Mon Dec 29, 2014 08:07
- Location: USA
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
burli wrote:Doesn't really makes sense. There should always be a player. Maybe try this for a quick fix. Have not much time to take a closer lookAndrey01 wrote:When i installed the mod i was getting a error:Code: Select all
Lua:Runtime error from mod 'ambplus_caves' in callback LuaABM::trigger(): ...rator/.minetest/mods/ambianceplus/ambplus_caves/init.lua:21: attempt to index local 'ppos' (a nil value) stack traceback: ...rator/.minetest/mods/ambianceplus/ambplus_caves/init.lua:21: in function <. ...rator/.minetest/mods/ambianceplus/ambplus_caves/init.lua:10>
Tell me if the same error appears then in other modsCode: Select all
if ppos.y > 0 or not ppos then
Burli,
On a server, it is possible that a player does not exist if no one is logged in. Minetest would crash when my world admin account logs out of the server. Since I usually play on a private LAN server, I usually log into the world with the admin account, so that I have full control. When I log this player out, the crash occurs.
Could you give a better example of how the above fix should be implemented into the code? Each abm that you use to trigger the sounds has the same code wherein the code above has to be inserted into init.lua in multiple places, and I am unsure where I should actually add the If/Then statement. I'll gladly give feedback regarding my success/failure. And also, since this is a modpack, the fix above would need to be applied to each mod.....caves/deserts/forests, and so updating each section gets a little confusing...especially for non dev players.
Thanks in advance for your help!
Shad MOrdre
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
It might happen if you log out and after that the ABM is fired anyway.
I'm updating the mod and will insert the check. But I never had this situation so I can't test it
I'm updating the mod and will insert the check. But I never had this situation so I can't test it
-
- Member
- Posts: 129
- Joined: Tue Mar 05, 2019 17:37
- GitHub: mckaygerhard
- IRC: mckaygerhard
- In-game: mckaygerhard
Re: [modpack] Ambiance Sounds [ambianceplus][wip]
that's the problem.. this mod is quite old but works for MT 0.4 that is currently more visited rahter the very alone MT 0.5 server listShadMOrdre wrote: ↑Fri Dec 01, 2017 03:32On a server, it is possible that a player does not exist if no one is logged in. Minetest would crash when my world admin account logs out of the server. Since I usually play on a private LAN server, I usually log into the world with the admin account, so that I have full control. When I log this player out, the crash occurs.burli wrote:Andrey01 wrote:When i installed the mod i was getting a error:Code: Select all
Lua:Runtime error from mod 'ambplus_caves' in callback LuaABM::trigger(): ...rator/.minetest/mods/ambianceplus/ambplus_caves/init.lua:21: attempt to index local 'ppos' (a nil value) stack traceback:
Code: Select all
index 3568590..8eb2f8f 100644
--- a/ambplus_caves/init.lua
+++ b/ambplus_caves/init.lua
@@ -15,7 +15,11 @@ minetest.register_abm({
local ppos
for _,player in ipairs(minetest.get_connected_players()) do
- ppos = player:getpos()
+ if player ~= nil then
+ ppos = player:get_pos()
+ else
+ return
+ end
end
if ppos.y > 0 then
@@ -70,7 +74,11 @@ minetest.register_abm({
local ppos
for _,player in ipairs(minetest.get_connected_players()) do
- ppos = player:getpos()
+ if player ~= nil
+ ppos = player:getpos()
+ else
+ return
+ end
end
if ppos.y > 0 then
@@ -125,7 +133,11 @@ minetest.register_abm({
local ppos
for _,player in ipairs(minetest.get_connected_players()) do
- ppos = player:getpos()
+ if player ~= nil
+ ppos = player:getpos()
+ else
+ return
+ end
end
if ppos.y > 0 then
@@ -172,7 +184,11 @@ minetest.register_abm({
local ppos
for _,player in ipairs(minetest.get_connected_players()) do
- ppos = player:getpos()
+ if player ~= nil
+ ppos = player:getpos()
+ else
+ return
Who is online
Users browsing this forum: No registered users and 29 guests