[Mod] Bridges [bridger]

User avatar
LMD
Member
Posts: 1386
Joined: Sat Apr 08, 2017 08:16
GitHub: appgurueu
IRC: appguru[eu]
In-game: LMD
Location: Germany
Contact:

Re: [Mod] Bridges [bridger]

by LMD » Post

"Closed and open swivel bridges/drawbridges "
Mesecons compatible ?
+1 Screenshots are very appealing
My stuff: Projects - Mods - Website

User avatar
Lord_Vlad
Member
Posts: 112
Joined: Thu Jul 20, 2017 07:58

Re: [Mod] Bridges [bridger]

by Lord_Vlad » Post

Does it come with some auto-builder of some sort ? To make bridges from one point to another more easily ?

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

LMD wrote:"Closed and open swivel bridges/drawbridges "
Mesecons compatible ?
+1 Screenshots are very appealing
No, but it would be very simple. I'll do that, but it will be a while because I'm working on something else.
Lord_Vlad wrote:Does it come with some auto-builder of some sort ? To make bridges from one point to another more easily ?
That would be tricky, since there are many types of potential bridges. I could try to make one, but it wouldn't be very useful since the bridges are so complicated.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

Mikola
Member
Posts: 16
Joined: Fri Nov 24, 2017 18:01
GitHub: Mikola314
In-game: mikola

Re: [Mod] Bridges [bridger]

by Mikola » Post

Hello. When trying to place a Green Step (or any other color), an error occurs. The server stops with an error:
WARNING[Server]: Undeclared global variable "rotate_and_place" accessed at ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60
ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'bridger' in callback item_OnPlace(): ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: attempt to call global 'rotate_and_place' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: in function <...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:56>
An error appears in the minetest 0.4.16 and 5.0.0-ca502fc-win64 Windows 7 (64)
Used minetest_game and mod bridger

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

Mikola wrote:Hello. When trying to place a Green Step (or any other color), an error occurs. The server stops with an error:
WARNING[Server]: Undeclared global variable "rotate_and_place" accessed at ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60
ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'bridger' in callback item_OnPlace(): ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: attempt to call global 'rotate_and_place' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: in function <...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:56>
An error appears in the minetest 0.4.16 and 5.0.0-ca502fc-win64 Windows 7 (64)
Used minetest_game and mod bridger
This should be fixed now. It was a mistake with the rotation function being called by a node before a function was initialized. If the problem still persists with the latest version, please let me know.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

Drawbridges/swivel bridges can now be opened and shut with mesecons. The off state is shut, and the on state is open.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

Mikola
Member
Posts: 16
Joined: Fri Nov 24, 2017 18:01
GitHub: Mikola314
In-game: mikola

Re: [Mod] Bridges [bridger]

by Mikola » Post

v-rob wrote:
Mikola wrote:Hello. When trying to place a Green Step (or any other color), an error occurs. The server stops with an error:
WARNING[Server]: Undeclared global variable "rotate_and_place" accessed at ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60
ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'bridger' in callback item_OnPlace(): ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: attempt to call global 'rotate_and_place' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: ...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:60: in function <...test\minetest-0.4.16-win64\bin\..\mods\bridger/nodes.lua:56>
An error appears in the minetest 0.4.16 and 5.0.0-ca502fc-win64 Windows 7 (64)
Used minetest_game and mod bridger
This should be fixed now. It was a mistake with the rotation function being called by a node before a function was initialized. If the problem still persists with the latest version, please let me know.
Good. This problem was eliminated, but a new one was created 8) . When trying to start a server with minetest_game and mod bridger, the server does not start and gives an error:
2018-07-23 12:49:45: WARNING[Main]: Undeclared global variable "mesecon" accessed at ...netest-5.0.0-ca502fc-win64\bin\..\mods\bridger/nodes.lua:4431
2018-07-23 12:49:45: ERROR[Main]: ModError: Failed to load and run script from C:\Games\minetest\minetest-5.0.0-ca502fc-win64\bin\..\mods\bridger\init.lua:
2018-07-23 12:49:45: ERROR[Main]: ...netest-5.0.0-ca502fc-win64\bin\..\mods\bridger/nodes.lua:4431: attempt to index global 'mesecon' (a nil value)
2018-07-23 12:49:45: ERROR[Main]: stack traceback:
2018-07-23 12:49:45: ERROR[Main]: ...netest-5.0.0-ca502fc-win64\bin\..\mods\bridger/nodes.lua:4431: in main chunk
2018-07-23 12:49:45: ERROR[Main]: [C]: in function 'dofile'
2018-07-23 12:49:45: ERROR[Main]: ...inetest-5.0.0-ca502fc-win64\bin\..\mods\bridger\init.lua:15: in main chunk
Based on the text of the error, I guessed adding in depends.txt "mesecons" after recording "default" and installing the mesecons mod. The server started to run normally.

It is required to add mesecons-mod in dependence.

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

Sorry, adding the mesecons support for drawbridges caused this. Now it should work without having to have mesecons installed.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

Mikola
Member
Posts: 16
Joined: Fri Nov 24, 2017 18:01
GitHub: Mikola314
In-game: mikola

Re: [Mod] Bridges [bridger]

by Mikola » Post

v-rob wrote:Sorry, adding the mesecons support for drawbridges caused this. Now it should work without having to have mesecons installed.
Thank you. Now it works well ).

Hupfi1
Member
Posts: 33
Joined: Sat Jun 18, 2016 15:47
GitHub: Hupfi1
IRC: Hupfi1
In-game: Hupfi

Re: [Mod] Bridges [bridger]

by Hupfi1 » Post

Hello,
If I'm trying to start the mod, I got this Error:
Spoiler
2018-08-15 20:43:40: ERROR[main]: ========== ERROR FROM LUA ===========
2018-08-15 20:43:40: ERROR[main]: Failed to load and run script from
2018-08-15 20:43:40: ERROR[main]: C:\Users\user\Desktop\Programme\Minetest\minetest-0.4.13\bin\..\mods\bridger\init.lua:
2018-08-15 20:43:40: ERROR[main]: ...e\Minetest\minetest-0.4.13\bin\..\mods\bridger/nodes.lua:44: attempt to call field 'node_sound_metal_defaults' (a nil value)
2018-08-15 20:43:40: ERROR[main]: stack traceback:
2018-08-15 20:43:40: ERROR[main]: ...e\Minetest\minetest-0.4.13\bin\..\mods\bridger/nodes.lua:44: in main chunk
2018-08-15 20:43:40: ERROR[main]: [C]: in function 'dofile'
2018-08-15 20:43:40: ERROR[main]: ...me\Minetest\minetest-0.4.13\bin\..\mods\bridger\init.lua:15: in main chunk
2018-08-15 20:43:40: ERROR[main]: ======= END OF ERROR FROM LUA ========
2018-08-15 20:43:40: ERROR[main]: Server: Failed to load and run C:\Users\user\Desktop\Programme\Minetest\minetest-0.4.13\bin\..\mods\bridger\init.lua
2018-08-15 20:43:40: ERROR[main]: ModError: ModError: Failed to load and run C:\Users\user\Desktop\Programme\Minetest\minetest-0.4.13\bin\..\mods\bridger\init.lua
2018-08-15 20:43:40: ERROR[main]: Error from Lua:
2018-08-15 20:43:40: ERROR[main]: ...e\Minetest\minetest-0.4.13\bin\..\mods\bridger/nodes.lua:44: attempt to call field 'node_sound_metal_defaults' (a nil value)
2018-08-15 20:43:40: ERROR[main]: stack traceback:
2018-08-15 20:43:40: ERROR[main]: ...e\Minetest\minetest-0.4.13\bin\..\mods\bridger/nodes.lua:44: in main chunk
2018-08-15 20:43:40: ERROR[main]: [C]: in function 'dofile'
2018-08-15 20:43:40: ERROR[main]: ...me\Minetest\minetest-0.4.13\bin\..\mods\bridger\init.lua:15: in main chunk
2018-08-15 20:43:40: ERROR[main]: Siehe debug.txt für Details.
What can I do?
It would be nice, if you help me.
Thank You

User avatar
Krock
Developer
Posts: 4649
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Bridges [bridger]

by Krock » Post

Hupfi1 wrote:What can I do?
Hello. Thanks to your directory naming, I can clearly see that you're using a three (!!) year old Minetest release. Many functions have been added since then, so consider updating to 0.4.17.1 (or give 5.0.0-dev a try) in order to get this and many other mods working properly.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

Hupfi1
Member
Posts: 33
Joined: Sat Jun 18, 2016 15:47
GitHub: Hupfi1
IRC: Hupfi1
In-game: Hupfi

Re: [Mod] Bridges [bridger]

by Hupfi1 » Post

Hello Krock,
thank you for your help. Its working now.

Jat
Member
Posts: 229
Joined: Fri Nov 11, 2011 16:15

Re: [Mod] Bridges [bridger]

by Jat » Post

New PR for add mesecon in depends.
https://github.com/v-rob/bridger/pull/5

User avatar
DrFrankenstone
Member
Posts: 231
Joined: Tue May 24, 2016 05:36
GitHub: treer
Location: Australia
Contact:

Re: [Mod] Bridges [bridger]

by DrFrankenstone » Post

Would you be interesting in merging a feature that lets you enable/disable different kinds of bridges in the mod settings?

For the genre I have in mind, the wood bridges are great but the steel girder ones are out of place, so I was thinking of adding a "Small wood bridges only" setting, but thought I should run it by you - you might have other ideas about toggleable sets to split the bridger pieces into.

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

Update!
-----------

Trusses, trestles, or wooden footbridges and drawbridges can now be disabled via advanced settings.
Two new screenshots were added to the first page, one of which displays all nodes in the mod.

And for people who haven't been paying attention to the other posts, these other things were added a while ago, but I never formally announced them in an update post:

Aliases for older versions of bridger.
Support for moreblocks instead of stairs, steps, and slabs.
Mesecons support for drawbridges.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

User avatar
DrFrankenstone
Member
Posts: 231
Joined: Tue May 24, 2016 05:36
GitHub: treer
Location: Australia
Contact:

Re: [Mod] Bridges [bridger]

by DrFrankenstone » Post

v-rob wrote:Update!
-----------

Trusses, trestles, or wooden footbridges and drawbridges can now be disabled via advanced settings.
<and more>
Excellent! Thanks.

User avatar
TuxNoob
New member
Posts: 2
Joined: Fri Sep 14, 2018 20:40
Location: France

Re: [Mod] Bridges [bridger]

by TuxNoob » Post

Hi all !

This mod looks very nice, but... it doesn't work for me, too bad :(

In my unified inventory, no new item added, except wooden rod and scraffolding.
I tried to deactivate all other mods, keeping only bridger + mesecons + moreblocks. Nothing.
Settings are ok, so I don't understand.
What's wrong ?

Thank you for your help.

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

TuxNoob wrote:Hi all !

This mod looks very nice, but... it doesn't work for me, too bad :(

In my unified inventory, no new item added, except wooden rod and scraffolding.
I tried to deactivate all other mods, keeping only bridger + mesecons + moreblocks. Nothing.
Settings are ok, so I don't understand.
What's wrong ?

Thank you for your help.
As a temporary fix, go to Advanced Settings, go to mods/bridger and look at the three settings that say "Enable <bridge type>". Disable and then re-enable these, which should fix the problem.

I probably won't be able to fix this in the code right away, but it will certainly be fixed by Monday.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

User avatar
TuxNoob
New member
Posts: 2
Joined: Fri Sep 14, 2018 20:40
Location: France

Re: [Mod] Bridges [bridger]

by TuxNoob » Post

v-rob wrote:
As a temporary fix, go to Advanced Settings, go to mods/bridger and look at the three settings that say "Enable <bridge type>". Disable and then re-enable these, which should fix the problem.
Wow, that's magic ! It works !
All I have to do now is to use it.
Many thanks for such a quick answer. :)
Minetest 0.4.17.1

rgspro
Member
Posts: 99
Joined: Fri Jan 27, 2017 07:13

Re: [Mod] Bridges [bridger]

by rgspro » Post

Is there a crafting guide? I cannot seem to find it.

User avatar
LMD
Member
Posts: 1386
Joined: Sat Apr 08, 2017 08:16
GitHub: appgurueu
IRC: appguru[eu]
In-game: LMD
Location: Germany
Contact:

Re: [Mod] Bridges [bridger]

by LMD » Post

Just install an in-game one.
My stuff: Projects - Mods - Website

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

No, there isn't an included crafting guide. That was meant as a joke. Sorry for the confusion.

Anyway, I just updated the mod to fix the bug of all bridges not being enabled by default. Hopefully that doesn't happen again.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

superfloh
Member
Posts: 39
Joined: Tue Mar 09, 2021 10:14
GitHub: superfloh247

Re: [Mod] Bridges [bridger]

by superfloh » Post

Hi,

I have an enhancement request: a corner piece for the wooden beam bridge. Two handrails connected in one corner and two open sides.
screenshot_20210608_165318 Kopie.png
screenshot_20210608_165318 Kopie.png (465.4 KiB) Viewed 1107 times

superfloh
Member
Posts: 39
Joined: Tue Mar 09, 2021 10:14
GitHub: superfloh247

Re: [Mod] Bridges [bridger]

by superfloh » Post

OK that was easy :)

https://github.com/v-rob/bridger/pull/7
Bildschirmfoto 2021-06-08 um 18.24.57.png
Bildschirmfoto 2021-06-08 um 18.24.57.png (155.01 KiB) Viewed 1107 times
Bildschirmfoto 2021-06-08 um 18.28.34.png
Bildschirmfoto 2021-06-08 um 18.28.34.png (12.13 KiB) Viewed 1107 times
Bildschirmfoto 2021-06-08 um 18.34.59.png
Bildschirmfoto 2021-06-08 um 18.34.59.png (424.16 KiB) Viewed 1107 times

User avatar
v-rob
Developer
Posts: 970
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: [Mod] Bridges [bridger]

by v-rob » Post

Thanks for that. I must have forgotten all about corner pieces! I did make two changes to your PR before merging the code, namely that the craft was somewhat off, and that of making the corner right-handed, which is consistent with MTG's inner and outer stairs.

On a somewhat unrelated note, I did a bit of refactoring to at least make my old code more consistent, although there's still a lot of redundancy. I would not recommend Bridger as a good example of clean and succinct code, but if it ain't broke, don't fix it.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

Post Reply

Who is online

Users browsing this forum: No registered users and 21 guests