Crash server with sign (fix offer)

User avatar
bosapara
Member
 
Posts: 493
Joined: Fri Apr 07, 2017 08:49
GitHub: bosapara

Crash server with sign (fix offer)

by bosapara » Mon Jan 07, 2019 06:23

Server can be crashed or lagged using long text with default sign

Image

One more problem - server log still accept a lot of trash from sign

fix for games\minetest_game\mods\default\nodes.lua

Code: Select all
local code = fields.text or "";
if string.len(code) > 1000 then
meta:set_string("text", "#SIGN: your text is too long, make it less")
meta:set_string("infotext", "#SIGN: your text is too long, make it less")
minetest.log("action", (player_name or "") .. " wrote is too long text" .. minetest.pos_to_string(pos))
return false
end
 

User avatar
TumeniNodes
Member
 
Posts: 2745
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: Crash server with sign (fix offer)

by TumeniNodes » Mon Jan 07, 2019 11:32

Feature freeze has begun but, as this is a fix, try throwing it up as a PR

I did not test or anything though.
Ich mag keine grünen Eier und Schinken, ich mag sie nicht Sam I Am
 

User avatar
sorcerykid
Member
 
Posts: 1061
Joined: Fri Aug 26, 2016 15:36
Location: Illinois, USA
GitHub: sorcerykid
In-game: Nemo

Re: Crash server with sign (fix offer)

by sorcerykid » Mon Jan 07, 2019 13:05

I still they are still merging bug fixes, just not new features. And yeah, this looks to be a pretty serious issue. Def. going to patch this right away on my server.
 

sofar
Developer
 
Posts: 2037
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: Crash server with sign (fix offer)

by sofar » Mon Feb 04, 2019 07:18

Please open a github issue for this. This is serious enough and it will get fixed faster if you do. It is unlikely that the maintainers find bugreports on the forums. Especially this close to a major release.
 

sofar
Developer
 
Posts: 2037
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar
 


Return to General Discussion



Who is online

Users browsing this forum: Google [Bot] and 1 guest