LoneWolfHT's PRs

For people working on the C++ code.
Post Reply
User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

LoneWolfHT's PRs

by Lone_Wolf » Post

If you review one of my PRs I will review one of yours. If you want a specific one reviewed link it here

Completed In Progress Considering/Planned
Last edited by Lone_Wolf on Thu Jul 09, 2020 01:18, edited 7 times in total.

User avatar
sorcerykid
Member
Posts: 1313
Joined: Fri Aug 26, 2016 15:36
GitHub: sorcerykid
In-game: Nemo
Location: Illinois, USA

Re: LoneWolfHT's PRs

by sorcerykid » Post

I'm definitely looking forward to seeing more of your PRs. Glad you started a centralized topic to track them!

User avatar
Linuxdirk
Member
Posts: 2541
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: LoneWolfHT's PRs

by Linuxdirk » Post

Lone_Wolf wrote:
Fri May 01, 2020 00:35
Object Crosshair
How does this behave when there is a custom crosshair.png?

User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

Re: LoneWolfHT's PRs

by Lone_Wolf » Post

Linuxdirk wrote:
Fri May 01, 2020 02:22
Lone_Wolf wrote:
Fri May 01, 2020 00:35
Object Crosshair
How does this behave when there is a custom crosshair.png?
Updated the details in the OP (Including the old screenshot)

The object crosshair replaces the regular crosshair whenever you're pointing at an entity (or, to phrase it differently: whenever the entity's selectionbox appears). So unless there's some elite bug with my pretty simple code it should replace it with the object crosshair and return to normal once you are no longer pointing at the entity

Screenshot I'm using in the OP:
Image
(Above the green line is when not pointing at the item | Below the green line is when pointing at the item)

User avatar
sorcerykid
Member
Posts: 1313
Joined: Fri Aug 26, 2016 15:36
GitHub: sorcerykid
In-game: Nemo
Location: Illinois, USA

Re: LoneWolfHT's PRs

by sorcerykid » Post

I think the game looks so much cleaner and more modern without those dated selection boxes! Nice work :)

User avatar
Linuxdirk
Member
Posts: 2541
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: LoneWolfHT's PRs

by Linuxdirk » Post

Lone_Wolf wrote:
Fri May 01, 2020 02:57
The object crosshair replaces the regular crosshair whenever you're pointing at an entity (or, to phrase it differently: whenever the entity's selectionbox appears).
This looks like a great feature if it is completely customizable using textures! Thumbs up for that!

User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

Re: LoneWolfHT's PRs

by Lone_Wolf » Post


User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

Re: LoneWolfHT's PRs

by Lone_Wolf » Post

Made a change to the OP:
If you review one of my PRs I will review one of yours. If you want a specific one reviewed link it here

User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

Re: LoneWolfHT's PRs

by Lone_Wolf » Post

HUD Text Scaling has been merged!

User avatar
Lone_Wolf
Member
Posts: 2343
Joined: Sun Apr 09, 2017 05:50
GitHub: LoneWolfHT
IRC: Lone_Wolf or LoneWolfHT
In-game: Lone_Wolf
Location: Not there, THERE!

Re: LoneWolfHT's PRs

by Lone_Wolf » Post

New PR ready for Review! I think some of you might like this one:
Add options for nametags to not show through walls/liquids

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests