What you linked is completely different from Wuzzy's suggestion, which I agree with unlike that issue
There are too many PRs
- Lone_Wolf
- Member
- Posts: 2576
- Joined: Sun Apr 09, 2017 05:50
- GitHub: LoneWolfHT
- IRC: LandarVargan
- In-game: LandarVargan
Re: There are too many PRs
-
- Member
- Posts: 407
- Joined: Sat Dec 29, 2018 19:21
- GitHub: KaylebJay
- IRC: KaylebJay
- In-game: CalebJ
- Location: Tunnelers' Abyss
Re: There are too many PRs
Wuzzy's suggestion is brilliant. There are a *lot* of old PRs that haven't been touched in months or even years (from the author). Now, this would remove more PRs but wouldn't make other PRs get merged quicker because the devs already disregarded these. Because of this, I agree, high complexity PRs should be reviewed first, and maybe this actually would do something about the PR problem.
I would suggest something else: In cases where there is the 'One Approval' label, find a second dev to approve it and merge it! There are currently 23 PRs with 'One Approval' and they usually never go anywhere. Putting high priority on these would definitely be a step in the right direction.
As for Issue #9989, my comment on it is already there. Modularizing minetest would make it more complicated without a shadow of a doubt, harder for devs to do things, and more confusing. Secondly, it won't close any PRs or issues automagically, it will just diversify them into different repositories/issue-trackers. Ugh.
I would suggest something else: In cases where there is the 'One Approval' label, find a second dev to approve it and merge it! There are currently 23 PRs with 'One Approval' and they usually never go anywhere. Putting high priority on these would definitely be a step in the right direction.
As for Issue #9989, my comment on it is already there. Modularizing minetest would make it more complicated without a shadow of a doubt, harder for devs to do things, and more confusing. Secondly, it won't close any PRs or issues automagically, it will just diversify them into different repositories/issue-trackers. Ugh.
- Linuxdirk
- Member
- Posts: 3218
- Joined: Wed Sep 17, 2014 11:21
- In-game: Linuxdirk
- Location: Germany
- Contact:
Re: There are too many PRs
If it works like with issues then “high priority” means nothing as there are issues opened 6 years ago labeled as “high priority”.
- rubenwardy
- Moderator
- Posts: 6972
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: There are too many PRs
I have gone through the list today and closed 4 PRs that can definitely be closed by this point. I tagged a few others as possible close
We already have a policy of closing PRs after 1 month if there's no response from the author
Please bump issues and PRs that you think should be closed
We already have a policy of closing PRs after 1 month if there's no response from the author
Please bump issues and PRs that you think should be closed
Re: There are too many PRs
Maybe a Testcon. To be discussed in person.
Spain would be is a good place to the first event (after covid). We have the 3 s: Sun, Sangria and S... that :-D
Spain would be is a good place to the first event (after covid). We have the 3 s: Sun, Sangria and S... that :-D
-
- Member
- Posts: 407
- Joined: Sat Dec 29, 2018 19:21
- GitHub: KaylebJay
- IRC: KaylebJay
- In-game: CalebJ
- Location: Tunnelers' Abyss
Re: There are too many PRs
Nice, thanks! I think, the rest of them just need more core dev love :-) (And of course, 5.3.0 is already in feature freeze ...)rubenwardy wrote: ↑Wed Jun 17, 2020 20:24I have gone through the list today and closed 4 PRs that can definitely be closed by this point. I tagged a few others as possible close
We already have a policy of closing PRs after 1 month if there's no response from the author
Please bump issues and PRs that you think should be closed
Quite true, Linuxdirk, but I only see 6 High Priority issues (one from 2014, ouch). 23 to 6 wouldn't be so bad :)If it works like with issues then “high priority” means nothing as there are issues opened 6 years ago labeled as “high priority”.
- v-rob
- Developer
- Posts: 970
- Joined: Thu Mar 24, 2016 03:19
- GitHub: v-rob
- IRC: v-rob
- Location: Right behind you.
Re: There are too many PRs
I think the "Low complexity" label would be very useful; there are many PRs that are actually very simple and would only take a little bit of reviewing to complete. Finishing a lot of small jobs could drastically reduce the amount of PRs. I personally am trying to make my PRs smaller with less features for this precise reason, and I can add the rest of the features in later PRs.
- Linuxdirk
- Member
- Posts: 3218
- Joined: Wed Sep 17, 2014 11:21
- In-game: Linuxdirk
- Location: Germany
- Contact:
Re: There are too many PRs
So you say that in all the 154 open PRs for Minetest the authors are active at least once a month?rubenwardy wrote: ↑Wed Jun 17, 2020 20:24We already have a policy of closing PRs after 1 month if there's no response from the author
- rubenwardy
- Moderator
- Posts: 6972
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: There are too many PRs
Response requires a reviewer to request or ask for something
- Zughy
- Member
- Posts: 301
- Joined: Thu Mar 26, 2020 18:23
- GitHub: belongs_to_microsoft
- In-game: Zughy
- Location: Italy
- Contact:
Re: There are too many PRs
So we're back on dev timerubenwardy wrote: ↑Thu Jun 18, 2020 08:41Response requires a reviewer to request or ask for something
- Wuzzy
- Member
- Posts: 4786
- Joined: Mon Sep 24, 2012 15:01
- GitHub: Wuzzy2
- IRC: Wuzzy
- In-game: Wuzzy
- Contact:
Re: There are too many PRs
What about inviting people other than core devs to do some of the “grunt work”?
That is, doing this “boring” pre-review work.
People who at least have shown a basic understanding of software development and Minetest itself while not being a core dev …
Thing is, there's a really tiny number of people who (can) actually decide things.
I suppose most of this pre-review work can be done without having perfect knowledge about all of the Minetest internals.
IIRC celeron55 or another coredev had a similar idea a while ago. However, for this to actually work, IMO it's not enough to just say “help us review stuff” and that's it. An instruction manual specifically for those people would help a lot. Because they can't read your mind. :P And the label “pre-pending” will definitely help a lot here.
Also: What is the official opinion regarding my suggestion from the previous post?
The “lack of dev time” is a myth. There IS plenty of dev time. Look at how many volunteer coders we have! It's just that the majority are not core devs, that's all. What we have is a lack of CORE dev time. Subtle difference.
Also, the way the system works is that contributors are still kinda treated as people who “want something from Minetest” (like a customer), rather than collaborators on equal footing that actually give something. Even if they put in a lot of work in their PR … I think this is also a problem culturally, if we ignore all the organizational stuff, and I bet this quickly burns out many would-be-long-term-contributors. :-(
That is, doing this “boring” pre-review work.
People who at least have shown a basic understanding of software development and Minetest itself while not being a core dev …
Thing is, there's a really tiny number of people who (can) actually decide things.
I suppose most of this pre-review work can be done without having perfect knowledge about all of the Minetest internals.
IIRC celeron55 or another coredev had a similar idea a while ago. However, for this to actually work, IMO it's not enough to just say “help us review stuff” and that's it. An instruction manual specifically for those people would help a lot. Because they can't read your mind. :P And the label “pre-pending” will definitely help a lot here.
Also: What is the official opinion regarding my suggestion from the previous post?
The “lack of dev time” is a myth. There IS plenty of dev time. Look at how many volunteer coders we have! It's just that the majority are not core devs, that's all. What we have is a lack of CORE dev time. Subtle difference.
Also, the way the system works is that contributors are still kinda treated as people who “want something from Minetest” (like a customer), rather than collaborators on equal footing that actually give something. Even if they put in a lot of work in their PR … I think this is also a problem culturally, if we ignore all the organizational stuff, and I bet this quickly burns out many would-be-long-term-contributors. :-(
- LMD
- Member
- Posts: 1386
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: There are too many PRs
This.Wuzzy wrote: ↑Fri Jun 19, 2020 18:23The “lack of dev time” is a myth. There IS plenty of dev time. Look at how many volunteer coders we have! It's just that the majority are not core devs, that's all. What we have is a lack of CORE dev time. Subtle difference.
Also, the way the system works is that contributors are still kinda treated as people who “want something from Minetest” (like a customer), rather than collaborators on equal footing that actually give something. Even if they put in a lot of work in their PR … I think this is also a problem culturally, if we ignore all the organizational stuff, and I bet this quickly burns out many would-be-long-term-contributors. :-(
- Linuxdirk
- Member
- Posts: 3218
- Joined: Wed Sep 17, 2014 11:21
- In-game: Linuxdirk
- Location: Germany
- Contact:
Re: There are too many PRs
Quoted for emphasis and agreement.
- Lone_Wolf
- Member
- Posts: 2576
- Joined: Sun Apr 09, 2017 05:50
- GitHub: LoneWolfHT
- IRC: LandarVargan
- In-game: LandarVargan
Re: There are too many PRs
But they *do* want something
They want their PRs merged
They want their PRs merged
- Zughy
- Member
- Posts: 301
- Joined: Thu Mar 26, 2020 18:23
- GitHub: belongs_to_microsoft
- In-game: Zughy
- Location: Italy
- Contact:
Re: There are too many PRs
I think the Pull Requests feature popularized by Git gave to some the wrong idea.
PRs actually consists in hundreds of people |i]pushing[/i] things on a dozen of people (at best). No wonder PRs eventually overflow. Just looking at them takes too much time already. It's like a brain DDOS. That's the bad side of "social coding".
PRs are a terrible feature in the large, because it does not "scale" for this very reason. Just like, before the advent of Github, maintainers of popular projects did ignore email requests from random people. Github did not really solve anything in this area.
One cannot manage hundreds of developers with just one layer of management. Just look at what the Lua team does (no PR) or what the Linux kernel team does (multiple layers of management). Both are old and popular projects that did stay away from the "social coding" delusions.
PRs actually consists in hundreds of people |i]pushing[/i] things on a dozen of people (at best). No wonder PRs eventually overflow. Just looking at them takes too much time already. It's like a brain DDOS. That's the bad side of "social coding".
PRs are a terrible feature in the large, because it does not "scale" for this very reason. Just like, before the advent of Github, maintainers of popular projects did ignore email requests from random people. Github did not really solve anything in this area.
One cannot manage hundreds of developers with just one layer of management. Just look at what the Lua team does (no PR) or what the Linux kernel team does (multiple layers of management). Both are old and popular projects that did stay away from the "social coding" delusions.
Re: There are too many PRs
Look what the team of Veloren do in a recent interview:
https://www.gamingonlinux.com/2020/06/interviewed-veloren-an-upcoming-foss-multiplayer-voxel-rpg/
In short: Collaborative teamwork and objectives. All what I said...
https://www.gamingonlinux.com/2020/06/interviewed-veloren-an-upcoming-foss-multiplayer-voxel-rpg/
In short: Collaborative teamwork and objectives. All what I said...
- Linuxdirk
- Member
- Posts: 3218
- Joined: Wed Sep 17, 2014 11:21
- In-game: Linuxdirk
- Location: Germany
- Contact:
Re: There are too many PRs
If you don’t want PRs, disable the permission to create them.
-
- Member
- Posts: 407
- Joined: Sat Dec 29, 2018 19:21
- GitHub: KaylebJay
- IRC: KaylebJay
- In-game: CalebJ
- Location: Tunnelers' Abyss
Re: There are too many PRs
Re: There are too many PRs
Another thing about dev-time.
I think it would be useful to split lua and core development up.
C++ Minetest Developement is a lot more harder to understand than just modding.
There is no core_api.txt file like lua_api.txt informing about all the classes.
A lot more people could be minetest-mods "core developer".
Than "real" core-devs would also have more time for the core.
I think it would be useful to split lua and core development up.
C++ Minetest Developement is a lot more harder to understand than just modding.
There is no core_api.txt file like lua_api.txt informing about all the classes.
A lot more people could be minetest-mods "core developer".
Than "real" core-devs would also have more time for the core.
- rubenwardy
- Moderator
- Posts: 6972
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: There are too many PRs
ANAND / ClobberXD is now a core developer. More people are being considered
- rubenwardy
- Moderator
- Posts: 6972
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: There are too many PRs
Here's the landing page for Engine documentation: https://dev.minetest.net/EngineLejo wrote: ↑Tue Jun 23, 2020 19:23Another thing about dev-time.
I think it would be useful to split lua and core development up.
C++ Minetest Developement is a lot more harder to understand than just modding.
There is no core_api.txt file like lua_api.txt informing about all the classes.
A lot more people could be minetest-mods "core developer".
Than "real" core-devs would also have more time for the core.
Remember that minetest-mods is not official. There is also a separate Minetest Game core development team to Minetest (Engine)
Re: There are too many PRs
Hope this helps.ANAND / ClobberXD is now a core developer. More people are being considered
I currently also have...
...one pr which were only one time aproved
...one reviewed pr which weren't merged or denied afterwards
...one rebase-PR which were not even touched
...one non trival which could be closed(just don't care)
At least two of them could be merged or denied pretty fast.
It's nothing in comparison to lua_api.txtrubenwardy wrote: ↑Tue Jun 23, 2020 19:26Here's the landing page for Engine documentation: https://dev.minetest.net/Engine
It's a help but core-development is anyway let's say... not easy.
Didn't knew that, it seems to be cause it's also managed by some core devs :)rubenwardy wrote: ↑Tue Jun 23, 2020 19:26Remember that minetest-mods is not official. There is also a separate Minetest Game core development team to Minetest (Engine)
- Linuxdirk
- Member
- Posts: 3218
- Joined: Wed Sep 17, 2014 11:21
- In-game: Linuxdirk
- Location: Germany
- Contact:
Re: There are too many PRs
So the wiki now is the official source for documentation again?rubenwardy wrote: ↑Tue Jun 23, 2020 19:26Here's the landing page for Engine documentation: https://dev.minetest.net/Engine
- rubenwardy
- Moderator
- Posts: 6972
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: There are too many PRs
The wiki is the official source for engine development guidelines and documentation, and always has been. It is not the official source for the Lua API, and never wasLinuxdirk wrote: ↑Tue Jun 23, 2020 20:39So the wiki now is the official source for documentation again?rubenwardy wrote: ↑Tue Jun 23, 2020 19:26Here's the landing page for Engine documentation: https://dev.minetest.net/Engine
"official" is a strange term here. The Wiki is official - the Lua API stuff is just not canonical or maintained during development
Who is online
Users browsing this forum: ROllerozxa and 15 guests