[Mod] Minecraft like item drop/pick up [item_drop]

[Splizard]

With activating mesecon pistons this error occurs:

Code: Select all

minetest/item_drop/init.lua:31: attempt to index a nil value

[Spots]

minetest-0.4.1-win32 , Windows 7 ,item_drop v3

[leo_rockway]

In moreores' init.lua line 60, the drop has an additional "craft" in front of the name of the drop, which confuses your mod.
I believe that your mod is acting correctly, so I changed that line in moreores to this:

Code: Select all

drop = item_base..'_lump 1'

It seems to work fine now.

[SegFault22]

why limit stacks to 64? That's too Minecraft-like and slow.

[u34]

works fine with latest minecraft version (0.4.2) ... awesome ...

[PilzAdam]

why limit stacks to 64? That's too Minecraft-like and slow.

Its because its a mod from my game MiniTest wich copies Minecraft like features. I will change it in this mod.

[kozec]

Hi! My server sometimes crashes with this message:

Code: Select all

13:31:34: ERROR[main]: ServerError: LuaError: error: .../.minetest/mods/minetest/item_drop/init.lua:92: attempt to index a nil value

I added check for item and item:get_luaentity() nil values, but I'm not sure if it's not part of some bigger bug, so it may be good idea to report it.

[cornernote]

had a bug at line 34 where item was nil... line 34 is:

Code: Select all

local item = minetest.env:add_item(pos, oldnode)

added this below it

Code: Select all

if item ~= nil then
... do the stuff you had
end

[cornernote]

I had another bug where anzahl was not a number. It was caused when digging moreores tin. The problem is the node name that drops looks like this:

Code: Select all

craft "mod:item" 1

Here is the fix:
find:

Code: Select all

if string.find(oldnode.name, " ") ~= nil then

below, insert:

Code: Select all

oldnode.name = oldnode.name:gsub('"',""):gsub("craft ",""):gsub("item ",""):gsub("node ","")

EDIT, changed the code

[u34]

where is the next update please .......

[leo_rockway]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

[PilzAdam]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

License? WTFPL would be best.

[leo_rockway]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

License? WTFPL would be best.

CC-BY 3.0. I didn't upload it, I was just looking for existing sounds on OGA.
I have modified the pitch with Audacity and created a few of these. So when I pick up items it goes POP pop PoP poP! o.o

[Melkor]

I've been testing this mod and looks great, but I would like to comment on a few things:
1. Some items such as coal exceed the maximum limit of 64 to 99.
2. how nodes are attracted by the played makes this too easy, it's like wearing a magnet, gravity is the one who has to win! The player should have to walk over the item to pick up it.
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

[cornernote]

I've been testing this mod and looks great, but I would like to comment on a few things:
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

I think lava should destroy it. Perhaps placing any block will destroy it? What does MC do?

[leo_rockway]

I've been testing this mod and looks great, but I would like to comment on a few things:
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

I think lava should destroy it. Perhaps placing any block will destroy it? What does MC do?

MC moves them to the nearest air node, like Melkor said.

[Melkor]

well, that could be the 4th point: Lava should destroy everything what falls on it

[PilzAdam]

I made a complete rewrite of the code. See GitHub: https://github.com/PilzAdam/item_drop

[cornernote]

anything functionally different? or just a different way of writing the code?

[PilzAdam]

anything functionally different? or just a different way of writing the code?

The functionallity is the same but some (nearly all) bugs are fixed e.g. my farming mod now drops everything correctly.

[Josh]

This should be added in by default. Or are you guys happy with the goes straight into your inventory thing?

[Echo]

In 0.4.3 there's a new function:
minetest.handle_node_drops(pos, drops, digger)

It could be used to optimize your mod.
I think celeron added this because of the popularity of your mod :-)

[PilzAdam]

In 0.4.3 there's a new function:
minetest.handle_node_drops(pos, drops, digger)

It could be used to optimize your mod.
I think celeron added this because of the popularity of your mod :-)

c55 added this because we were talking about improvement of my code. It is already in latest GitHub.

[Echo]

PilzAdam

[PilzAdam]

PilzAdam

:-D