How to fix broken crosshair display?

Post Reply
User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

How to fix broken crosshair display?

by Linuxdirk » Post

Basically the title.

I have the left crosshair, but it is shown like on the right.

The image is scaled up to see the effect I mean.

This happens with 5.8. With 5.7.x versions I do not have this issue.

Any idea how to fix that?
Attachments
How it is rendered (right), and how it should be rendered (left)
How it is rendered (right), and how it should be rendered (left)
screenshot.png (6.51 KiB) Viewed 1542 times
crosshair file from my texture pack
crosshair file from my texture pack
crosshair.png (233 Bytes) Viewed 1542 times

User avatar
cx384
Member
Posts: 655
Joined: Wed Apr 23, 2014 09:38
GitHub: cx384
IRC: cx384

Re: How to fix broken crosshair display?

by cx384 » Post

I searched in the git history and apparently this is a new feature.
https://github.com/minetest/minetest/pull/13772

Maybe changing your hud_scaling setting will fix it.
Or maybe making the texture's height and width odd/even, such that there is/isn't a single centered pixel.
Can your read this?

User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by Linuxdirk » Post

Neither gui_scaling nor hud_scaling is set.

But the discussion linked in the PR is funny. Basically “yes, but we simply ignore it”. I guess we now have to live with broken crosshairs forever. :(

User avatar
Wuzzy
Member
Posts: 4795
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy
Contact:

Re: How to fix broken crosshair display?

by Wuzzy » Post

Write a proper bug report then. A comment in a PR doesn't count. And the discussion doesn't REALLY read like "we simply ignore it", so there is still a chance.
Especially a bug report with these screenshots would be hard to deny.

User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by Linuxdirk » Post

Wuzzy wrote:
Wed Dec 27, 2023 00:58
And the discussion doesn't REALLY read like "we simply ignore it", […]
In the end, exactly THIS is the statement that is conveyed through comments, IRC discussions, and actions. I stopped caring for MT development long time ago because it is always like that – and I stopped using Microsoft services decades ago.

User avatar
LMD
Member
Posts: 1396
Joined: Sat Apr 08, 2017 08:16
GitHub: appgurueu
IRC: appguru[eu]
In-game: LMD
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by LMD » Post

Linuxdirk wrote:
Wed Dec 27, 2023 06:04
Wuzzy wrote:
Wed Dec 27, 2023 00:58
And the discussion doesn't REALLY read like "we simply ignore it", […]
In the end, exactly THIS is the statement that is conveyed through comments, IRC discussions, and actions. I stopped caring for MT development long time ago because it is always like that – and I stopped using Microsoft services decades ago.
This is simply not true and is extremely dismissive of the efforts of all the developers who fix issues in their spare time.

I would like to remind you that we have three thousand merged pull requests. There are six thousand closed issues (and "only" one thousand open issues) - that is, the vast, vast majority of issues gets fixed eventually.
My stuff: Projects - Mods - Website

User avatar
grorp
Developer
Posts: 5
Joined: Sun Apr 25, 2021 17:20
GitHub: grorp
In-game: grorp

Re: How to fix broken crosshair display?

by grorp » Post

What texture pack is that crosshair from?

P.S. I must agree with LMD that you're being dismissive here - and also lazy, since you didn't even bother to create a bug report.

User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by Linuxdirk » Post

grorp wrote:
Thu Mar 28, 2024 11:32
What texture pack is that crosshair from?
I made it myself. Original file is attached to the post..
grorp wrote:
Thu Mar 28, 2024 11:32
and also lazy, since you didn't even bother to create a bug report.
There was a merge request and your answer to an absolutely valid, reasonable concern basically reads “this is the new behavior, deal with it”.

(Sorry, I’m just mad.)

https://github.com/minetest/minetest/pull/13772

There is also this unassigned, not approved, and not commented PR in rebase hell since a few months that would fix this issue entirely.

https://github.com/minetest/minetest/pull/14273

I do not see how an issue would help here (the fact aside that i do not use Github).

User avatar
grorp
Developer
Posts: 5
Joined: Sun Apr 25, 2021 17:20
GitHub: grorp
In-game: grorp

Re: How to fix broken crosshair display?

by grorp » Post

Linuxdirk wrote:
Thu Mar 28, 2024 13:57
Original file is attached to the post..
I see, didn't notice the attachment before. With fractional scaling, it indeed looks distorted in-game. A quick fix would be to set your HUD scaling so that it cancels out your DPI. These factors would work if the sizes in your screenshot were proportional to the original sizes:

121 / 198 = 0.611111
2 / (198 / 121) = 1.222222
Linuxdirk wrote:
Thu Mar 28, 2024 13:57
There was a merge request and your answer to an absolutely valid, reasonable concern basically reads “this is the new behavior, deal with it”.

(Sorry, I’m just mad.)

https://github.com/minetest/minetest/pull/13772
I honestly don't understand how you read this meaning from my comment. I didn't say anything like that. I suggested a fix, which was rejected on IRC, even by erlehmann. In the end, nobody proposed an alternative fix and so the issue wasn't fixed.

I'm probably going to propose my fix again and see what happens.
Linuxdirk wrote:
Thu Mar 28, 2024 13:57
There is also this unassigned, not approved, and not commented PR in rebase hell since a few months that would fix this issue entirely.

https://github.com/minetest/minetest/pull/14273
I just tried that PR, the problem is still there... I agree that having PRs in "rebase hell" is bad, but we simply have too many PRs and too few reviewers.
Linuxdirk wrote:
Thu Mar 28, 2024 13:57
I do not see how an issue would help here (the fact aside that i do not use Github).
An issue would have helped because you could have shown a concrete problem case. Until now, the problem was merely a theoretical one. erlehmann reports many theoretical problems, and not all of them are relevant in practice.

User avatar
grorp
Developer
Posts: 5
Joined: Sun Apr 25, 2021 17:20
GitHub: grorp
In-game: grorp

Re: How to fix broken crosshair display?

by grorp » Post


User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by Linuxdirk » Post

Awesome, thanks! Let’s hope for the best.

User avatar
grorp
Developer
Posts: 5
Joined: Sun Apr 25, 2021 17:20
GitHub: grorp
In-game: grorp

Re: How to fix broken crosshair display?

by grorp » Post

The PR has been merged.

User avatar
Linuxdirk
Member
Posts: 3219
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: How to fix broken crosshair display?

by Linuxdirk » Post

Hey, that was reasonably fast and sounds awesome!

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests