How long does it usually takes before an admin having a pull request reviewed?

Post Reply
badentry
New member
Posts: 8
Joined: Tue Jul 09, 2024 07:56

How long does it usually takes before an admin having a pull request reviewed?

by badentry » Post

I ask this because my recent pull request https://github.com/minetest/minetest/pull/14787 don't have a single reviewer for nearly a week. No offense but I just want to know how long it usually takes before review, I've tested and dealt with this bug, and the heat to just go on waiting for reviewers for unknown time length is gonna cook me to well done someway. Please help

User avatar
cx384
Member
Posts: 679
Joined: Wed Apr 23, 2014 09:38
GitHub: cx384
IRC: cx384

Re: How long does it usually takes before an admin having a pull request reviewed?

by cx384 » Post

It depends, it can be less than a day or more than a year. Currently, Minetest is in feature freeze time if I'm not wrong, so I wouldn't expect too much until it is over, even though your PR is only a bug fix.

The development of Minetest is generally not very fast, and you are not the only one waiting ;) , e.g. see some of my open PRs: https://github.com/minetest/minetest/pull/14318 https://github.com/minetest/minetest/pull/14321

To reduce the time it takes for a review, it may help if you keep your PR up to date all the time (rebase) or talk to the core devs (IRC) if there has not been any progress for a month or so, but I guess you just have to be patient. ;)

Also see Merge Chance Complexity Diagram.

Oh, and here are the code format conventions you asked for, but as far as I can tell they aren't used very strictly, and sadly Minetest doesn't enforce them in the CI.
https://dev.minetest.net/Code_style_guidelines
Can your read this?

badentry
New member
Posts: 8
Joined: Tue Jul 09, 2024 07:56

Re: How long does it usually takes before an admin having a pull request reviewed?

by badentry » Post

cx384 wrote:
Tue Jul 09, 2024 15:20
It depends, it can be less than a day or more than a year. Currently, Minetest is in feature freeze time if I'm not wrong, so I wouldn't expect too much until it is over, even though your PR is only a bug fix.

The development of Minetest is generally not very fast, and you are not the only one waiting ;) , e.g. see some of my open PRs: https://github.com/minetest/minetest/pull/14318 https://github.com/minetest/minetest/pull/14321

To reduce the time it takes for a review, it may help if you keep your PR up to date all the time (rebase) or talk to the core devs (IRC) if there has not been any progress for a month or so, but I guess you just have to be patient. ;)

Also see Merge Chance Complexity Diagram.

Oh, and here are the code format conventions you asked for, but as far as I can tell they aren't used very strictly, and sadly Minetest doesn't enforce them in the CI.
https://dev.minetest.net/Code_style_guidelines
;) Thank you for your guiding info on this! it really relieves me when hearing this is a period thing and I'm not the only one who encounter this. I'm pretty interested in dealing with bugs, but when it comes to code style problems, it's almost always frustrating for me, and to know that my pull request can be put aside just because of the code style someway like hanging a sword above me, and that feeling is a thing I'm not good at dealing with, so pretty much I'll say I'm in need of help on this if there's really some problems with my code style, maybe a helping commit or something.
Again, thank you for your time providing me with those helping info! Much appreciated.

User avatar
LMD
Member
Posts: 1427
Joined: Sat Apr 08, 2017 08:16
GitHub: appgurueu
IRC: appguru[eu]
In-game: LMD
Location: Germany
Contact:

Re: How long does it usually takes before an admin having a pull request reviewed?

by LMD » Post

No offense taken; nothing wrong with a little poking. Often people have a lot on their plate and either forget or didn't notice, hence (at least I) appreciate a little poking.

Briefly: Generally, the older and more experienced people are, the busier they are, be it with work, university, other projects, family, friends, etc. This means there is a shortage of core dev time. This means core devs need to prioritize: What does the most good for Minetest, while requiring comparatively little effort to get it over the finish line? As a tendency, "ready for review" PRs will be preferred over draft / WIP ones; PRs from more experienced contributors may be preferred over those from newcomers; highly popular features over more obscure ones etc etc. Scheduling considerations also come into play, and of course personal preferences play a big part as well.

I'm afraid I currently have "real life" matters to tend to, so I'm hardly getting review work done at the moment. Current priorities in feature freeze are, first and foremost, fixing (blocking) regressions, and this is not one of them. After 5.9.0 releases, my priorities are (roughly speaking): glTF, entity optimizations, some miscellaneous other PRs I'm already involved in.

Something I would also encourage: Try to get feedback, including possibly reviews, from other experienced contributors, modders and players. This can save core devs some work and bring your PR closer to the finish line before a core dev picks up reviewing it.
My stuff: Projects - Mods - Website

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests