Coloured Beds

Post Reply
User avatar
thefamilygrog66
Member
Posts: 170
Joined: Mon Jul 09, 2012 19:08
Location: Ontario, Canada

Coloured Beds

by thefamilygrog66 » Post

I was playing around with PilzAdam's beds mod last night/this evening, and have changed a few things in it:

1) prevented bed tops (i.e. pillow end) from destroying other nodes when the bed is placed - I think this is important, since it prevents not only accidental destruction, but also griefer destruction of locked chests, steel doors, etc.

2) changed the overall look of the bed, and added a 3D pillow

3) looped most of the code to create nine different coloured beds (roygbv + black, grey and white)

The recipe has changed to:
coloured wool coloured wool white wool
stick stick
Download: https://github.com/thefamilygrog66/beds ... master.zip
GitHub: https://github.com/thefamilygrog66/beds

Here's a screenshot:

Image

PilzAdam has now merged this into his beds mod.
Last edited by thefamilygrog66 on Wed Sep 18, 2013 01:55, edited 1 time in total.

User avatar
kaeza
Moderator
Posts: 2162
Joined: Thu Oct 18, 2012 05:00
GitHub: kaeza
IRC: kaeza diemartin blaaaaargh
In-game: kaeza
Location: Montevideo, Uruguay
Contact:

by kaeza » Post

This is nice!
Please post download link :D
Your signature is not the place for a blog post. Please keep it as concise as possible. Thank you!

Check out my stuff! | Donations greatly appreciated! PayPal

User avatar
thefamilygrog66
Member
Posts: 170
Joined: Mon Jul 09, 2012 19:08
Location: Ontario, Canada

by thefamilygrog66 » Post

kaeza wrote:This is nice!
Please post download link :D
Thanks! I put a link in the first post.

User avatar
PilzAdam
Member
Posts: 4026
Joined: Fri Jul 20, 2012 16:19
GitHub: PilzAdam
IRC: PilzAdam
Location: Germany

by PilzAdam » Post

Are you familiar with git/github? Id like to see this merged into my beds mod.

User avatar
thefamilygrog66
Member
Posts: 170
Joined: Mon Jul 09, 2012 19:08
Location: Ontario, Canada

by thefamilygrog66 » Post

PilzAdam wrote:Are you familiar with git/github? Id like to see this merged into my beds mod.
Hey PilzAdam: that would be great. I'm familiar with github, though I've never merged code on it before. The only problem I can see is that I've removed the default bed (i.e. there are only the beds defined by their colour), so if someone already has your bed mod installed, there will be a number of unknown nodes after updating. Let me know what you think, and also if you have any info on how to merge what I've done into your mod - thanks!

Edit: the unknown node issue can be solved using aliases:

minetest.register_alias("beds:bed_bottom", "colouredbeds:bed_bottom_blue")
minetest.register_alias("beds:bed_top", "colouredbeds:bed_top_blue")
Last edited by thefamilygrog66 on Mon Apr 01, 2013 15:58, edited 1 time in total.

User avatar
Likwid H-Craft
Member
Posts: 1113
Joined: Sun Jan 06, 2013 14:20
Location: Lost in Crypt

by Likwid H-Craft » Post

No Black bed?
My Domain's/others:
http://likwidtest.hj.cx/ (Not Done)

User avatar
thefamilygrog66
Member
Posts: 170
Joined: Mon Jul 09, 2012 19:08
Location: Ontario, Canada

by thefamilygrog66 » Post

Likwid H-Craft wrote:No Black bed?
I've now added black, grey and white.
Last edited by thefamilygrog66 on Mon Apr 01, 2013 20:03, edited 1 time in total.

User avatar
PilzAdam
Member
Posts: 4026
Joined: Fri Jul 20, 2012 16:19
GitHub: PilzAdam
IRC: PilzAdam
Location: Germany

by PilzAdam » Post

thefamilygrog66 wrote:
PilzAdam wrote:Are you familiar with git/github? Id like to see this merged into my beds mod.
Hey PilzAdam: that would be great. I'm familiar with github, though I've never merged code on it before. The only problem I can see is that I've removed the default bed (i.e. there are only the beds defined by their colour), so if someone already has your bed mod installed, there will be a number of unknown nodes after updating. Let me know what you think, and also if you have any info on how to merge what I've done into your mod - thanks!
You basically have to fork my beds repo on github (https://github.com/PilzAdam/beds), then set up a local repo on your computer and do the changes there. Then you can push to your fork on github and create a pull request against my repo.
And for the old beds, just add

Code: Select all

minetest.register_alias("beds:bed_bottom", "beds:bed_bottom_blue")
minetest.register_alias("beds:bed_top", "beds:bed_top_blue")
minetest.register_alias("beds:bed", "beds:bed_bottom_blue")
(and change the mod prefix to "beds:" in your code).

User avatar
thefamilygrog66
Member
Posts: 170
Joined: Mon Jul 09, 2012 19:08
Location: Ontario, Canada

by thefamilygrog66 » Post

PilzAdam wrote:You basically have to fork my beds repo on github (https://github.com/PilzAdam/beds), then set up a local repo on your computer and do the changes there. Then you can push to your fork on github and create a pull request against my repo.
And for the old beds, just add

Code: Select all

minetest.register_alias("beds:bed_bottom", "beds:bed_bottom_blue")
minetest.register_alias("beds:bed_top", "beds:bed_top_blue")
minetest.register_alias("beds:bed", "beds:bed_bottom_blue")
(and change the mod prefix to "beds:" in your code).

Ah, you beat me to it with the old beds solution. :)

I've pushed to my fork on github, and created a pull request - let me know if I need to do anything else.
Last edited by thefamilygrog66 on Mon Apr 01, 2013 18:45, edited 1 time in total.

User avatar
PilzAdam
Member
Posts: 4026
Joined: Fri Jul 20, 2012 16:19
GitHub: PilzAdam
IRC: PilzAdam
Location: Germany

by PilzAdam » Post

Merged.

Post Reply

Who is online

Users browsing this forum: ElCeejo, Google [Bot], VanessaE and 3 guests