[Mod] torches [torches]

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

[Mod] torches [torches]

by sofar » Sat Apr 02, 2016 23:41

I've brushed up Blockmen's excellent 3D torch mod, and re-released it, with the following modifications:

This mod is part of minetest_game 0.4.15!

With exception of the wieldlight, this mod is part of the default game. The current code here is kept for archival purposes.

I may end up breaking out the wieldlight into a separate mod for use with 0.4.15. If that happens I'll insert a link here.

~~~~~~
- added wield light - hold a torch in your hands and light up your surroundings!
- drop-in replacement for standard minetest_game torches
- drop-in replacement for torches versions from before version 4.
- no configuration options
- entirely cleaned up mesh, re-did the mesh model from scratch
- model now works better with animated textures due to texture placement and alignment
- wallmounted torches flames go up, not sideways up
- no particles
- uses an LBM (meaning, you need a new minetest) to reposition hanging torches
- upside down torches enabled by default (again, there are no config options or settings anymore)

Download: https://github.com/minetest-mods/torches/archive/master.zip
Dependencies: none (default)
github: https://github.com/minetest-mods/torches
License: CC-BY-3.0, LGPL-2.1+

Wieldlight demo video: https://youtu.be/mzvTZ45vgjw

Image

Image
Credits to Blockmen for making this excellent mod. Let's keep it alive.
Last edited by sofar on Thu Dec 08, 2016 01:31, edited 3 times in total.
 

User avatar
MineYoshi
Member
 
Posts: 5357
Joined: Wed Jul 08, 2015 13:20

Re: [mod]torches[torches]

by MineYoshi » Sun Apr 03, 2016 00:03

Very great, this mod is very cool!

I like that models, the textures are great!
+10000
nire patata zurea da, kide :-)
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [mod]torches[torches]

by sofar » Sun Apr 03, 2016 00:18

MineYoshi wrote:Very great, this mod is very cool!

I like that models, the textures are great!


You can get the texture pack converted from minecraft with mcresconvert (see my resource pack converter) - it's "AD Reforged 19v1". Unfortunately the license doesn't allow me to redistribute, so you need to download and convert it yourself.
 

User avatar
benrob0329
Member
 
Posts: 1238
Joined: Thu Aug 06, 2015 22:39
Location: Michigan
GitHub: Benrob0329
IRC: benrob0329
In-game: benrob03
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [mod]torches[torches]

by burli » Sun Apr 03, 2016 06:27

Well done. Now the torches are shown by the identify mod if you point on them. But you need to add damage

damage_per_second = 1,

And the reload from inftweak still doesn't work. But I have no idea why
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [mod]torches[torches]

by sofar » Sun Apr 03, 2016 07:54

burli wrote:damage_per_second = 1


Why? Just make a mod that overrides the node properties. Minetest_game torches don't damage players either, and I don't intend to stray far away from that when it comes to gameplay aspects.

burli wrote:And the reload from inftweak still doesn't work. But I have no idea why


The mod makes a fake itemstack and places an item from that, so that it can place either the normal or wallmounted version.
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [mod]torches[torches]

by burli » Sun Apr 03, 2016 08:13

sofar wrote:
burli wrote:damage_per_second = 1

Minetest_game torches don't damage players either

Well, in the current dev they already do damage

Image

sofar wrote:The mod makes a fake itemstack and places an item from that, so that it can place either the normal or wallmounted version.


Ah, ok. Maybe invtweak has to be modified to handle fake itemstacks
Attachments
screenshot_20160403_101124.jpg
(79.74 KiB) Not downloaded yet
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [mod]torches[torches]

by sofar » Sun Apr 03, 2016 17:56

burli wrote:
sofar wrote:
burli wrote:damage_per_second = 1

Minetest_game torches don't damage players either

Well, in the current dev they already do damage


Maybe in BlockMen's code they did, but I don't intend to retain that behavior.
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [mod]torches[torches]

by burli » Sun Apr 03, 2016 18:42

sofar wrote:Maybe in BlockMen's code they did, but I don't intend to retain that behavior.

No, the default torch from minetest game. No other addon installed
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [mod]torches[torches]

by sofar » Sun Apr 03, 2016 21:36

burli wrote:
sofar wrote:Maybe in BlockMen's code they did, but I don't intend to retain that behavior.

No, the default torch from minetest game. No other addon installed


I'm standing in a torch from minetest_game for like 3 minutes now, and no damage has happened.

You have a mod or something else that does it. There's no damage in the torch in minetest_game.

Just look at the code:

https://github.com/minetest/minetest_game/blob/master/mods/default/nodes.lua#L1344

I don't see a damage_per_second in this file other than for lava.
 

User avatar
azekill_DIABLO
Member
 
Posts: 7460
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [mod]torches[torches]

by burli » Mon Apr 04, 2016 12:51

sofar wrote:I don't see a damage_per_second in this file other than for lava.

You are right. But I have no idea why the default tourch makes damage in my case
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Mon Apr 11, 2016 07:29

I've added a "Wield" light to this mod, similar to what the "walking_light" mod does. The implementation should be more robust, though, than walking_light. Check the video out: https://youtu.be/mzvTZ45vgjw
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] torches [torches]

by burli » Mon Apr 11, 2016 07:46

Well done sofar. Also invtweak works now for whatever reason
 

User avatar
nyje
Member
 
Posts: 23
Joined: Mon Jul 27, 2015 09:47
In-game: Nigel

Re: [Mod] torches [torches]

by nyje » Tue Apr 12, 2016 05:45

Excellent work. Added to our server.
Nigel's Odd servers at minetestserver.mine.bz are online 24/7. Port 30000 RAINBOW survival. Admin:Nigel, Port 30001 TECH3 Survival Admin: Anthony, Port 30002 SIMPLE creative Admin: Nigel, Port 30003 PLAY non-building server Admin: Nigel, Port 30004 RAINBOW creative Admin: Elektra, Port 30005 Block Color Admin:Nigel For Now
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Tue Apr 12, 2016 06:22

FYI if you previously ran v3.0.1, then today's git version seamlessly converts the old torches to the new versions.
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] torches [torches]

by burli » Tue Apr 12, 2016 11:36

burli wrote:Well done sofar. Also invtweak works now for whatever reason

invtweak is only working if I place torches on the ground and on the ceiling. Wall monted torches are ignored by invtweak and my overwrite for damage also doesn't work
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Tue Apr 12, 2016 14:15

burli wrote:
burli wrote:Well done sofar. Also invtweak works now for whatever reason

invtweak is only working if I place torches on the ground and on the ceiling. Wall monted torches are ignored by invtweak and my overwrite for damage also doesn't work


What ever these mods are doing, they should consider "default:torch" and "default:torch_wall" in the same way.
 

Star_Gamer
New member
 
Posts: 5
Joined: Tue Apr 12, 2016 05:15
Location: Russian Federation
GitHub: Oleg720
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Tue Apr 12, 2016 15:48



You need a newer minetest version. This mod uses features that are in the nightly builds by e.g. sfan5 or krock, or you can build from git. Note that this is listed in the topic above.
 

User avatar
burli
Member
 
Posts: 1608
Joined: Fri Apr 10, 2015 13:18

Re: [Mod] torches [torches]

by burli » Wed Apr 13, 2016 07:20

sofar wrote:
burli wrote:
burli wrote:Well done sofar. Also invtweak works now for whatever reason

invtweak is only working if I place torches on the ground and on the ceiling. Wall monted torches are ignored by invtweak and my overwrite for damage also doesn't work


What ever these mods are doing, they should consider "default:torch" and "default:torch_wall" in the same way.

Invtweak get's the name oft the placed node and compares the name with the inventory. The name oft a wall mounted torch is default:torch_wall, the name oft torches in The inventory is default:torch.

I can fix this, but just quick & dirty. Maybe I find a better solution
 

Nyarg
Member
 
Posts: 276
Joined: Sun May 15, 2016 04:32

Re: [Mod] torches [torches]

by Nyarg » Mon Sep 05, 2016 20:26

Hi ) What is name of texture pack used here ?
sofar wrote:Image
I am a noob. still yet. Not so noob ) [vml] WIP and a little proof for fun PlantedTorch )))
MT Strike 78a36b468554d101e0be3b0d1f587a555f396452 Great! Somebody have found it )
"My english isn't well" I know. I'm sorry )
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Tue Sep 20, 2016 17:07

I think it's AD Reforged? Check out the mcresconvert thread here:

viewtopic.php?f=4&t=14283
 

sofar
Developer
 
Posts: 1766
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: [Mod] torches [torches]

by sofar » Thu Dec 08, 2016 01:32

Just to reiterate - this code (sans wieldlight) is now part of minetest_game and will be part of the 0.4.15 release.
 

User avatar
AccidentallyRhine
Member
 
Posts: 228
Joined: Sun Aug 02, 2015 05:43

Re: [Mod] torches [torches]

by AccidentallyRhine » Thu Dec 08, 2016 05:54

Awesome that this is merged with minetest_game. These are the kinds of things Minetest needs be default. Sofar, at least some portions of your crops mod should also be added to farming ... in my honest opinion.
 

Next

Return to Mod Releases



Who is online

Users browsing this forum: No registered users and 6 guests