[Mod] Trainblocks [0.4] [trainblocks]

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

[Mod] Trainblocks [0.4] [trainblocks]

by maxx » Sun Mar 04, 2018 15:49

This mod adds simple signs for the advanced trains mod by orwell. In general it is like the subwayblocks mod by gpcf but there are some new signs.

Image

Download as .zip:
Download

Browse the Code:
Code

History:
2018-03-04 version 0.1 release
2018-03-05 version 0.2 better node registrations and craft receipes | changed textures
2018-03-06 version 0.21 alias added
2018-03-07 version 0.3 alias removed in trainblocks and added new signs. => trainblocks_bc for backwards compatibility
2018-09-24 version 0.4 code cleaned up; added new signs/blocks; textures uptdated
Last edited by maxx on Thu Sep 27, 2018 16:17, edited 35 times in total.
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 17:37

Please write down all your wishes here so I maybe can include them into the mod.
Ihr könnt natürlich eure Wünsche auch in deutscher Sprache äußern.
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
gpcf
Member
 
Posts: 272
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Sun Mar 04, 2018 21:20

Hi max!

I see you like my advtrains_subwayblocks mod so much that you've decided to improve it. However, your mod is a clear violation of my copyrights since you copied the pictures without crediting me. Also, your licensing under LGPL is also a violation, since my mod didn't have any license before (that means, it was proprietary, because I was too lazy to add a license) and it is now under AGPL.

I would like you to properly credit me and to change the license to something compatible with AGPL.
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 21:57

Thanks for your answer. The mod isn’t ready yet as you can see. Of course I will change the license file and add some copyright information.
But it is my first mod which I added to the forum so I am not perfect now.

Today I have found a bug in the code because of the signs and there will be many more signs like train sings in general.


And the mod is only inspired by your mod which is on the Linuxworks server (I haven’t seen your mod anywhere else) so I created the graphics and most of the code myself with the subway as the model.
Last edited by maxx on Wed Mar 07, 2018 06:25, edited 1 time in total.
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
gpcf
Member
 
Posts: 272
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Sun Mar 04, 2018 22:01

"License for Textures, Models and Sounds
---------------------------------------

CC-BY-SA 3.0 UNPORTED. Created by maxx"

You were very clearly trying to pass them off as your own.
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 22:05

At first I didn’t understand the License but I will change it the next days. Also I have removed the link as you can see
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
gpcf
Member
 
Posts: 272
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Sun Mar 04, 2018 22:08

The textures of the line numbers, except for line 2, are absolutely identical, btw.

Upper row: yours,
Lower row: mine.

Image
Attachments
screenshot_20180304_230610.png
(168.49 KiB) Not downloaded yet
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 22:10

That’s because I tried to make it like the signs on the subways by orwell but YES I will add you to the license
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
gpcf
Member
 
Posts: 272
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Sun Mar 04, 2018 22:12

I'd hardly call a pixel-by-pixel copy "inspired". Please make it clear that this is a modified version of my mod, and I'll gladly use this mod on Linuxworks server, since it adds a couple of nice new blocks!

Btw, my textures are under AGPL v3.
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 22:14

Yes I’ll do so.
Thanks for your help and support!!!
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
gpcf
Member
 
Posts: 272
Joined: Fri May 27, 2016 10:48
In-game: gabriel

Re: [Mod] Trainblocks [0.1] [trainblocks]

by gpcf » Sun Mar 04, 2018 22:20

May I ask you for another favor?
Can you please change the node names so they directly supersede the ones of subwayblocks, so this mod is backwards-compatible with subwayblocks, as a drop-in replacement?
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.1] [trainblocks]

by maxx » Sun Mar 04, 2018 22:24

Yes I will do so (but not today because it is too late now). And I have some other ideas as well which will be included the next days or weeks.
One other question: Which other mods did you use, when you tried out my mod?
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.2] [trainblocks]

by maxx » Mon Mar 05, 2018 16:16

I have downloaded your subways mod but your license file is wrong because you forgot to write in your name
Code: Select all
<one line to give the program's name and a brief idea of what it does.>
    Copyright (C) <year>  <name of author>

like you can see here.
I have added you to my license file.

And can I please have LGPL as License?
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

LuLa
New member
 
Posts: 8
Joined: Thu Nov 17, 2016 19:54
Location: Germany
GitHub: Tresonic
In-game: Tresonic[LuLa]

Re: [Mod] Trainblocks [0.2] [trainblocks]

by LuLa » Tue Mar 06, 2018 17:08

Hey,
I think the compatibility could also be maintained with minetest.register_alias like this:
Code: Select all
for count = 1, 10, 1 do
   minetest.register_alias("advtrains_subwayblocks:" .. count, "trainblocks:line" .. count)
end

minetest.register_alias("advtrains_subwayblocks:germany", "trainblocks:subwayblock")

Please correct me if I'm wrong!
Very nice mod btw.
Lu
Wieso einfach, wenn's auch kompliziert geht?
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.2] [trainblocks]

by maxx » Tue Mar 06, 2018 19:01

Trainblocks is now fully backwards-compatible to advtrains_subwayblocks!


old:
screenshot_20180308_160621.png
(419.98 KiB) Not downloaded yet


new:
screenshot_20180308_160940.png
(552.89 KiB) Not downloaded yet


Download trainblocks_bc for backwards-compatibility to advtrains_subwayblocks!
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.3] [trainblocks]

by maxx » Tue Apr 10, 2018 19:29

In a few days there will still be one version online (_bc as "normal" version). So please download trainblocks_bc up from now!

AND: new signs are waiting for you
e.g. emergency exit signs, new sbahn signs and traditional stuff
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 

User avatar
maxx
Member
 
Posts: 40
Joined: Thu Feb 15, 2018 15:24
Location: Germany | Bavaria
GitHub: maxxmodding
In-game: maxx or MrNobody

Re: [Mod] Trainblocks [0.4] [trainblocks]

by maxx » Mon Sep 24, 2018 18:33

New version available!
(Better late than never ;-))


screenshot.png
(350.6 KiB) Not downloaded yet
visit https://forum.minetest.net/viewtopic.php?f=9&t=19743 to get more information about trainblocks
 


Return to WIP Mods



Who is online

Users browsing this forum: No registered users and 2 guests