[Mod] Clementine Tree (clementinetree)

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

[Mod] Clementine Tree (clementinetree)

by runs » Tue Feb 12, 2019 21:19

I love clementines (a tangerine variety)!

Image

Image

Depends: default
Optional: stairs

License: GPLv3

Minetest version: 5.0+

The schematic is available in .mts and .lua format

Source Code

Download from DownGit
Last edited by runs on Wed Feb 13, 2019 15:34, edited 6 times in total.
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Wed Feb 13, 2019 13:44

Cool trees, i like it, but only a (noob)-question:

How can i download this tree-mods?
If i click on the link, i come to the repository, but there is nothing to download, only your full game with engine.

Image

Greetings, Clyde.
Attachments
Scrshot.png
(57.5 KiB) Not downloaded yet
 

User avatar
Hume2
Member
 
Posts: 198
Joined: Tue Jun 19, 2018 08:24
Location: Czech Republic
GitHub: Hume2
In-game: Hume2

Re: [Mod] Clementine Tree (clementinetree)

by Hume2 » Wed Feb 13, 2019 14:45

The problem is that the mod doesn't have its own repository. The link refers to a Minetest branch with an installed game that contains this mod.

@runs: An advice for you: Put your mod into a submodule, so you can update your mods independently. Submodule is a reference to an external repository which puts the content to your repository where you want. You can find more info at git help submodule.
If you lack the reality, go on a trip or find a job.
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Wed Feb 13, 2019 15:28

Hume2 wrote:The problem is that the mod doesn't have its own repository. The link refers to a Minetest branch with an installed game that contains this mod.

@runs: An advice for you: Put your mod into a submodule, so you can update your mods independently. Submodule is a reference to an external repository which puts the content to your repository where you want. You can find more info at git help submodule.


Too much complicated (for me) hahaha. Now it can be downloaded from Gitdown.
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Sat Feb 16, 2019 17:33

Hello runs,

i like your trees but i have some problems:

My config was:
Minetest 5.0.0 dev with the default game.
Added Mods are:
Moretrees
Biomes_Lib

Take a look:

clementine_shot.png
(101 KiB) Not downloaded yet

cherry_shot.png
(134.04 KiB) Not downloaded yet


The clementine and the cherry-tree starts to grow 1 Node above.
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Sat Feb 16, 2019 17:36

mahogany_shot.png
(90.68 KiB) Not downloaded yet


The magogany-tree starts grow 1 node + x and 1 node + z

lemon_shot.png
(132.29 KiB) Not downloaded yet


The lemon-tree starts grow 1 node under the sapling.
Ok, maybe this is not a but, it's a feature ;-).

Greetings, Clyde.
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Sat Feb 16, 2019 22:31

Clyde wrote:
mahogany_shot.png


The magogany-tree starts grow 1 node + x and 1 node + z

lemon_shot.png


The lemon-tree starts grow 1 node under the sapling.
Ok, maybe this is not a but, it's a feature ;-).

Greetings, Clyde.


Yes, it is an error. I've uploaded the fixes. Can you check it and then tell me if now is all OK?
 

trainwrecktony
Member
 
Posts: 56
Joined: Sun Jun 08, 2014 05:24
Location: NJ USA
In-game: trainwrecktony

Re: [Mod] Clementine Tree (clementinetree)

by trainwrecktony » Sat Feb 16, 2019 23:04

nice trree textures. i reset my server map and added your cherry, clementine, and lemon (doh! i downloaded it early and got the typo lemmon version and even though i manually typied it out a dozen times to add registrations to other mod like moreblocks, mymeshnodes, etc)

one thing to also fix in code clemetine is not dropping leaves theres typo "clementinetree:_leaves"

drop = {
max_items = 1,
items = {
{items = {"clementinetree:sapling"}, rarity = 20},
{items = {"clementinetree:_leaves"}}
}
},
Server Owner trainwrecktony.serveminecraft.net:30000
Server Specs: i5-3570, 16gb, 1tb 7200rpm 64mb cache, Win 2012 r2 x64, Dev mingw x64 minetest build, redis db
Gaming: Clevo W150HNQ, i7-2820, 16gb 1866 hyperx, 256gb Samsung 840 PRO SSD, Nvidia GT 540M, Win 7 Pro x64, Dev mingw x64 minetest build
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Sat Feb 16, 2019 23:22

trainwrecktony wrote:nice trree textures. i reset my server map and added your cherry, clementine, and lemon (doh! i downloaded it early and got the typo lemmon version and even though i manually typied it out a dozen times to add registrations to other mod like moreblocks, mymeshnodes, etc)

one thing to also fix in code clemetine is not dropping leaves theres typo "clementinetree:_leaves"

drop = {
max_items = 1,
items = {
{items = {"clementinetree:sapling"}, rarity = 20},
{items = {"clementinetree:_leaves"}}
}
},


Thanks, now that it is fixed too.
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Sun Feb 17, 2019 01:29

The trees do now all the same:
I use mapgen v7, but the generated trees are growing right and without a problem.

But if you plant a tree, they start grow 2 node next to x and 2 node next to z from the sapling.
Except the mahoganytree grows now 3 node next to x and 3 nodes next to z from the sapling.

Image

Greetings, Clyde.
Attachments
treeshot.jpg
(233.34 KiB) Not downloaded yet
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Sun Feb 17, 2019 10:56

Clyde wrote:The trees do now all the same:
I use mapgen v7, but the generated trees are growing right and without a problem.

But if you plant a tree, they start grow 2 node next to x and 2 node next to z from the sapling.
Except the mahoganytree grows now 3 node next to x and 3 nodes next to z from the sapling.

Image

Greetings, Clyde.


I fix that offset and now it could be fixed. I've checked:

Image

Image

Thanks for inform about bugs!
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Sun Feb 17, 2019 14:02

Hello runs,

Bugreport:

Clementinetree
Mahoganytree
Lemontree

Check the schematics, you use there always the cherrytree-schematics.

Only Mahoganytree has trouble with the coordinates:

Image

Greetings, Clyde.

treeshot_mahogany.jpg
(199.24 KiB) Not downloaded yet
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Sun Feb 17, 2019 20:57

Clyde wrote:Hello runs,

Bugreport:

Clementinetree
Mahoganytree
Lemontree

Check the schematics, you use there always the cherrytree-schematics.

Only Mahoganytree has trouble with the coordinates:

Image

Greetings, Clyde.

treeshot_mahogany.jpg


Yes, you're right. I reuploaded a new *I hope* fixed version.

I checked carefully. Please confirm me that finally works.
 

User avatar
Clyde
Member
 
Posts: 53
Joined: Sat Jul 30, 2016 14:23
GitHub: acmgit
In-game: clyde

Re: [Mod] Clementine Tree (clementinetree)

by Clyde » Mon Feb 18, 2019 00:35

Next Bugreport:
Take a look on the lemontree:trunk

on_rightclick ....

There is an old function for cork, that let crash a server, if the mod isn't there.
If you replace it with on of the other on_rightclick-functions from cherry, clementine or. mahogany, then the trees works well and without problems.

Greetings, Clyde.
 

User avatar
runs
Member
 
Posts: 257
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: [Mod] Clementine Tree (clementinetree)

by runs » Mon Feb 18, 2019 21:24

Clyde wrote:Next Bugreport:
Take a look on the lemontree:trunk

on_rightclick ....

There is an old function for cork, that let crash a server, if the mod isn't there.
If you replace it with on of the other on_rightclick-functions from cherry, clementine or. mahogany, then the trees works well and without problems.

Greetings, Clyde.


Hey guy, you was right. Fixed the cork issue.
 


Return to WIP Mods



Who is online

Users browsing this forum: Bing [Bot] and 4 guests