Wooden Bucket [wooden_bucket]

User avatar
Hume2
Member
 
Posts: 195
Joined: Tue Jun 19, 2018 08:24
Location: Czech Republic
GitHub: Hume2
In-game: Hume2

Wooden Bucket [wooden_bucket]

by Hume2 » Thu Feb 14, 2019 10:58

Wooden Bucket
Hello everyone!
Image

This mod is simple. It adds a bucket made of wood. Wooden bucket can hold only water or river water, not lava. This bucket is good so you can go farming before you obtain some iron.
Image

License:
code: LGPL v. 2.1
textures: CC-BY-SA 3.0

Dependencies:
default

Download:
direct zip: https://gitlab.com/h2mm/wooden_bucket/-/archive/master/wooden_bucket-master.zip
GitLab repository: https://gitlab.com/h2mm/wooden_bucket
Attachments
craft.jpg
(7.12 KiB) Not downloaded yet
shot.jpg
(114.03 KiB) Not downloaded yet
If you lack the reality, go on a trip or find a job.
 

Sokomine
Member
 
Posts: 3707
Joined: Sun Sep 09, 2012 17:31
GitHub: Sokomine

Re: Wooden Bucket [wooden_bucket]

by Sokomine » Thu Feb 14, 2019 12:25

Nice! I was looking for a wooden bucket. However..it does seem to be a copy of the bucket code from MTG, with a few changes done? I'm not very satisifed with cut&paste code. Those things tend to develop apart over time and are difficult to maintain. It would be much better if the bucket code from MTG could be changed so that it allows for diffrent types of buckets. Admittedly, there're not that many buckets you might want to have, so there was probably not enough need before. But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible. Perhaps opening an issue on Github and/or offering a PR might be a good solution if you have the time to do it.
A list of my mods can be found here.
 

User avatar
Linuxdirk
Member
 
Posts: 1791
Joined: Wed Sep 17, 2014 11:21
Location: Germany
In-game: Linuxdirk

Re: Wooden Bucket [wooden_bucket]

by Linuxdirk » Thu Feb 14, 2019 13:29

Sokomine wrote:But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible.

Yes, a bucket API would be pretty awesome. Something like

Code: Select all
bucket.register('modname:bucketname', {
    material = 'modname:itemname',
    textures = { 'modname_bucketname_empty.png', 'modname_bucketname_full.png' },
    holds = { 'liquid:one', 'liquid:two', 'liquid:etc' }
})

So modders can register buckets of material that hold all of holds liquids with textures being the bucket design.
 

wziard
Member
 
Posts: 103
Joined: Mon Oct 29, 2018 19:12

Re: Wooden Bucket [wooden_bucket]

by wziard » Thu Feb 14, 2019 14:49

the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?
 

User avatar
Lone_Wolf
Member
 
Posts: 2073
Joined: Sun Apr 09, 2017 05:50
Location: Hopefully very far from yours, snoop :P
GitHub: LoneWolfHT
IRC: Lone_Wolf
In-game: Lone_Wolf

Re: Wooden Bucket [wooden_bucket]

by Lone_Wolf » Thu Feb 14, 2019 20:11

wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?

No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots
 

User avatar
Stix
Member
 
Posts: 1354
Joined: Fri Aug 04, 2017 14:19
Location: USA
IRC: nil
In-game: Stix [+alts]

Re: Wooden Bucket [wooden_bucket]

by Stix » Thu Feb 14, 2019 22:15

Lone_Wolf wrote:
wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?

No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots

All of you have it wrong, the recipe for a boat is as follows:

XXX
WXW
WWW

where X = nothing and W = group:wood.

If you weren't sure a quick glance at the mods init.lua file would have told you that...
Hey, what can i say? I'm the bad guy.
Next release of your favorite game? "Bugfixes" --Wuzzy
[OLD]The new Minetest-offtopic can be found here: https://minetestoftopic.createaforum.com/index.php
 

User avatar
Lone_Wolf
Member
 
Posts: 2073
Joined: Sun Apr 09, 2017 05:50
Location: Hopefully very far from yours, snoop :P
GitHub: LoneWolfHT
IRC: Lone_Wolf
In-game: Lone_Wolf

Re: Wooden Bucket [wooden_bucket]

by Lone_Wolf » Thu Feb 14, 2019 22:37

Stix wrote:
Lone_Wolf wrote:
wziard wrote:the recipe for a boat should maybe change. For now it is the same as a wooden bucket I think?

No, they're different. A boat only uses two y slots while this mod's crafting recipe uses 3 y slots

All of you have it wrong, the recipe for a boat is as follows:

XXX y slot 1
WXW y slot 2
WWW y slot 3

where X = nothing and W = group:wood.

If you weren't sure a quick glance at the mods init.lua file would have told you that...

I said they were different?

Nice mod btw Hume2. Any change you could get it on the ContentDB? https://content.minetest.net/
 

wziard
Member
 
Posts: 103
Joined: Mon Oct 29, 2018 19:12

Re: Wooden Bucket [wooden_bucket]

by wziard » Fri Feb 15, 2019 09:12

Stix wrote:XXX
WXW
WWW

If you weren't sure a quick glance at the mods init.lua file would have told you that...

You are right of course. I was in the train on my phone :-)

But as there is no conflict with the boat after all I don't understand why Hume2 didn't just copy the recipe for a steel bucket with wood. It's confusing that it's different. Imho the recipe should be:

WXW
XWX

for a wooden bucket. Just like the steel one.
 

User avatar
Hume2
Member
 
Posts: 195
Joined: Tue Jun 19, 2018 08:24
Location: Czech Republic
GitHub: Hume2
In-game: Hume2

Re: Wooden Bucket [wooden_bucket]

by Hume2 » Fri Feb 15, 2019 12:06

Sokomine wrote:Nice! I was looking for a wooden bucket. However..it does seem to be a copy of the bucket code from MTG, with a few changes done? I'm not very satisifed with cut&paste code. Those things tend to develop apart over time and are difficult to maintain. It would be much better if the bucket code from MTG could be changed so that it allows for diffrent types of buckets. Admittedly, there're not that many buckets you might want to have, so there was probably not enough need before. But...a steel bucket, a wooden bucket (=not suitable for lava), a clay bucket (great material for it), glass and bottles from the vessels mod...they could all be buckets. RealTest even adds a ton of buckets for all those diffrent metals it comes with. It would be great if the bucket mod could get extended and become more flexible. Perhaps opening an issue on Github and/or offering a PR might be a good solution if you have the time to do it.


That's a good idea. I'll look what I can do later. Until it's done, this mod can be used.

wziard wrote:But as there is no conflict with the boat after all I don't understand why Hume2 didn't just copy the recipe for a steel bucket with wood. It's confusing that it's different. Imho the recipe should be:

WXW
XWX

for a wooden bucket. Just like the steel one.

Yes, but this one collides with ethereal:bowl. Maybe ethereal:bowl could be crafted from a wooden bucket.
If you lack the reality, go on a trip or find a job.
 

wziard
Member
 
Posts: 103
Joined: Mon Oct 29, 2018 19:12

Re: Wooden Bucket [wooden_bucket]

by wziard » Fri Feb 15, 2019 22:16

Ah shucks. It's been ages since I used Ethereal, so I forgot.
ethereal:bowl from a bucket (and back) seems like a good idea.
 

ThatGhzGamer
New member
 
Posts: 7
Joined: Fri Feb 15, 2019 22:02
GitHub: ThatGhzGamer

Re: Wooden Bucket [wooden_bucket]

by ThatGhzGamer » Tue Feb 19, 2019 22:16

cool mod going to download :)
(I suck at mining iron in the beginning lol)
OMBZuGgmzofWqMBO9jPLEEHtGNg1pBOZ
 


Return to WIP Mods



Who is online

Users browsing this forum: GreenDimond, trainwrecktony and 3 guests