[Mod] Skins for unified_inventory [u_skins]

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

[Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Replaced by: https://github.com/minetest-mods/skinsdb

Unified Skins
This is an updated fork of dmonty's u_skins mod.

Image
Image
Image
BRAIIINS! -- turn into a monster whenever you want!

Some changes:
  • Removed 2D-skins
  • Code cleanups/rewrites
  • A .NET updater for Winblows users (source code also avalable)
  • Save the last visited page (already existed before, didn't work how it should)
  • Jump from last page to first and back - faster skin switch
  • Remove the skin preview generator, download them instead
  • Fixed some bugs when special letters were used in the meta
  • Eliminated minetest.deserialize() from the code (bad decision)
License: LGPLv2
Depends: unified_inventory, default
Download: GitHub master *.zip
View source: GitHub
Last edited by Krock on Mon Oct 02, 2017 08:21, edited 2 times in total.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Inocudom
Member
Posts: 3085
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Skins for unified_inventory [u_skins]

by Inocudom » Post

Many nasty errors do I have to report:
12:30:58: ERROR[main]: ServerError: ...est_release\bin\..\games\carbone\mods\3d_armor/armor.lua:365: attempt to call field 'get_type' (a nil value)
12:30:59: ERROR[main]: stack traceback:
12:30:59: ERROR[main]: ...est_release\bin\..\games\carbone\mods\3d_armor/armor.lua:365: in function <...est_release\bin\..\games\carbone\mods\3d_armor/armor.lua:293>
12:45:37: ERROR[main]: Error loading mod "win32.NET": modname does not follow naming conventions: Only chararacters [a-z0-9_] are allowed.
12:45:37: ERROR[main]: Server: Failed to load and run C:\gsmapper_minetest_release\bin\..\mods\u_skinsdb\win32.NET\init.lua
12:45:38: ERROR[main]: ModError: ModError: Failed to load and run C:\gsmapper_minetest_release\bin\..\mods\u_skinsdb\win32.NET\init.lua
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Inocudom wrote:C:\gsmapper_minetest_release\bin\..\mods\u_skinsdb\win32.NET\init.lua
12:45:38: ERROR[main]: ModError: ModError: Failed to load and run C:\gsmapper_minetest_release\bin\..\mods\u_skinsdb\win32.NET\init.lua
Okay.
Fixed them.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Inocudom
Member
Posts: 3085
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Skins for unified_inventory [u_skins]

by Inocudom » Post

You were successful in fixing the errors, but I don't know how to get the extra skins.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Inocudom wrote:You were successful in fixing the errors, but I don't know how to get the extra skins.
The README, you did not read wrote:To download the latest skins you need to run:
"./update_from_db.py" OR
the win32.NET client
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Inocudom
Member
Posts: 3085
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Skins for unified_inventory [u_skins]

by Inocudom » Post

Calinou wrote:
Inocudom wrote:It looks like a new glitch has appeared concerning skins. When I change the skin that I am using ingame, the player model becomes a solid color and stays that way until the next play session. The mods I used are below:
https://github.com/minetest-technic/datastorage-datastorage
viewtopic.php?f=11&t=3933-unified_inventory
viewtopic.php?f=11&t=9807-u_skins
Yes, player_textures was removed from Carbone at the time.
3d_armor and wieldview probably don't support your skins mod.
Looks like there are mod conflicts here.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Inocudom
Member
Posts: 3085
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Skins for unified_inventory [u_skins]

by Inocudom » Post

Krock, would you be able to post this mod in the forums of Freeminer? If you do, you will have to post a link to the unified_inventory mod.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

mgl
Member
Posts: 39
Joined: Wed Sep 10, 2014 16:13
GitHub: mgl512
Location: France

Re: [Mod] Skins for unified_inventory [u_skins]

by mgl » Post

Minetestforfun's post in the old u_skins thread made me remember about this fix in the script "update_from_db.py": the base64 functions need bytes, not strings.

Code: Select all

diff --git a/update_from_db.py b/update_from_db.py
index 123b200..2aefcf7 100755
--- a/update_from_db.py
+++ b/update_from_db.py
@@ -31,7 +31,7 @@ def addpage(page):
    pages = int(l["pages"])
    for s in l["skins"]:
       f = open(skinsdir + "character_" + str(i) + ".png", "wb")
-      f.write(base64.b64decode(s["img"]))
+      f.write(base64.b64decode(bytes(s["img"], 'utf-8')))
       f.close()
       f = open(metadir + "character_" + str(i) + ".txt", "w")
       f.write(str(s["name"]) + '\n')

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

mgl wrote:Minetestforfun's post in the old u_skins thread made me remember about this fix in the script "update_from_db.py": the base64 functions need bytes, not strings.
Thank you!
Fix error in update script [untested]
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Fritigern
Member
Posts: 43
Joined: Mon Sep 29, 2014 11:01
In-game: Fritigern
Location: Spokane, WA

Re: [Mod] Skins for unified_inventory [u_skins]

by Fritigern » Post

You REALLY need to replace StandardError with something else, like Exception.
From http://www.diveintopython3.net/porting- ... ndarderror (but there are many many other sources for this) :

Code: Select all

In Python 2, StandardError was the base class for all built-in exceptions other than StopIteration, GeneratorExit, KeyboardInterrupt, and SystemExit. In Python 3, StandardError has been eliminated; use Exception instead.
However, even with that fix applied, I keep getting the following error at random moments in the download process:

Code: Select all

Traceback (most recent call last):
  File "./update_from_db.py", line 58, in <module>
    addpage(p+2)
  File "./update_from_db.py", line 25, in addpage
    data = r.read().decode()
AttributeError: 'int' object has no attribute 'read'
I have never succesfully downloaded all the skins, it has ALWAYS exited with an error. Did nobody ever catch this?
--
This is NOT a sig.

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Fritigern wrote:<snip>

I have never succesfully downloaded all the skins, it has ALWAYS exited with an error. Did nobody ever catch this?
I never got this error when I tested it. (two months ago)

Code: Select all

		except Exception:
			if r != 0:
				if r.status != 200:
					print("Error", r.status)
					exit(r.status)
		data = r.read()
Seems like r is 0 because all other would result in an error message.
I tried to fix it but can't test it right now.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Fritigern
Member
Posts: 43
Joined: Mon Sep 29, 2014 11:01
In-game: Fritigern
Location: Spokane, WA

Re: [Mod] Skins for unified_inventory [u_skins]

by Fritigern » Post

This persistent failure to successfully download the skins has led to me writing a bash script of my own. And that one works flawlessly for me.
You have already added my script on Github, so if anyone has a similar issue, they should either update the mod, or download the archive and re-install. :-)
--
This is NOT a sig.

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Added tooltips

Image
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
ExeterDad
Member
Posts: 1717
Joined: Sun Jun 01, 2014 20:00
In-game: ExeterDad
Location: New Hampshire U.S.A

Re: [Mod] Skins for unified_inventory [u_skins]

by ExeterDad » Post

+100!

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Minetestforfun » Post

good update, thank you !

User avatar
mtmodder148
Member
Posts: 131
Joined: Wed May 14, 2014 13:44
GitHub: MT-Modder
In-game: mtmodder148

Re: [Mod] Skins for unified_inventory [u_skins]

by mtmodder148 » Post

Cool thank you very much. I wasn't sure how difficult it would be but bam! done the next day simply awesome :)

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Minetestforfun » Post

Hi,

I am looking for christmas skins for my players...
Please, somebody can share his christmas/santa skins with us ? :D

(For the moment, you don't have christmas/santa skins in the DB of u_skins...)

User avatar
darkninja
Member
Posts: 13
Joined: Sun Mar 16, 2014 11:01

Re: [Mod] Skins for unified_inventory [u_skins]

by darkninja » Post

Ive have tried to run it but it says folder meta not found. "Meta" Is very much there. please help.

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

darkninja wrote:Ive have tried to run it but it says folder meta not found. "Meta" Is very much there. please help.
That directory must be called "meta", not "Meta". Windows can handle those but not Linux.
If renaming the directory does not solve the problem:
- Do you have the newest u_skins version?
- Which updater are you using?
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Lukester
Member
Posts: 16
Joined: Thu Nov 06, 2014 23:53
In-game: LukeOnEnergy

Re: [Mod] Skins for unified_inventory [u_skins]

by Lukester » Post


User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Skins for unified_inventory [u_skins]

by mahmutelmas06 » Post

Could be nice if we could use the mod with blockmen's caracter hand mod
viewtopic.php?f=9&t=7286
My Mods:

Beverage

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

mahmutelmas06 wrote:Could be nice if we could use the mod with blockmen's caracter hand mod
viewtopic.php?f=9&t=7286
BlockMen wrote:Notice: This only works for singleplayer, because you cant change the hand for each player...
Well I can't change that. A better soulation is using the model directly as hand.
Currently, it's just a texture which looks like a "hand".
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Minetestforfun » Post

I tried "simple_skins" with "u_skins" with and without the "erwin.maximilian => simple_skin-unified_invetory.patch.gz" but it doesn't work at all...

Somebody has already coded a compatibility code ? or a merged mod of this two mods ? or maybe can code it ?

In my server we need both mods because "u_skins" is a pretty good skin database but, it's a very bad mod if you want to add skins from players creation, the "u_skins" mod need many precautions and modifications to make this possible... (it's long and not very made for that, i supposed)
While, the "simple_skins" mod is just perfect for this weak point of "u_skins", with this mod we can easily add mods from players creation without touch the "u_skins" mod wich means we can update the "u_skins" without fear :)

"u_skins" mod link : viewtopic.php?t=9807
"simple_skins" mod link : viewtopic.php?f=11&t=9100

Thank you in advance for your answers !

User avatar
Krock
Developer
Posts: 4499
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Krock » Post

Minetestforfun wrote:I tried "simple_skins" with "u_skins" with <snip>
Sorry but I can't do more than this:
https://github.com/SmallJoker/minetest- ... ommit/e762

There might be texture name conflicts, I can not solve them without renaming all player textures.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Skins for unified_inventory [u_skins]

by Minetestforfun » Post

Thank you Krock, i think it will be a great solution, we are trying this solution right now.

For the name conflicts, don't worry, our "simple_skins" mod is empty because we fill it with players creation skins

(EDIT : Finally we code our own solution wich need only the mod "u_skins" https://github.com/Ombridride/minetest- ... 70786d298e it's an early release, so it's not over but, we are in the good way)

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest